Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: update to v1.26.0 #13878

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Apr 13, 2020

gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2153
WPAndroid: wordpress-mobile/WordPress-Android#11647

To test:

Bug fix

New feature & Improvement

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 13, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Apr 13, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 13, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@pinarol
Copy link
Contributor Author

pinarol commented Apr 13, 2020

Writing flow sanity check:

@pinarol pinarol requested review from geriux and etoledom April 13, 2020 17:11
@pinarol pinarol self-assigned this Apr 13, 2020
@pinarol
Copy link
Contributor Author

pinarol commented Apr 14, 2020

I completed the tests, could only find 1 bug, which doesn't look like a blocker. But I appreciate an extra eye on writing flow. @etoledom Thanks!

@etoledom
Copy link
Contributor

Writing flow tests from #13878 (comment)

Changes tests:

  • ✅ Block editor: Disable ripple effect in all BottomSheet's controls.
  • ✅ Block editor: New block: Columns
  • ✅ Block editor: New starter page template: Blog
  • ✅ Block editor: Make Starter Page Template picker buttons visible only when the screen height is enough
  • ✅ Block editor: Fix a bug which caused to show URL settings modal randomly when changing the device orientation multiple times during the time Starter Page Template Preview is open (I didn't have much background on this one but didn't noticed anything estrange following the provided steps).

Note: I noticed something strange on the Latest Posts settings bottom sheets:
At first it wasn't scrolling to show the last control, then I notice that it won't scroll if I happen to tap. over the Section Title (Post meta settings or Sorting and filtering).

Other settings doesn't have so many sections so it's not so noticeable, but on this one took me a bit to make it scroll and to realice what was happening.

This happens on the previously released version too, not a regression from this one.

@pinarol
Copy link
Contributor Author

pinarol commented Apr 14, 2020

Thank you @etoledom !

At first it wasn't scrolling to show the last control, then I notice that it won't scroll if I happen to tap. over the Section Title (Post meta settings or Sorting and filtering).

Interesting finding. Could you open an issue and add to Mobile Gutenpages board? Don't think this is a blocker but definitely worth investigating.

@etoledom
Copy link
Contributor

Could you open an issue and add to Mobile Gutenpages board?

wordpress-mobile/gutenberg-mobile#2160 👍

@pinarol pinarol merged commit 0bbef0e into develop Apr 16, 2020
@pinarol pinarol deleted the gutenberg/integrate_release_1.26.0 branch April 16, 2020 14:01
pull bot pushed a commit to scope-demo/WordPress-iOS that referenced this pull request Apr 16, 2020
* Point gutenberg hash to release/1.26.0

* Update release notes

* Update release notes

* Update gutenberg ref

* Point gutenberg to v1.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants