Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Correct colors usage in Button #21603

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Apr 15, 2020

Description

Correct colors usage in Button after web changes.

ref to gb-mobile: wordpress-mobile/gutenberg-mobile#2155

How has this been tested?

Testing HTML:

<!-- wp:button {"customBackgroundColor":"#325766"} -->
<div class="wp-block-button"><a class="wp-block-button__link has-background" style="background-color:#325766">CUSTOM</a></div>
<!-- /wp:button -->

<!-- wp:button {"gradient":"luminous-dusk"} -->
<div class="wp-block-button"><a class="wp-block-button__link has-background has-luminous-dusk-gradient-background">GRADIENT</a></div>
<!-- /wp:button -->

<!-- wp:button {"backgroundColor":"secondary"} -->
<div class="wp-block-button"><a class="wp-block-button__link has-background has-secondary-background-color">PALETTE</a></div>
<!-- /wp:button -->

<!-- wp:button {"customTextColor":"#90318f"} -->
<div class="wp-block-button"><a class="wp-block-button__link has-text-color" style="color:#90318f">TEXT CUSTOM</a></div>
<!-- /wp:button -->

<!-- wp:button {"textColor":"background"} -->
<div class="wp-block-button"><a class="wp-block-button__link has-text-color has-background-color">TEXT PALETTE</a></div>
<!-- /wp:button -->

Paste that HTML on the mobile editor and compare it with that screenshot:
Screenshot 2020-04-15 at 11 05 15

Another way to test:

  1. Open post on web
  2. Add Buttons block and create a couple of Buttons inside:
    • Button with custom background color
    • Button with color from palette color
    • Button with gradient color
    • Button with text custom color
    • Button with text color from palette color
  3. Open HTML view
  4. Remove Buttons container to have separated list of Button
  5. Save draft
  6. Open post on mobile app
  7. Expect:
    • Button with custom background color - button should have the same background color
    • Button with color from palette - button should have gray fallback color
    • Button with gradient color - button should have a gradient color
    • Button with text custom color - button text should have text custom color
    • Button with text color from palette - button text should have white text

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Buttons Affects the Buttons Block labels Apr 15, 2020
@github-actions
Copy link

github-actions bot commented Apr 15, 2020

Size Change: 0 B

Total Size: 839 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.01 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.24 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-editor/style-rtl.css 10.2 kB 0 B
build/block-editor/style.css 10.2 kB 0 B
build/block-library/editor-rtl.css 7.11 kB 0 B
build/block-library/editor.css 7.11 kB 0 B
build/block-library/index.js 112 kB 0 B
build/block-library/style-rtl.css 7.13 kB 0 B
build/block-library/style.css 7.14 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 198 kB 0 B
build/components/style-rtl.css 16.6 kB 0 B
build/components/style.css 16.6 kB 0 B
build/compose/index.js 6.66 kB 0 B
build/core-data/index.js 11.1 kB 0 B
build/data-controls/index.js 1.25 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 3.1 kB 0 B
build/edit-navigation/style-rtl.css 279 B 0 B
build/edit-navigation/style.css 280 B 0 B
build/edit-post/index.js 27.8 kB 0 B
build/edit-post/style-rtl.css 12.3 kB 0 B
build/edit-post/style.css 12.3 kB 0 B
build/edit-site/index.js 10.4 kB 0 B
build/edit-site/style-rtl.css 5.02 kB 0 B
build/edit-site/style.css 5.02 kB 0 B
build/edit-widgets/index.js 7.53 kB 0 B
build/edit-widgets/style-rtl.css 4.65 kB 0 B
build/edit-widgets/style.css 4.64 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/editor/index.js 43.6 kB 0 B
build/editor/style-rtl.css 3.49 kB 0 B
build/editor/style.css 3.49 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.32 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.91 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.28 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.67 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.67 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@lukewalczak lukewalczak self-assigned this Apr 15, 2020
@lukewalczak lukewalczak requested a review from dratwas April 15, 2020 09:56
@lukewalczak lukewalczak merged commit b1edf9b into master Apr 15, 2020
@lukewalczak lukewalczak deleted the fix-button-colors branch April 15, 2020 11:51
@github-actions github-actions bot added this to the Gutenberg 8.0 milestone Apr 15, 2020
pinarol pushed a commit that referenced this pull request Apr 15, 2020
pinarol added a commit that referenced this pull request Apr 16, 2020
* Correct colors usage in Buttons

Co-authored-by: Luke Walczak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants