-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Correct colors usage in Button #21603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Block] Buttons
Affects the Buttons Block
labels
Apr 15, 2020
2 tasks
Size Change: 0 B Total Size: 839 kB ℹ️ View Unchanged
|
pinarol
reviewed
Apr 15, 2020
dratwas
reviewed
Apr 15, 2020
dratwas
reviewed
Apr 15, 2020
dratwas
reviewed
Apr 15, 2020
dratwas
approved these changes
Apr 15, 2020
pinarol
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Correct colors usage in Buttons
6 tasks
12 tasks
pinarol
added a commit
that referenced
this pull request
Apr 16, 2020
* Correct colors usage in Buttons Co-authored-by: Luke Walczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Buttons
Affects the Buttons Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct colors usage in
Button
after web changes.ref to gb-mobile: wordpress-mobile/gutenberg-mobile#2155
How has this been tested?
Testing HTML:
Paste that HTML on the mobile editor and compare it with that screenshot:
Another way to test:
Buttons
container to have separated list of ButtonChecklist: