-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taking latest #1
Commits on Nov 3, 2018
-
Fix IllegalStateException when dismissing DialogManager
Summary: This diff fixes a IllegalStateException that can happen because of a race condition when using DialogManager Reviewed By: fkgozali Differential Revision: D12899432 fbshipit-source-id: 98fb7c1ee1d292a959628a33c8a2dd5a6d93e328
Configuration menu - View commit details
-
Copy full SHA for 38e01a2 - Browse repository at this point
Copy the full SHA 38e01a2View commit details -
Trivial cleanup in ReactRootView
Summary: Trivial clanup of imports in ReactRootView Reviewed By: fkgozali Differential Revision: D12899430 fbshipit-source-id: 83bb052bbeee9e02e91157305420a2dd799e60e2
Configuration menu - View commit details
-
Copy full SHA for 83c7303 - Browse repository at this point
Copy the full SHA 83c7303View commit details -
RN: Copyright Header for
ReactInstanceManagerTest.java
Summary: Missing when D12829677 landed. Reviewed By: mdvacca Differential Revision: D12903182 fbshipit-source-id: 1c142acb2a098b1118170f2f8ed8cf719fc14f90
Configuration menu - View commit details
-
Copy full SHA for 4d16a0e - Browse repository at this point
Copy the full SHA 4d16a0eView commit details
Commits on Nov 4, 2018
-
Fix the comment for getSize in Image.android.js (#22092)
Summary: A minor change to the comment in the Image.android.js file. Pull Request resolved: #22092 Differential Revision: D12918066 Pulled By: TheSavior fbshipit-source-id: f27c63241c9dde780c037edcbcdf4cc10d55d33e
Configuration menu - View commit details
-
Copy full SHA for a09aca5 - Browse repository at this point
Copy the full SHA a09aca5View commit details -
Fix duplicate function declaration in WebSockets (#22098)
Summary: Fixes the only ESLint error pending to resolve. It was a duplicate `get` declaration. Pull Request resolved: #22098 Differential Revision: D12918078 Pulled By: TheSavior fbshipit-source-id: c738d6880241dbc1f1ddc06c2d4e52443c00768a
Configuration menu - View commit details
-
Copy full SHA for b03b9d5 - Browse repository at this point
Copy the full SHA b03b9d5View commit details -
Improving Modal
visible
prop check to handle undefined and null (#2……2072) Summary: Changing the the this.props.visible if to be ` if (!!this.props.visible === false)` . So passing undefined, or other values wont set the modal to be visible. Granting that anything that is not true, will set the modal to null on the render. I make this this PR, because on the company that im working, we used a lot of RN. At the moment, we arent using anything like flow or TS. But to grant that the modals will only show if they are set visible to true i have changed the if made. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: #22072 Differential Revision: D12918086 Pulled By: TheSavior fbshipit-source-id: 8f9c63ac6fd56d83949bb8428ad7c5b7bf805c49
Configuration menu - View commit details
-
Copy full SHA for cc13a73 - Browse repository at this point
Copy the full SHA cc13a73View commit details -
Flow strict ScrollViewMock (#22103)
Summary: Related to #22100 Turn Flow strict mode on for ScrollViewMock. This file used to declare jest var as `any` but jest module is already typed in root flow folder. Note: I had to use a quick fix for polyfillPromise. See here #22101 - All flow tests succeed. [GENERAL] [ENHANCEMENT] [ScrollViewMock.js] - Flow strict mode Pull Request resolved: #22103 Differential Revision: D12918380 Pulled By: TheSavior fbshipit-source-id: cd3aba47b1a43e76a7da09e15cc2d9cfcdf7f56d
Configuration menu - View commit details
-
Copy full SHA for 499c195 - Browse repository at this point
Copy the full SHA 499c195View commit details -
Remove var in Libraries/emitter/* (#22087)
Summary: Replaces the keywords var with const in Libraries/emitter/EventValidator.js If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ - [x] Check npm run flow - [x] Check npm run flow-check-ios - [x] Check npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/emitter] - remove `var` Pull Request resolved: #22087 Differential Revision: D12918444 Pulled By: TheSavior fbshipit-source-id: 630ccb283fd6c3118a22124a656038eac4a88599
Configuration menu - View commit details
-
Copy full SHA for cf70870 - Browse repository at this point
Copy the full SHA cf70870View commit details -
Summary: There are some critical bugs that require further investigation in the most recent upgrade to React 16.6 (and ReactNativeRenderer changes). This revision reverts the sync until these issues have been resolved. Reviewed By: mdvacca Differential Revision: D12918541 fbshipit-source-id: 5c1ada185851ba599f3c86387158a2b41f3dcf3e
Configuration menu - View commit details
-
Copy full SHA for 6448f4e - Browse repository at this point
Copy the full SHA 6448f4eView commit details -
Remove flow-strict from polyfillPromise (#22048)
Summary: Flow is broken for a bunch of people and has been for the last few days. For some reason this isn't causing any builds to fail which we will need to look into. For now, this stops the bleeding. I *think* this is because of case sensitivity differenes between Mac and where all of our CI machines run. ``` Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ Libraries/Core/polyfillPromise.js:21:33 Importing from an untyped module makes it any and is not safe! Did you mean to add // flow to the top of Promise? (untyped-import) 18│ * If you don't need these polyfills, don't use InitializeCore; just directly 19│ * require the modules you need from InitializeCore for setup. 20│ */ 21│ polyfillGlobal('Promise', () => require('Promise')); 22│ ``` Pull Request resolved: #22048 Reviewed By: shergin Differential Revision: D12918418 Pulled By: TheSavior fbshipit-source-id: 9d9db1b3686eab906244180325c12ffcce92be8c
Configuration menu - View commit details
-
Copy full SHA for 01b7c48 - Browse repository at this point
Copy the full SHA 01b7c48View commit details -
Remove unused variables (#22097)
Summary: Fix unused variable ESLint warnings. Pull Request resolved: #22097 Differential Revision: D12919249 Pulled By: TheSavior fbshipit-source-id: f680fa7277c58cf685e70dfb911753a30fe01c1d
Configuration menu - View commit details
-
Copy full SHA for 6ebee18 - Browse repository at this point
Copy the full SHA 6ebee18View commit details -
Replace var to const in Libraries/Utilities/deepFreezeAndThrowOnMutat…
…ionInDev-test.js (#22110) Summary: Replaces the keywords var to const in Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js - [x] Check npm run flow - [x] Check npm run flow-check-ios - [x] Check npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js] - replace var Pull Request resolved: #22110 Differential Revision: D12919284 Pulled By: TheSavior fbshipit-source-id: 4a3a3f4c49665c538ed5f38f3cc2142d40ac4d55
Configuration menu - View commit details
-
Copy full SHA for e835c6d - Browse repository at this point
Copy the full SHA e835c6dView commit details -
Remove var in Libraries/vendor/core/merge.js (#22108)
Summary: Replaces the keywords var with const in Libraries/merge.js If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible! - [x] Check npm run flow - [x] Check npm run flow-check-ios - [x] Check npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/core] - remove var Pull Request resolved: #22108 Differential Revision: D12919282 Pulled By: TheSavior fbshipit-source-id: e3c8569c47c95ad3d1a061917c90185c2694c78f
Configuration menu - View commit details
-
Copy full SHA for 3f069f3 - Browse repository at this point
Copy the full SHA 3f069f3View commit details -
Remove var in Libraries/Utilities/MatrixMath.js (#22111)
Summary: Replaces the keywords var with let in Libraries/Utilities/MatrixMath.js - [x] Check npm run flow - [x] Check npm run flow-check-ios - [x] Check npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Utilities/MatrixMath.js] - remove `var` Pull Request resolved: #22111 Differential Revision: D12919285 Pulled By: TheSavior fbshipit-source-id: dca65d2da311b5c50ab6ce7338af1cc941fb7a33
Configuration menu - View commit details
-
Copy full SHA for 368518e - Browse repository at this point
Copy the full SHA 368518eView commit details -
Remove var in Libraries/Utilities/buildStyleInterpolator.js (#22112)
Summary: Replaces the keywords var with const in Libraries/Utilities/buildStyleInterpolator.js Pull Request resolved: #22112 Differential Revision: D12919286 Pulled By: TheSavior fbshipit-source-id: bc39a1efc2c372365d95cd305cc6d915f030b209
Configuration menu - View commit details
-
Copy full SHA for b01bf06 - Browse repository at this point
Copy the full SHA b01bf06View commit details -
Make PR template consistent with Changelog (#22117)
Summary: In the new changelog format, we're following [Keep a Changelog](https://keepachangelog.com/en/1.0.0). This change updates the PR template to follow their change types, plus it simplifies the *CATEGORY* field to follow the changelog's groupings. Some simplified examples have been provided, though I plan to revisit this after 0.58 to add real-world examples. This change is motivated by react-native-community/releases#47. Pull Request resolved: #22117 Differential Revision: D12919271 Pulled By: TheSavior fbshipit-source-id: 91f063f769357b24383db281545678b924ad3efb
Configuration menu - View commit details
-
Copy full SHA for ce18036 - Browse repository at this point
Copy the full SHA ce18036View commit details
Commits on Nov 5, 2018
-
Fix rn-cli linting issues (#22099)
Summary: Fixes ESLint warnings in `react-native-cli`. I isolated this PR from other lint fixes because of the top `DO NOT MODIFY THIS FILE` message. Either way I think this issues should be fixed :) Pull Request resolved: #22099 Differential Revision: D12920673 Pulled By: TheSavior fbshipit-source-id: ed1308fe7ef4633b793d85fe8c6ce5d068651e12
Configuration menu - View commit details
-
Copy full SHA for 7b10a02 - Browse repository at this point
Copy the full SHA 7b10a02View commit details -
Turn Flow strict mode on for DatePickerIOS (#22105)
Summary: Related to #22100 Turn Flow strict mode on for DatePickerIOS. - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android This error was happend #22101 #22048 [GENERAL] [ENHANCEMENT] [Components/DatePicker/DatePickerIOS.ios.js] - Flow strict mode Pull Request resolved: #22105 Differential Revision: D12920939 Pulled By: TheSavior fbshipit-source-id: aae5ca04d656abb1cf34168e12e44dd50f0a603c
Configuration menu - View commit details
-
Copy full SHA for 3c0211b - Browse repository at this point
Copy the full SHA 3c0211bView commit details -
Turn Flow strict mode on for KeyBoard (#22114)
Summary: Related to #22100 Turn Flow strict mode on for KeyBoard - [x] npm run prettier - [ ] npm run flow-check-ios - [ ] npm run flow-check-android This error was happend #22101 #22048 [GENERAL] [ENHANCEMENT] [Components/Keyboard/Keyboard.js] - Flow strict mode Pull Request resolved: #22114 Differential Revision: D12920947 Pulled By: TheSavior fbshipit-source-id: 8d72019efd4d30032ce4784764e5deb9c60e7b01
Configuration menu - View commit details
-
Copy full SHA for fbc5a4f - Browse repository at this point
Copy the full SHA fbc5a4fView commit details -
remove var in ReactAndroid/src/androidTest (#22136)
Summary: I removed var in ReactAndroid/src/androidTest. - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ReactAndroid/src/androidTest] - remove var Pull Request resolved: #22136 Differential Revision: D12921227 Pulled By: TheSavior fbshipit-source-id: 45c03a52a5eafa25965aa785da094421c3df3999
Configuration menu - View commit details
-
Copy full SHA for 0beb1cc - Browse repository at this point
Copy the full SHA 0beb1ccView commit details -
remove var in ReactAndroid/src/androidTest. (#22137)
Summary: I removed var in ReactAndroid/src/androidTest. - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ReactAndroid/src/androidTest] - remove var Pull Request resolved: #22137 Differential Revision: D12921228 Pulled By: TheSavior fbshipit-source-id: d3b7380b6047fc304265d0f47a53cb1170a6aea6
Configuration menu - View commit details
-
Copy full SHA for 6f781d9 - Browse repository at this point
Copy the full SHA 6f781d9View commit details -
Remove var in ReactAndroid/src/androidTest (#22135)
Summary: I removed var in ReactAndroid/src/androidTest. - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ReactAndroid/src/androidTest] - remove var Pull Request resolved: #22135 Differential Revision: D12921224 Pulled By: TheSavior fbshipit-source-id: 9a14755944df642f8b82c46c691d6ed6ee8fa623
Configuration menu - View commit details
-
Copy full SHA for 9d13233 - Browse repository at this point
Copy the full SHA 9d13233View commit details -
Performance improvement for loading cached images on iOS (#20356)
Summary: This PR increases the speed at which cached images are loaded and displayed on the screen. Images are currently cached in memory using RCTImageCache, but each time they are loaded, a round trip through RCTNetworking happens before RCTImageCache is even checked. This is likely so that RCTNetworking can handle the caching behavior required by the HTTP headers. However, this means that at the very least, images are read from disk each time they're loaded. This PR makes RCTImageLoader check RCTImageCache _before_ sending a request to RCTNetworking. RCTImageCache stores a bit of information about the response headers so that it can respect Cache-Control fields without needing a roundtrip through RCTNetworking. Here are a couple of graphs showing improved loading times before this change (blue) and after (red) with SDWebImage (yellow) as a baseline comparison. The increase is most evident when loading especially large (hi-res photo size) images, or loading multiple images at a time. https://imgur.com/a/cnL47Z0 More performance gains can potentially be had by increasing the size limit of RCTImageCache: https://github.com/facebook/react-native/blob/1a6666a116fd8b9e8637956de2b41a1c315dd470/Libraries/Image/RCTImageCache.m#L39 but this comes at the tradeoff of being more likely to run into OOM crashes. Pull Request resolved: #20356 Reviewed By: PeteTheHeat Differential Revision: D12909121 Pulled By: alsun2001 fbshipit-source-id: 7f5e21928c53d7aa53f293b7f1b4ec5c99b5f0c2
Configuration menu - View commit details
-
Copy full SHA for 54f7eb3 - Browse repository at this point
Copy the full SHA 54f7eb3View commit details -
Increase cache and file size limits
Summary: This change expands the limits to support a greater variety of scenarios. Reviewed By: PeteTheHeat Differential Revision: D12911841 fbshipit-source-id: a7c8eb6fece49dfe47b3ada98f55a02b43396ce8
Configuration menu - View commit details
-
Copy full SHA for 3a98318 - Browse repository at this point
Copy the full SHA 3a98318View commit details -
Disallow Optional::operator=(nullptr_t) unless T is a pointer
Summary: The old implementation of folly::none inadvertently allowed disengaging an optional by writing `op = nullptr`. Disallow that and require `op = folly::none`. Reviewed By: yfeldblum Differential Revision: D12884724 fbshipit-source-id: b17bcf00b245069d8ea2d9bc3703b0fdcaa85c07
Configuration menu - View commit details
-
Copy full SHA for 79712c3 - Browse repository at this point
Copy the full SHA 79712c3View commit details -
remove createReactClass from ToolbarAndroid/ToolbarAndroid.android.js (…
…#21893) Summary: Related to #21581 . Removed createReactClass from the Libraries/Components/ToolbarAndroid/ToolbarAndroid.android.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Components/ToolbarAndroid/ToolbarAndroid.android.js] - remove createReactClass dependency Pull Request resolved: #21893 Reviewed By: TheSavior Differential Revision: D12826971 Pulled By: RSNara fbshipit-source-id: 3d3fb88a3c9faf3ef89e386ca0d41d939f5d14dd
Configuration menu - View commit details
-
Copy full SHA for 147c38a - Browse repository at this point
Copy the full SHA 147c38aView commit details -
remove createReactClass from SegmentedControlIOS.ios.js (#21888)
Summary: Related to #21581 . Removed createReactClass from the SegmentedControlIOS.ios.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Components/SegmentedControlIOS/SegmentedControlIOS.ios.js] - remove createReactClass dependency Pull Request resolved: #21888 Reviewed By: TheSavior Differential Revision: D12827447 Pulled By: RSNara fbshipit-source-id: 74a91bcba131d9a34a136c6127459a40424a0738
Configuration menu - View commit details
-
Copy full SHA for 0ea95e7 - Browse repository at this point
Copy the full SHA 0ea95e7View commit details -
Flow type RefreshControl (#22119)
Summary: Related to #22100 Enhance Flow types for RefreshControl specifying `onRefresh` props type. There are still 2 `any` left using `requireNativeComponent` that need to be addressed to turn Flow to strict mode. I went through `RCTRefreshControl` and `AndroidSwipeRefreshLayout` classes to understand where this method came from. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [RefreshControl.js] - Flow onRefresh type Pull Request resolved: #22119 Differential Revision: D12919764 Pulled By: TheSavior fbshipit-source-id: 9ba675be8dbce77d77972acb904fc13c68524831
Configuration menu - View commit details
-
Copy full SHA for 84c5416 - Browse repository at this point
Copy the full SHA 84c5416View commit details -
Summary: Removes unused styles. NOTE: Lint rule `react-native/no-unused-styles` not added because of custom lint rule internally at Facebook that does this. Pull Request resolved: #22083 Differential Revision: D12929443 Pulled By: TheSavior fbshipit-source-id: d42b0be3db745e445447e65df3b78b61f53e4229
Configuration menu - View commit details
-
Copy full SHA for ffd7195 - Browse repository at this point
Copy the full SHA ffd7195View commit details -
Fix
no-shadow
eslint warning & remove var (#22124)Summary: Fixes `no-shadow` warning for `local-cli/link/ios/getGroup.js` and remove `var` declaration keyword. ``` react-native/local-cli/link/ios/getGroup.js 13:23 warning 'group' is already declared in the upper scope no-shadow ``` - [x] Check `npm run flow` - [x] Check `npm run flow-check-ios` - [x] Check `npm run flow-check-android` - [x] Check `npm run lint` N/A Pull Request resolved: #22124 Differential Revision: D12929717 Pulled By: TheSavior fbshipit-source-id: 10f8269ae7a0e61f4d0ec6fe710889c3a7c90b3b
Configuration menu - View commit details
-
Copy full SHA for f8040ed - Browse repository at this point
Copy the full SHA f8040edView commit details -
Removed unnecessary code in Libraries/Text/Text.js (#22132)
Summary: I don't think it's necessary to use spread properties (prevState) in `getDerivedStateFromProps` Pull Request resolved: #22132 Differential Revision: D12929838 Pulled By: TheSavior fbshipit-source-id: cdc4f9df8e2f0b2878aec605478144b3e08cea89
Configuration menu - View commit details
-
Copy full SHA for 0d4f627 - Browse repository at this point
Copy the full SHA 0d4f627View commit details -
Flow strict StaticContainer (#22121)
Summary: Related to #22100 Turn on Flow strict mode for StaticContainer.react This component needed proper Props type definition. I went through the only component (`TabBarItemIOS.ios`) using this to try to know the most appropriate props. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [StaticContainer.react.js] - Flow strict mode Pull Request resolved: #22121 Differential Revision: D12929646 Pulled By: TheSavior fbshipit-source-id: 8826aa7bc83c854efdd71cdb4fba3d7ca98f2fce
Configuration menu - View commit details
-
Copy full SHA for 6476151 - Browse repository at this point
Copy the full SHA 6476151View commit details -
Remove var in /Libralies/Experimental/IncrementalPresenter.js (#22144)
Summary: Remove `var` declaration keyword in ` /Libralies/Experimental/IncrementalPresenter.js` . - [x] Check `npm run flow` - [x] Check `npm run flow-check-ios` - [x] Check `npm run flow-check-android` - [x] Check `npm run lint` [GENERAL] [ENHANCEMENT] [Libralies/Experimental] - remove `var` Pull Request resolved: #22144 Differential Revision: D12930731 Pulled By: TheSavior fbshipit-source-id: 64d7689ffec1da14479bdd7106fdea9a3dbeaa42
Configuration menu - View commit details
-
Copy full SHA for cc90c20 - Browse repository at this point
Copy the full SHA cc90c20View commit details -
Flow strict DrawerLayout (#22152)
Summary: Issue in focus: #22100 The only occurrence of `Object` was replaced with the appropriate flow type A Lint error was encountered in `deepFreezeAndThrowOnMutationInDev-test.js` when running `npm run lint` and was fixed by running `yarn prettier` Pull Request resolved: #22152 Differential Revision: D12930872 Pulled By: RSNara fbshipit-source-id: f9706ed2e49d9ccedfa331594c886d2d3b615db5
Configuration menu - View commit details
-
Copy full SHA for f9050e0 - Browse repository at this point
Copy the full SHA f9050e0View commit details -
Flow strict in ViewPagerAndroid.android.js (#22134)
Summary: Related to #22100 Turn Flow strict mode on for Libraries/Components/ViewPager/ViewPagerAndroid.android.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Components/ViewPager/ViewPagerAndroid.android.js] - Flow strict mode Pull Request resolved: #22134 Differential Revision: D12930719 Pulled By: TheSavior fbshipit-source-id: 9519f31b7af27f0497e42fd51f18c19be3692823
Configuration menu - View commit details
-
Copy full SHA for 636e146 - Browse repository at this point
Copy the full SHA 636e146View commit details -
Update and expand bytecode spec
Summary: * Adds parent tag as param for createNode in place of explicit appendChild commands. * Adds version info to bytecode * Adds native conditional support: Conditionals are represented in product code with the new `NativeConditional` React component. It takes params necessary to construct a native function call, and takes a render prop as a child that passes the value of the native call as an arg. In prod, the component would actually call the native module and render with that value, but in jest we render for *both* true and false and set them as children of a new jest-only primitive/host component which we special-case and generate a special command with `OP_CODE.conditional`, generate the appropriate bytecode commands for each branch, and embed them as args in the conditional OP_CODE command. When evaluating the bytecode, only one set of commands is executed, based on the native module value (which is evaluated with another new opcode which computes the value and stuffs it in a "register"). Obviously generating this bytecode is kind of a cludge compared to prepack, but when I asked @[501709947:Dominic] about it, he said they had no bytecode spec right now, so I'm running ahead with this prototype. The main thing I'm focused on is the C++/RN bytecode interpretter - this jest stuff is just a way to generate bytecode for it to consume which could be replaced or augmented with many other approaches, such as prepack, server rendering, etc. Also piggybacked a bunch of other cleanup. Reviewed By: shergin Differential Revision: D10277121 fbshipit-source-id: 15d3217a59ef481b574c742d17d8a7dc893cba90
Configuration menu - View commit details
-
Copy full SHA for aab0160 - Browse repository at this point
Copy the full SHA aab0160View commit details -
mostly working on Android + OTA
Summary: It works great on iOS, and mostly works on Android, and is now OTA'able as part of the screen config! Haven't done template view yet. One remaining issue: Layout is borked on Android. I'm guessing the issue has to do with the timing of setting the constraints in `updateRootLayoutSpecs` and calling `mBinding.startSurface` which actually builds the shadow tree. If I try to call `updateRootLayoutSpecs` earlier, it just crashes immediately. Here's the layout it spits out, which clearly has -440 for the x of 420006, which is the RCTText component, causing it to get cut off on the left of the screen: ``` updateLayoutMountItem for reactTag: 420006 x: -440, y: -13, width: 931, height: 78 updateLayoutMountItem for reactTag: 420010 x: 26, y: 79, width: 0, height: 1651 updateLayoutMountItem for reactTag: 420012 x: 0, y: 26, width: 0, height: 158 updateLayoutMountItem for reactTag: 420016 x: 0, y: 210, width: 454, height: 454 updateLayoutMountItem for reactTag: 420018 x: 454, y: 210, width: 455, height: 454 updateLayoutMountItem for reactTag: 420022 x: 0, y: 690, width: 454, height: 454 updateLayoutMountItem for reactTag: 420024 x: 454, y: 690, width: 455, height: 454 updateLayoutMountItem for reactTag: 420028 x: 0, y: 1171, width: 454, height: 454 updateLayoutMountItem for reactTag: 420030 x: 454, y: 1171, width: 455, height: 454 updateLayoutMountItem for reactTag: 420032 x: 0, y: 1651, width: 0, height: 0 ``` Reviewed By: mdvacca Differential Revision: D12813192 fbshipit-source-id: 450d646af4883ff25184141721351da67b091b7c
Configuration menu - View commit details
-
Copy full SHA for 7b5277b - Browse repository at this point
Copy the full SHA 7b5277bView commit details -
Cleanup a bunch of the JS stuff
Summary: Stricter flow typing, better naming, modularization with context objects, more extensible, etc. Reviewed By: yungsters Differential Revision: D10443440 fbshipit-source-id: 171358dfb105829b872d6379064ba4bc29ce34de
Configuration menu - View commit details
-
Copy full SHA for ccc8a42 - Browse repository at this point
Copy the full SHA ccc8a42View commit details -
rename ReactBytecode -> UITemplate
Summary: React bytecode is kind of a different thing that sebmarkbage already has in mind so lets keep the namespace separate. Reviewed By: mdvacca Differential Revision: D12896293 fbshipit-source-id: e0f266da6e7a051bcf5defea49b958452342754d
Configuration menu - View commit details
-
Copy full SHA for ac9e09d - Browse repository at this point
Copy the full SHA ac9e09dView commit details
Commits on Nov 6, 2018
-
Remove var in Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js (
#22126) Summary: Replaces the keywords var with let or const in Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js - [x] Check npm run flow - [x] Check npm run flow-check-ios - [x] Check npm run flow-check-android [GENERAL] [ENHANCEMENT] [Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js] - remove var Pull Request resolved: #22126 Differential Revision: D12929758 Pulled By: TheSavior fbshipit-source-id: bee9dfb463d197458cb218f39274af5a4d16ce1f
Configuration menu - View commit details
-
Copy full SHA for 0a39cda - Browse repository at this point
Copy the full SHA 0a39cdaView commit details -
Fabric: Using RuntimeExecutor in concrete EventBeats
Summary: Now we use RuntimeExecutor instead of MessageQueue; that's more clear and remove a dependency from Bridge. Reviewed By: sahrens Differential Revision: D12837226 fbshipit-source-id: 0ea3782ce2f49c7f3a91425880863e3b3ea37712
Configuration menu - View commit details
-
Copy full SHA for 98685e8 - Browse repository at this point
Copy the full SHA 98685e8View commit details -
Fabric: Explicit clearing std::vector after moving from it
Summary: Apparently, the standard does not guarantee that the vector is empty after moving from it. So, let's clear it explicitly instead of asserting the emptiness. Reviewed By: sahrens Differential Revision: D12837227 fbshipit-source-id: 85dff6848707f4204f4c79be173064547e83c63e
Configuration menu - View commit details
-
Copy full SHA for 3110a67 - Browse repository at this point
Copy the full SHA 3110a67View commit details -
Fabric: Making jsi::Runtime a part of EventBeat and EventPipe
Summary: We double down on JSI in Fabric. So, practically, JSI is now a hard dependency for Fabric. I hope it's for good. Now `jsi::Runtime` is coupled with scheduling via `EventExecuter`, so we have to make `jsi::Runtime` a part of `EventBeat` to proxy runtime reference to bindgings. Reviewed By: sahrens Differential Revision: D12837225 fbshipit-source-id: 98edc33d6a3358e6c2905f2f03ce0004a9ca0503
Configuration menu - View commit details
-
Copy full SHA for df4521e - Browse repository at this point
Copy the full SHA df4521eView commit details -
Fabric: Removing deprecated leftovers from RCTScheduler and RCTSurfac…
…ePresenter Summary: Trivial. We don't use it anymore. Reviewed By: mdvacca Differential Revision: D12876743 fbshipit-source-id: dc979aaea1fef443b8caf2e58d44b0c7aad90246
Configuration menu - View commit details
-
Copy full SHA for e88db99 - Browse repository at this point
Copy the full SHA e88db99View commit details -
Fabric: Some helper classes and functions were moved to uimanager/pri…
…mitives Summary: Trivial. Reviewed By: mdvacca Differential Revision: D12876747 fbshipit-source-id: a2e72ecb69ffc3787f0d8b432f06b9c9715ac5b1
Configuration menu - View commit details
-
Copy full SHA for ee50618 - Browse repository at this point
Copy the full SHA ee50618View commit details -
Fabric: Introduced ComponentDescriptorRegistry::at() method family
Summary: This is more usable (because it allows to use `->` operator) and safe (const-style) methods replacing old `operator[]` methods. Reviewed By: mdvacca Differential Revision: D12876744 fbshipit-source-id: 8ea7398c9777f8be3e88db873ec00915d0761615
Configuration menu - View commit details
-
Copy full SHA for 6c5b8c6 - Browse repository at this point
Copy the full SHA 6c5b8c6View commit details -
Fabric: A bunch of functions for converting JSI primitives to Fabric …
…and vice-versa Summary: We need to decouple this from actual JSI/UIManagerBinding implementation to make them more maintainable. Reviewed By: sahrens Differential Revision: D12876742 fbshipit-source-id: 30cad69d0a9761e2aa82f31d180e4b5a40cedb61
Configuration menu - View commit details
-
Copy full SHA for b9f9f32 - Browse repository at this point
Copy the full SHA b9f9f32View commit details -
Fabric: Introducing UIManagerBinding, a replacement for JSIFabricUIMa…
…nager Summary: This diff changes how we expose UIManager to JavaScript realm and control ownership of it. This change should improve reliability and a thread-safety. UIManagerBinding is a HostObject which consolidate ownership of UIManager. Now JavaScript's GC controls its lifetime which eliminates the possibility of calling some JS facing methods of UIManager using a dangling pointer. Besides that, all API now imply that if the caller has a reference to jsi::Runtime, it calls the method on the proper thread (it's an implication of RuntimeExecutor design). Reviewed By: sahrens Differential Revision: D12876745 fbshipit-source-id: eb8c70317460df5b14e45031ad15fc6c8e5b5ce3
Configuration menu - View commit details
-
Copy full SHA for 18d8c48 - Browse repository at this point
Copy the full SHA 18d8c48View commit details -
Fabric: Making some picky compilers happy
Summary: Trivial nits. Reviewed By: mdvacca Differential Revision: D12897927 fbshipit-source-id: 61cec4a070218606d52f05740aacbfae1d2efd31
Configuration menu - View commit details
-
Copy full SHA for 786df48 - Browse repository at this point
Copy the full SHA 786df48View commit details -
TouchEventEmitter: Fix assignment of Y coordinates (#22160)
Summary: This patch fixes the the assignment of Y coordinate information in the event payloads in `TouchEventEmitter`, which were inadvertently being assigned X coordinate data. Pull Request resolved: #22160 Differential Revision: D12943125 Pulled By: shergin fbshipit-source-id: a3fde64c4d6c76784f1a0ac7cae4c0d62f3d4497
Configuration menu - View commit details
-
Copy full SHA for 6b6a27c - Browse repository at this point
Copy the full SHA 6b6a27cView commit details -
Summary: Improve types for BackHandler Reviewed By: benjaffe Differential Revision: D9838175 fbshipit-source-id: 839a5a695b468974aadb7bc0da1a23ef844fdd7f
Configuration menu - View commit details
-
Copy full SHA for 7dd2b0b - Browse repository at this point
Copy the full SHA 7dd2b0bView commit details -
Fix inline styles in ReactAndroid (#22166)
Summary: Fix `react-native/no-inline-styles` eslint warning for ReactAndroid module. Pull Request resolved: #22166 Differential Revision: D12946925 Pulled By: TheSavior fbshipit-source-id: f4bc0653bd2971e551bc46d89455c006003947c7
Configuration menu - View commit details
-
Copy full SHA for 8b46c9a - Browse repository at this point
Copy the full SHA 8b46c9aView commit details -
Fix inline styles in IntegrationTests (#22165)
Summary: Fix `react-native/no-inline-styles` eslint warning for IntegrationTests module. Pull Request resolved: #22165 Differential Revision: D12946915 Pulled By: TheSavior fbshipit-source-id: 438bb74cc34dd5893f725e4865568715ce949c3a
Configuration menu - View commit details
-
Copy full SHA for 1d62e94 - Browse repository at this point
Copy the full SHA 1d62e94View commit details -
Summary: Related to #22100 Turn on Flow strict mode for Slider. Enhanced event type and props callbacks type defs for Slider. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [Slider.js] - Flow strict mode Pull Request resolved: #22127 Differential Revision: D12946817 Pulled By: TheSavior fbshipit-source-id: 631391f70c04fddf0bfa6fec92f5cb769a555547
Configuration menu - View commit details
-
Copy full SHA for c03fc40 - Browse repository at this point
Copy the full SHA c03fc40View commit details -
Flow strict TouchableOpacity (#22146)
Summary: Related to #22100 Enhance Flow types for TouchableOpacity specifying Touchable event types and TvParallaxPropertiesType. I had to export TvParallaxPropertiesType from TVViewPropTypes file. There are still 1 any left using requireNativeComponent and a dependency to `Touchable` that need to be addressed to turn Flow to strict mode. I guess `Touchable` is a lot more work since there's no flow annotation and it's still good old Mixin. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [TouchableOpacity.js] - Flow types [GENERAL] [ENHANCEMENT] [TVViewPropTypes.js] - Export type Pull Request resolved: #22146 Reviewed By: TheSavior Differential Revision: D12927044 Pulled By: RSNara fbshipit-source-id: c63d805699dd58e2fbc4fd1df4ee0c9f87e2336a
Configuration menu - View commit details
-
Copy full SHA for 69213ee - Browse repository at this point
Copy the full SHA 69213eeView commit details -
Fix inline styles warning in Libraries (#22161)
Summary: Fixes `react-native/no-inline-styles` eslint warnings in the `Libraries` module. Pull Request resolved: #22161 Differential Revision: D12946899 Pulled By: TheSavior fbshipit-source-id: c97ffa50dd90529dabf30a3d2cb09476acc568cb
Configuration menu - View commit details
-
Copy full SHA for 41eb2da - Browse repository at this point
Copy the full SHA 41eb2daView commit details -
Allow overriding Metro server host with a system prop
Summary: Allow a device to override the host to which to connect to for getting dev bundles, debugging etc. This is read from a system prop so it can be shared across all React Native apps and persists between app installs. Reviewed By: mdvacca Differential Revision: D10842213 fbshipit-source-id: d15b7d0255130090744d60ffb239778cba15e49c
Configuration menu - View commit details
-
Copy full SHA for e02a154 - Browse repository at this point
Copy the full SHA e02a154View commit details
Commits on Nov 7, 2018
-
iOS: Attempt to load lazy modules when asked from native
Summary: Previously, asking for an instance of NativeModule from the native side gave `nil` if the lazy modules have not been loaded, which is not consistent with the access from JS. This at least attempts to force load the lazy modules when asked from native. p.s. one asks for a module by doing `[bridge moduleForClass:[FooBar class]]`. Reviewed By: spredolac Differential Revision: D12931640 fbshipit-source-id: 15d2dc574067d3386ef921512ce4bc837749dabd
Configuration menu - View commit details
-
Copy full SHA for 1f394fa - Browse repository at this point
Copy the full SHA 1f394faView commit details -
Fix build error caused by -Werror=class-memaccess (#823)
Summary: OS: Arch Linux GCC Version: gcc (GCC) 8.2.1 20180831 Clang Version: 6.0.1 (tags/RELEASE_601/final) Build Log Before Fix: command: `buck build //:yoga` ``` Not using buckd because watchman isn't installed. yoga/Yoga.cpp: In function ‘void YGZeroOutLayoutRecursivly(YGNodeRef)’: yoga/Yoga.cpp:1854:51: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct YGLayout’; use assignment or value-initialization instead [-Werror=class-memaccess] memset(&(node->getLayout()), 0, sizeof(YGLayout)); ^ In file included from yoga/YGNode.h:11, from yoga/Utils.h:9, from yoga/Yoga.cpp:13: yoga/YGLayout.h:12:8: note: ‘struct YGLayout’ declared here struct YGLayout { ^~~~~~~~ cc1plus: all warnings being treated as errors Build failed: Command failed with exit code 1. stderr: yoga/Yoga.cpp: In function ‘void YGZeroOutLayoutRecursivly(YGNodeRef)’: yoga/Yoga.cpp:1854:51: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct YGLayout’; use assignment or value-initialization instead [-Werror=class-memaccess] memset(&(node->getLayout()), 0, sizeof(YGLayout)); ^ In file included from yoga/YGNode.h:11, from yoga/Utils.h:9, from yoga/Yoga.cpp:13: yoga/YGLayout.h:12:8: note: ‘struct YGLayout’ declared here struct YGLayout { ^~~~~~~~ cc1plus: all warnings being treated as errors When running <c++ preprocess_and_compile>. When building rule //:yoga#compile-Yoga.cpp.o9b5477b5,default. Parsing buck files: finished in 0.8 sec (100%) Building: finished in 2.2 sec (100%) 10/10 jobs, 1 updated Total time: 3.3 sec ``` Build Log After Fix command: `buck build //:yoga` ``` Not using buckd because watchman isn't installed. Parsing buck files: finished in 0.8 sec (100%) Building: finished in 0.6 sec (100%) 1/1 jobs, 0 updated Total time: 1.6 sec ``` All tests are passing Pull Request resolved: facebook/yoga#823 Reviewed By: davidaurelio Differential Revision: D10486023 Pulled By: passy fbshipit-source-id: e9de734c3ce6c45ea4a8edd5d78206901d85ca84
Configuration menu - View commit details
-
Copy full SHA for 31439f8 - Browse repository at this point
Copy the full SHA 31439f8View commit details -
Add Yoga JNI bindings to libcoldstart
Summary: Yoga's JNI bindings are usually loaded during class loading, and can stall the UI thread. Here, we try to mitigate the problem by adding the bindings to libcoldstart. Reviewed By: michalgr Differential Revision: D12956818 fbshipit-source-id: 9dda5cb6d26c2bae64606bc2d7c98ab8f7c05a30
Configuration menu - View commit details
-
Copy full SHA for 2a8f6c3 - Browse repository at this point
Copy the full SHA 2a8f6c3View commit details -
console polyfill: pass unsupported messages to original console
Summary: Some console methods (like `groupCollapsed` or `clear`) are not supported by console.js polyfill and are not passed to the original console objects. Reviewed By: sahrens Differential Revision: D12900996 fbshipit-source-id: 1b2f487028e418ae934f631996eaaf63abdced82
Configuration menu - View commit details
-
Copy full SHA for bccc454 - Browse repository at this point
Copy the full SHA bccc454View commit details
Commits on Nov 8, 2018
-
Fix IllegalArgumentException when dismissing ReactModalHostView
Summary: This diff fixes an IllegalArgumentException when dismissing ReactModalHostView. I wasn't able to reproduce this error because this is likely created by a race condition. Reviewed By: axe-fb Differential Revision: D12916787 fbshipit-source-id: b071ffc4c251f2a613bb1270de005def56818376
Configuration menu - View commit details
-
Copy full SHA for e57ad4e - Browse repository at this point
Copy the full SHA e57ad4eView commit details -
TextInput: Remove PropTypes, NativeMethodsMixin; Convert to ES6 class (…
…#21885) Summary: This pull requests converts `TextInput` to an ES6 class, and in the process removes its usage of `prop-types` and `NativeMethodsMixin`. The code (and some relevant types) for the native components have been moved to `TextInputNativeComponent.js`. The rest of the flow proptypes have been moved to `TextInputTypes.js`. Pull Request resolved: #21885 Reviewed By: RSNara Differential Revision: D10515754 Pulled By: TheSavior fbshipit-source-id: 5cfb25344385904b37a49582008c2a4b46db809d
Configuration menu - View commit details
-
Copy full SHA for 70e9e26 - Browse repository at this point
Copy the full SHA 70e9e26View commit details -
Fix internal types on top of TextInput refactor
Summary: Types were moved out of TextInput into TextInputTypes for better re-use. Fixing the internal callsites. This isn't much of a worry externally because these types aren't exposed as part of the public API Reviewed By: RSNara Differential Revision: D10517066 fbshipit-source-id: bade4285eafb3d7ab5ab1e4b0730c22d45925509
Configuration menu - View commit details
-
Copy full SHA for ad7d8f8 - Browse repository at this point
Copy the full SHA ad7d8f8View commit details -
Fixing TextInput related jest tests
Reviewed By: yungsters Differential Revision: D10519823 fbshipit-source-id: 02368b670953a0275fa6495b0c73ef84403598cb
Configuration menu - View commit details
-
Copy full SHA for 7e818ae - Browse repository at this point
Copy the full SHA 7e818aeView commit details -
Reviewed By: yungsters Differential Revision: D12969854 fbshipit-source-id: c2fe2c46e538f8b5e3ea46257aef70d00bf14364
Configuration menu - View commit details
-
Copy full SHA for e6a8dca - Browse repository at this point
Copy the full SHA e6a8dcaView commit details -
React sync for revisions 4773fdf...3ff2c7c
Summary: @public This sync includes the following changes: - **[3ff2c7ccd](facebook/react@3ff2c7ccd)**: Invalid actualDuration+treeBaseDuration for hidden+suspended trees (#14065) //<Brian Vaughn>// - **[5afa1c4ed](facebook/react@5afa1c4ed)**: Tag MemoComponent with PerformedWork effectTag for DevTools Profiler (#14141) //<Brian Vaughn>// - **[e27720d7f](facebook/react@e27720d7f)**: [Synchronous Suspense] Reuse deletions from primary tree (#14133) //<Andrew Clark>// - **[aa1ffe4e7](facebook/react@aa1ffe4e7)**: Show deprecated context object warnings usage in ReactDOM server (#14033) //<Dominic Gannaway>// - **[e3a7b9645](facebook/react@e3a7b9645)**: Make react-debug-tools a private package //<Andrew Clark>// - **[ba1984423](facebook/react@ba1984423)**: Update bundle sizes for 16.6.1 release //<Andrew Clark>// - **[b50e63ef5](facebook/react@b50e63ef5)**: Updating package versions for release 16.6.1 //<Andrew Clark>// - **[8f2c89e96](facebook/react@8f2c89e96)**: Make react-debug-tools a private package //<Andrew Clark>// - **[2aecbcd6f](facebook/react@2aecbcd6f)**: "functional component" -> "function component" (#14123) //<locknono>// - **[b4608dd24](facebook/react@b4608dd24)**: Remove unused simulated flag parameter (#14127) //<Nadav Kaner>// - **[3c69a1881](facebook/react@3c69a1881)**: Recover from errors with a boundary in completion phase (#14104) //<Dan Abramov>// - **[b020fb114](facebook/react@b020fb114)**: Check correct commit phase props in fuzz tester (#14129) //<Andrew Clark>// - **[b67c1a2ee](facebook/react@b67c1a2ee)**: Add DEV-only checks for assumption about instance properties (#14128) //<Dan Abramov>// - **[f777d196e](facebook/react@f777d196e)**: Fix lazy() with defaultProps (#14112) //<Dan Abramov>// - **[e4512991c](facebook/react@e4512991c)**: Fix unhiding in IE11 (#14126) //<Sophie Alpert>// - **[affb2b50c](facebook/react@affb2b50c)**: Enable hooks in www test renderer, too //<Andrew Clark>// - **[0a0f503d5](facebook/react@0a0f503d5)**: Enable hooks in www build (#14116) //<Andrew Clark>// - **[600651e68](facebook/react@600651e68)**: Restore the Hooks dispatcher after using SSR (#14105) //<Dan Abramov>// - **[e9a2ec915](facebook/react@e9a2ec915)**: [suspense] Avoid double commit by re-rendering immediately and reusing primary children (#14083) //<Andrew Clark>// - **[9d47143e8](facebook/react@9d47143e8)**: Implement {,un}hideInstance on RN renderer (#14115) //<Sophie Alpert>// - **[ebdb47d2c](facebook/react@ebdb47d2c)**: DCE hooks code when flag is off (#14111) //<Sophie Alpert>// - **[8b87ebf5b](facebook/react@8b87ebf5b)**: Rename .internal tests that aren't using internals (#14109) //<Sophie Alpert>// - **[da04058a9](facebook/react@da04058a9)**: Use Function.prototype.apply in warningWithoutStack (#14107) //<Sophie Alpert>// - **[fd1256a56](facebook/react@fd1256a56)**: Add Debug Tools Package for Introspection of Hooks (#14085) //<Sebastian Markbåge>// - **[b305c4e03](facebook/react@b305c4e03)**: fix(react-dom): Fix crash during server render (#14103) //<Tiago Nunes>// - **[d34d1c3ba](facebook/react@d34d1c3ba)**: react-reconciler: Update README.md (#13953) //<Marcelo Jorge Vieira>// - **[6c404d82a](facebook/react@6c404d82a)**: Bugfix: Add back early return in setOffsets which was removed between 16.4.2 and 16.5.0. Fails in Edge in some scenarios. (#14095) //<einarq>// - **[8eca0eff8](facebook/react@8eca0eff8)**: chore(tests): don't rely on jest fake timers scheduling real timers (#14003) //<Simen Bekkhus>// - **[293fed899](facebook/react@293fed899)**: Warn for bad useEffect return value (#14069) //<Sophie Alpert>// - **[ae196e84b](facebook/react@ae196e84b)**: Rename inputsAreEqual to areHookInputsEqual & move it to shared (#14036) //<Mateusz Burzyński>// - **[c898020e0](facebook/react@c898020e0)**: Warn for forwardRef(memo(...)) (#14070) //<Sophie Alpert>// - **[bf9fadfcf](facebook/react@bf9fadfcf)**: [Hooks] Remove dispatch callbacks (#14037) //<Andrew Clark>// - **[8c67bbf18](facebook/react@8c67bbf18)**: [scheduler] Deadline object -> shouldYield (#14025) //<Andrew Clark>// - **[e02086bfc](facebook/react@e02086bfc)**: Warn about variable number of dependencies //<Andrew Clark>// - **[b92cdef64](facebook/react@b92cdef64)**: Rename ReactHooks test suite //<Andrew Clark>// - **[6efbbe068](facebook/react@6efbbe068)**: Prettier //<Sophie Alpert>// - **[504576306](facebook/react@504576306)**: Swap order of function member in hook union types //<Andrew Clark>// - **[ddbfe2ed5](facebook/react@ddbfe2ed5)**: Add ESLint rule for React Hooks //<Caleb Meredith>// - **[acb489963](facebook/react@acb489963)**: Clear effect tags from a fiber that suspends in non-concurrent mode //<Andrew Clark>// - **[933b64710](facebook/react@933b64710)**: Disable hook update callback (2nd arg to setState/dispatch) //<Andrew Clark>// - **[5fc84efac](facebook/react@5fc84efac)**: Skip updating effect tag when skipping effect //<Sophie Alpert>// - **[9f34eb79a](facebook/react@9f34eb79a)**: Add readContext to ReactPartialRendererHooks //<Alex Taylor>// - **[f7cb9d2b2](facebook/react@f7cb9d2b2)**: Warn about useContext(Consumer|Provider) //<Dan Abramov>// - **[63cc7d2b3](facebook/react@63cc7d2b3)**: Test useContext in pure, forwardRef, and PureComponent //<Dan Abramov>// - **[3a7c6da8d](facebook/react@3a7c6da8d)**: Make effects actually work with memo //<Sophie Alpert>// - **[75a1c2e72](facebook/react@75a1c2e72)**: The Lost Effect, chapter 3 //<Sophie Alpert>// - **[55a4b1f37](facebook/react@55a4b1f37)**: memo supports Hooks //<Sophie Alpert>// - **[30aa4ad55](facebook/react@30aa4ad55)**: The Lost Effect, chapter 2 //<Sophie Alpert>// - **[b772e0e26](facebook/react@b772e0e26)**: "functional component" -> "function component" in hooks error messages //<Sebastian Markbåge>// - **[9e9e3970e](facebook/react@9e9e3970e)**: Warn for Hook set-state on unmounted component //<Sophie Alpert>// - **[6514697f0](facebook/react@6514697f0)**: Make sure deletions don't stop passive effects //<Sophie Alpert>// - **[dd019d34d](facebook/react@dd019d34d)**: Add support for hooks to ReactDOMServer //<Alex Taylor>// - **[11d0781ee](facebook/react@11d0781ee)**: Defer useEffect until after paint //<Andrew Clark>// - **[105f2de54](facebook/react@105f2de54)**: Put hooks behind feature flag //<Andrew Clark>// - **[7bee9fbdd](facebook/react@7bee9fbdd)**: Initial hooks implementation //<Andrew Clark>// - **[37c7fe0a5](facebook/react@37c7fe0a5)**: Update createRoot warning message based on `enableStableConcurrentModeAPIs` (#14017) //<Rauno Freiberg>// - **[95f98a187](facebook/react@95f98a187)**: fix typo (#13955) //<Joseph>// - **[e217f2f1a](facebook/react@e217f2f1a)**: Updated comment for getEventModifierState (#13918) //<Patrick>// - **[275e76e83](facebook/react@275e76e83)**: Enable stable concurrent APIs flag for 16.7 alpha (#13928) //<Brian Vaughn>// - **[8b97a9c36](facebook/react@8b97a9c36)**: Update bundle sizes for 16.6.0 release //<Dan Abramov>// - **[6c29eabf7](facebook/react@6c29eabf7)**: Updating package versions for release 16.6.0 //<Dan Abramov>// - **[d520b358d](facebook/react@d520b358d)**: Revert all package versions to 16.5.2 state //<Dan Abramov>// - **[8f1ec7649](facebook/react@8f1ec7649)**: Bump versions to beta.0 //<Dan Abramov>// - **[5055a83fa](facebook/react@5055a83fa)**: Revert "Revert "Updating dependencies for react-noop-renderer"" //<Dan Abramov>// - **[3e8b4a5b8](facebook/react@3e8b4a5b8)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[d8e03de4a](facebook/react@d8e03de4a)**: [react-cache] Remove `cache` as argument to `read` (#13865) //<Andrew Clark>// - **[fefa1269e](facebook/react@fefa1269e)**: Revert accidentally committed existence check (#13931) //<Andrew Clark>// - **[80a0c05ce](facebook/react@80a0c05ce)**: Removed react-cache from the bundle list for now (#13930) //<BrianVaughn>// - **[915e4eab5](facebook/react@915e4eab5)**: Add "unstable_" prefix to react-cache and jest-react (#13929) //<Brian Vaughn>// - **[cbbc2b6c4](facebook/react@cbbc2b6c4)**: [Synchronous Suspense] Suspending a class outside concurrent mode (#13926) //<Andrew Clark>// - **[4947fcd76](facebook/react@4947fcd76)**: Fix lint (#13923) //<Sebastian Markbåge>// - **[d75c69e0c](facebook/react@d75c69e0c)**: Remove unstable_ prefix from Suspense (#13922) //<Sebastian Markbåge>// - **[c8ef2feda](facebook/react@c8ef2feda)**: Remove redundant word "the" (#13919) //<John Lin>// - **[55444a6f4](facebook/react@55444a6f4)**: Try rendering again if a timed out tree receives an update (#13921) //<Andrew Clark>// - **[04c4f2fce](facebook/react@04c4f2fce)**: [reconciler] ReactFiberNewContext import maxSigned31BitInt twice (#13857) //<yongningfu>// - **[409e472fc](facebook/react@409e472fc)**: Add flow types in ReactControlledComponent (#13669) //<Abdul Rauf>// - **[663835a43](facebook/react@663835a43)**: Add flow types in getEventModifierState (#13909) //<Abdul Rauf>// - **[82710097f](facebook/react@82710097f)**: Add flow types in getNodeForCharacterOffset (#13908) //<Abdul Rauf>// - **[b753f76a7](facebook/react@b753f76a7)**: Fix failing async tests in Node 10 //<Andrew Clark>// - **[b5c0852fd](facebook/react@b5c0852fd)**: Bump version to 16.6.0-beta.0 (#13906) //<Dan Abramov>// - **[769b1f270](facebook/react@769b1f270)**: pure -> memo (#13905) //<Dan Abramov>// - **[8ecd4bd4f](facebook/react@8ecd4bd4f)**: Add support for React.pure in ReactDOMServer (#13855) //<Alex Taylor>// - **[15b11d23f](facebook/react@15b11d23f)**: Allow arbitrary types to be wrapped in pure (#13903) //<Sebastian Markbåge>// - **[e770af7a3](facebook/react@e770af7a3)**: Add back accidentally deleted `break` to prevent fallthrough //<Andrew Clark>// - **[95a313ec0](facebook/react@95a313ec0)**: Unfork Lazy Component Branches (#13902) //<Sebastian Markbåge>// - **[e16cdd5b1](facebook/react@e16cdd5b1)**: Always bail out timed out children even if they receive an update (#13901) //<Andrew Clark>// - **[7268d97d2](facebook/react@7268d97d2)**: Centralize props memoization (#13900) //<Sebastian Markbåge>// - **[0fc044679](facebook/react@0fc044679)**: Class component can suspend without losing state outside concurrent mode (#13899) //<Andrew Clark>// - **[36db53822](facebook/react@36db53822)**: Bugfix for #13886 (#13896) //<Andrew Clark>// - **[6938dcaac](facebook/react@6938dcaac)**: SSR support for class contextType (#13889) //<Sebastian Markbåge>// - **[fa65c58e1](facebook/react@fa65c58e1)**: Add readContext to SSR (#13888) //<Sebastian Markbåge>// - **[d9a3cc070](facebook/react@d9a3cc070)**: React.lazy constructor must return result of a dynamic import (#13886) //<Andrew Clark>// - **[d9659e499](facebook/react@d9659e499)**: Lazy components must use React.lazy (#13885) //<Andrew Clark>// - **[0648ca618](facebook/react@0648ca618)**: Revert "React.pure automatically forwards ref" (#13887) //<Sophie Alpert>// - **[4dd772ac1](facebook/react@4dd772ac1)**: Prettier :( //<Andrew Clark>// - **[98bab66c3](facebook/react@98bab66c3)**: Fix lint //<Andrew Clark>// - **[8ced545e3](facebook/react@8ced545e3)**: Suspense component does not capture if `fallback` is not defined (#13879) //<Andrew Clark>// - **[b738ced47](facebook/react@b738ced47)**: Remove render prop option from Suspense (#13880) //<Andrew Clark>// - **[55b827942](facebook/react@55b827942)**: Strict mode and default mode should have same Suspense semantics (#13882) //<Andrew Clark>// - **[dac9202a9](facebook/react@dac9202a9)**: Hide timed-out children instead of deleting them so their state ispreserved (#13823) //<Andrew Clark>// - **[4f0bd4590](facebook/react@4f0bd4590)**: Replacement of old links, by the new ones of the documentation. (#13871) //<Pablo Javier D. A>// - **[7685b55d2](facebook/react@7685b55d2)**: Remove unstable_read() in favor of direct dispatcher call (#13861)//<Dan Abramov>// - **[21a79a1d9](facebook/react@21a79a1d9)**: [schedule] Call ensureHostCallbackIsScheduled without args (#13852) //<Trivikram Kamat>// - **[9ea4bc6ed](facebook/react@9ea4bc6ed)**: Fix false positive context warning when using an old React (#13850) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions 4773fdf...3ff2c7c Reviewed By: sebmarkbage Differential Revision: D12955345 fbshipit-source-id: db12076758fe85a519074ca4fe3aa5ede6f4fd49
Configuration menu - View commit details
-
Copy full SHA for 0cb59b5 - Browse repository at this point
Copy the full SHA 0cb59b5View commit details -
Fix args passed when measuring Androidwitch
Summary: The first argument to `View.MeasureSpec.makeMeasureSpec` should be positive, but was being passed WRAP_CONTENT, which is negative. This diff fixes that. Reviewed By: achen1 Differential Revision: D6601683 fbshipit-source-id: 6d8499830f7b6da40848bab77d5ddbbb8a6fe44f
Configuration menu - View commit details
-
Copy full SHA for 54e8d6c - Browse repository at this point
Copy the full SHA 54e8d6cView commit details -
Enable unused-private-field warning (#13450)
Summary: Pull Request resolved: pytorch/pytorch#13450 Pull Request resolved: #22065 This diff enables -Wunused-private-field clang warning for Android builds and fixes all broken targets. Reviewed By: gkmhub Differential Revision: D12881793 fbshipit-source-id: 515555661e137be9e7b20eac9b5bdcb549d6a094
Configuration menu - View commit details
-
Copy full SHA for 50e9b0f - Browse repository at this point
Copy the full SHA 50e9b0fView commit details -
Summary: Updating lockfile to fix open source sanity test. Reviewed By: hramos Differential Revision: D12982917 fbshipit-source-id: 1e2f0abadf6e76b67215b70b8c71dea1c2c05bff
Configuration menu - View commit details
-
Copy full SHA for 8d5d144 - Browse repository at this point
Copy the full SHA 8d5d144View commit details -
Replace String with constants for Module names in Fb4aCoreInfraPackage
Summary: Using constants is safer than using strings. More details at D12843649 Reviewed By: sahrens Differential Revision: D8226521 fbshipit-source-id: 4c78c8dfe0bd658f46c8f81e50ceae9299fc6f3c
Configuration menu - View commit details
-
Copy full SHA for fe49809 - Browse repository at this point
Copy the full SHA fe49809View commit details -
Give eagerly loaded modules precedent over lazily loaded one.
Summary: Before lazily-loading code existed, modules that were already loaded into memory took precedent over modules that were additionally registered. With lazily loading modules, instead of giving eagerly loaded modules precdence, it throws a redbox. This diff fixes that behavior. Reviewed By: PeteTheHeat Differential Revision: D12983805 fbshipit-source-id: fe4fcf35d5c2ca6f9f4e3f0d1d8c2ca35468fb1b
Configuration menu - View commit details
-
Copy full SHA for 81b74ec - Browse repository at this point
Copy the full SHA 81b74ecView commit details
Commits on Nov 9, 2018
-
Stop mounting of Views when there is an exception in Native
Summary: This diff fixes exception handling for Mounting of views, as soon as there is an exception we stop the mounting of views because from that point the UI View tree is going to be inconsistent with the ReactShadow tree from C++. We also stop the mounting of views when the host is paused, this allows us to not keep mounting views Reviewed By: shergin Differential Revision: D10510334 fbshipit-source-id: b0d3eba580ff92d8b8400244ec9d7c266db42ff9
Configuration menu - View commit details
-
Copy full SHA for 8329c10 - Browse repository at this point
Copy the full SHA 8329c10View commit details -
Temporary disable AndroidSwipeRefreshLayout
Summary: AndroidSwipeRefreshLayout is rendered in the "Marketplace Your Items" screen altough it is disabled. This diff just temporary implements the AndroidSwipeRefreshLayout component as a View (similar to the iOS counterpart RefreshControl). Reviewed By: shergin Differential Revision: D10524049 fbshipit-source-id: 5df38fbdf1339b3857138d82a7100ec7f15854b3
Configuration menu - View commit details
-
Copy full SHA for cd5009f - Browse repository at this point
Copy the full SHA cd5009fView commit details -
Force navigation to use root tag
Summary: This diff ensures that JS uses rootTags during navigation. A redbox will be rendered in debug mode when a non-rootTag is used during navigation. This change enables proper navigation for Fabric. Reviewed By: shergin Differential Revision: D10855198 fbshipit-source-id: a82aaa706cd62ce92143fa86d0a422c1ae439a50
Configuration menu - View commit details
-
Copy full SHA for fe7eb61 - Browse repository at this point
Copy the full SHA fe7eb61View commit details -
Add systrace support in Fabric C++
Summary: This diff adds systrace support in the C++ side of Fabric Reviewed By: ejanzer Differential Revision: D12861373 fbshipit-source-id: 0291f3e406f239bbef3686ac0bba6e9f1c7eac57
Configuration menu - View commit details
-
Copy full SHA for 7b04f6a - Browse repository at this point
Copy the full SHA 7b04f6aView commit details -
Refactor 'induce' of events in Fabric Android
Summary: This diff refactors the exeuction of 'AsyncEventBeat.induce()' as part of the delivery of events of Fabric Android implementation. The first part of the refactor moves the exeuction of onBatchEventDispatched out of the synchronization block for mEventsToDispatchLock. This lock is accessed from the UI Thread and executing the induce inside this synchronization block will affect UI, The second part of the refactor is to ensure that the exeuction of the C++ method AsyncEventBeat.induce() always happen in the JS Thread. Reviewed By: shergin Differential Revision: D12861387 fbshipit-source-id: e1cd03467274a1c5fcd04b0ac7efdbe7169b14c3
Configuration menu - View commit details
-
Copy full SHA for 95b21b4 - Browse repository at this point
Copy the full SHA 95b21b4View commit details -
Expose rootTag / surfaceId as part of schedulerDidRequestPreliminaryV…
…iewAllocation method Summary: This diff exposes rootTag as part of SchedulerDelegate.schedulerDidRequestPreliminaryViewAllocation(). This will be necessary to be able to pool views per Surface in Android Reviewed By: shergin Differential Revision: D12875656 fbshipit-source-id: d2a8c1f9bcc6b14c17b34bf59085da44ae3c3416
Configuration menu - View commit details
-
Copy full SHA for 2b01da0 - Browse repository at this point
Copy the full SHA 2b01da0View commit details -
Switch to synchronous strategy for unprotect
Summary: Older versions of JSC (ios 11 and before) have a bug which I believe the ProtectionQueue mechanism tickles: https://bugs.webkit.org/show_bug.cgi?id=186827 This removes the ProtectionQueue and replaces it with an atomic flag to avoid calling unprotect after VM shutdown. This also fixes a race condition in shutdown. Reviewed By: danzimm Differential Revision: D12969953 fbshipit-source-id: fa3a14f3207be67a987ac3cf0fc1c9ce88837b0b
Configuration menu - View commit details
-
Copy full SHA for bf2500e - Browse repository at this point
Copy the full SHA bf2500eView commit details -
Fix inline styles eslint warnings for examples (#22123)
Summary: Fixes `react-native/no-inline-styles` warning for several examples. I'm limiting the size of this PR to make it simpler to review. Pull Request resolved: #22123 Reviewed By: RSNara Differential Revision: D12929701 Pulled By: TheSavior fbshipit-source-id: 7a976f2208b557fcfda46d5b586b30652c550eb2
Configuration menu - View commit details
-
Copy full SHA for 7b3c91e - Browse repository at this point
Copy the full SHA 7b3c91eView commit details -
Back out TextInput es6 conversion
Summary: This was failing due to issues with refs, which we were able to fix and then finally due to some jest tests that were failing due to things being null that shouldn't be which I couldn't easily figure out. Reverting the stack until we can actually solve it, hopefully with additional tests. This was created by running: ``` $ hg backout c2fe2c46e538 fetching tree '' b9bbfc1925c6daf85ba3227d12f177aca9c0c054, based on 4257c76aefa84aaa17279e65aa7ca1174f4401e7, found via 02368b670953 connected to hg015.frc2.facebook.com 60 trees fetched over 2.91s fetching tree '' c3c304df13399f0f1a29a668242da454fc1d8a97, based on b9bbfc1925c6daf85ba3227d12f177aca9c0c054, found via c2fe2c46e538 7 trees fetched over 0.03s 1 files updated, 0 files merged, 0 files removed, 0 files unresolved commit 4270328:50a65c5c2e27 backs out commit 4266783:c2fe2c46e538 1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over 0.57s [[email protected] /data/sandcastle/boxes/instance-ide/xplat/js (50a65c5)]$ hg backout 02368b670953 fetching tree '' a46c8ca065f5b92cf375d7ed899fc5ca268ba4da, based on b9bbfc1925c6daf85ba3227d12f177aca9c0c054, found via bade4285eafb connected to hg024.frc2.facebook.com 27 trees fetched over 3.21s fetching tree '' 361548a090e81d18bab6f4fc16036c518cb4d7c1, based on a46c8ca065f5b92cf375d7ed899fc5ca268ba4da, found via bade4285eafb 41 trees fetched over 0.10s merging react-native-github/Libraries/Components/TextInput/TextInput.js 8 files updated, 1 files merged, 0 files removed, 0 files unresolved commit 4270329:dbaca0daf0ac backs out commit 4266782:02368b670953 14 files fetched over 7 fetches - (14 misses, 0.00% hit ratio) over 1.72s [[email protected] /data/sandcastle/boxes/instance-ide/xplat/js (dbaca0d)]$ hg backout bade4285eafb connected to hg030.frc2.facebook.com fetching tree '' 1b4a17164fdbfcad40139e46da4a9bfa8aa8def3, based on 361548a090e81d18bab6f4fc16036c518cb4d7c1, found via 5cfb25344385 7 trees fetched over 0.06s merging react-native-github/Libraries/Components/TextInput/TextInput.js 20 files updated, 1 files merged, 0 files removed, 0 files unresolved commit 4270330:2951740e5b32 backs out commit 4266781:bade4285eafb 33 files fetched over 14 fetches - (33 misses, 0.00% hit ratio) over 4.50s [[email protected] /data/sandcastle/boxes/instance-ide/xplat/js (2951740)]$ hg backout 5cfb25344385 connected to hg035.frc2.facebook.com merging react-native-github/Libraries/Components/TextInput/TextInput.js 0 files updated, 1 files merged, 2 files removed, 0 files unresolved commit 4270331:fffb4629a397 backs out commit 4266780:5cfb25344385 1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over 4.03s ``` Reviewed By: yungsters Differential Revision: D12989604 fbshipit-source-id: 703a7c9c1f5bdd710077e515bdff06fdb34502ec
Configuration menu - View commit details
-
Copy full SHA for f386f83 - Browse repository at this point
Copy the full SHA f386f83View commit details -
Removing UIManager.measureViewsInRect()
Summary: It does not supported on Android and nobody uses it. I could find only one use cases: Very old versin of `SectionList` library (4 years ago). Reviewed By: sahrens Differential Revision: D12972361 fbshipit-source-id: a5dfef5e877e996adec2d4941417b4a2e727cfb7
Configuration menu - View commit details
-
Copy full SHA for d623679 - Browse repository at this point
Copy the full SHA d623679View commit details -
Turn off static linking for cxxreact:bridge
Summary: Remove `force_static=true` from cxxreact:bridge, add dependencies to targets that were pulling them in from a statically linked cxxreact:bridge. Reviewed By: mhorowitz Differential Revision: D12914861 fbshipit-source-id: ff335b70e80d014538a8d5dc8c0bb7b095e7940e
Configuration menu - View commit details
-
Copy full SHA for 918a7d5 - Browse repository at this point
Copy the full SHA 918a7d5View commit details -
Adds support for
publicPath
to enable serving assets from different…… locations. (#299) Summary: <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. --> **Summary** <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> This is an updated followup from facebook/metro#280, which we would still need to address the following assumptions about `/assets/`: https://github.com/facebook/metro/blob/e7deea19001d903a47868bb1fe6456bdc4b585e7/packages/metro/src/Server.js#L332 https://github.com/facebook/metro/blob/e7deea19001d903a47868bb1fe6456bdc4b585e7/packages/metro/src/Server.js#L379 https://github.com/facebook/metro/blob/e7deea19001d903a47868bb1fe6456bdc4b585e7/packages/metro/src/Server.js#L385 As pointed out by gdborton, there isn't currently a way to make this a configurable option. I am not certain how to find a proper workaround for `processRequest`. We found a temporary solution to have our express app pick up serving the assets from a publicPath as a middleware. But the change in this PR is still necessary to get it working fully. **Test plan** <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. --> - Will add tests once we figure out a comprehensive solution Pull Request resolved: facebook/metro#299 Reviewed By: rafeca Differential Revision: D12939229 Pulled By: mjesun fbshipit-source-id: 769c23468c5ac434f8319e5e7caaf46dd6453f2d
Configuration menu - View commit details
-
Copy full SHA for 0b31496 - Browse repository at this point
Copy the full SHA 0b31496View commit details -
Summary: ShimmeringView is called: RTShimmeringView Android and ShimmeringView in iOS. This diff adds a mapping into ComponentDescriptorRegistry to temporary enable ShimmeringView component until we can unify names in JS. Reviewed By: sahrens Differential Revision: D12991351 fbshipit-source-id: 48e08b8021116221ccfd5f2512c76f65145baa2a
Configuration menu - View commit details
-
Copy full SHA for 28278e1 - Browse repository at this point
Copy the full SHA 28278e1View commit details -
Use static constants instead of strings when referring to View Manage…
…rs and Native Modules Summary: Using strings to refer to Native Modules and View Managers in ReactPackages are prone to error. The compiler replaces the constants with the actual strings anyway, so using constants gives us better type safety Reviewed By: achen1 Differential Revision: D12843649 fbshipit-source-id: 7a7c6c854c8689193f40df92dc8426a3b37f82c8
Configuration menu - View commit details
-
Copy full SHA for 803e993 - Browse repository at this point
Copy the full SHA 803e993View commit details -
Fabric: Making EventEmitter::setEnabled additive
Summary: In the previous approach, when event emitter got disabled for split second, we could lose the EventTarget because JS GC can collect it before we re-enable this. Now we "over-enable" this first, and "under-disable" later. Reviewed By: mdvacca Differential Revision: D12990112 fbshipit-source-id: 4e3c0c0e05f03509ec72ca570f59ce16597353f0
Configuration menu - View commit details
-
Copy full SHA for d2408dd - Browse repository at this point
Copy the full SHA d2408ddView commit details -
Add copyright header into ContextUtils class
Summary: Trivial diff to include copyright header into ContextUtils class Reviewed By: achen1 Differential Revision: D13001556 fbshipit-source-id: 439f25647a094485381637ea2b59f62962b9c1ac
Configuration menu - View commit details
-
Copy full SHA for fba7c1e - Browse repository at this point
Copy the full SHA fba7c1eView commit details -
Add another guard to lazilyLoadView
Summary: it's possible that moduleForName won't return anything, so we should return. Created from Diffusion's 'Open in Editor' feature. Reviewed By: spredolac Differential Revision: D12963342 fbshipit-source-id: c059595a68bfcaa38221e05fb62d70cc29887ca7
Configuration menu - View commit details
-
Copy full SHA for d7865eb - Browse repository at this point
Copy the full SHA d7865ebView commit details -
iOS: ignore double registration of lazy modules with chrome attached
Summary: Depending on when Chrome debugger is attached, modules may get double registered. Simply ignore it for this case. The redbox was not a fatal error, which can be dismissed. Reviewed By: shergin Differential Revision: D12996107 fbshipit-source-id: 292f63102337077848842ca46b3daed08b1cae12
Configuration menu - View commit details
-
Copy full SHA for 80f92ad - Browse repository at this point
Copy the full SHA 80f92adView commit details -
Fix ReactInstanceManager deadlock
Summary: D12829677 introduced a deadlock where onHostResume holds the lock on `moveToResumedLifecycleState()` then waits for the `mReactContext` lock, but at the same time setupReactContext holds the `mReactContext` lock and waits for `moveToResumedLifecycleState()` https://our.intern.facebook.com/intern/everpaste/?handle=GAgXFgLQH1ZlQikBAMQzo2LZ6h9TbiAxAAAz. The purpose of the previous diff was to make sure that detachRootoView and setupReactContext did not interfere with each other, and implemented that by blocking on mReactContext. Since this overloads the usage of mReactContext, let's use a different lock `mAttachedRootViews` to implement this behavior instead Reviewed By: mdvacca Differential Revision: D12989555 fbshipit-source-id: c12e5fd9c5fa4c2037167e9400dc0c1578e38959
Configuration menu - View commit details
-
Copy full SHA for df7e8c6 - Browse repository at this point
Copy the full SHA df7e8c6View commit details -
Use nativeQPLTimestamp for InitializeCore marker point
Summary: It seems like `nativePerformanceNow` might not be getting installed in time to be used by InitializeCore on Android. Using PerformanceLogger.currentTimestamp instead, which uses nativeQPLTimestamp (which is what we should be using anyway) Reviewed By: alexeylang Differential Revision: D12875187 fbshipit-source-id: 6eda5d2ed7948ba48c63f76b40b2014511c32494
Configuration menu - View commit details
-
Copy full SHA for 1850906 - Browse repository at this point
Copy the full SHA 1850906View commit details -
Add a marker to indicate when JS thread priority is lowered
Summary: When RN starts up, it lowers the default priority of the JS thread. This diff sets a point to see when the JS thread priority is lowered. In subsequent diffs, we will be able to use this marker to play around with bumping the priority of the JS thread till TTI is done. Reviewed By: alexeylang Differential Revision: D8965457 fbshipit-source-id: 87cb1e3d3b370af183f388c411fd9a87a6cba250
Configuration menu - View commit details
-
Copy full SHA for d4aef08 - Browse repository at this point
Copy the full SHA d4aef08View commit details
Commits on Nov 10, 2018
-
Fix ReactRootView attachRootView race condition
Summary: Yet another issue with mAttachedRootViews. Every time attachRootView is called, the root view's id is reset to NO_ID. However, there can be a case where the react context has not initialized yet, so we delay attaching the root view to the instance manager until setupReactContext. If attachRootView was called a second time before the react context has finished initializing, we end up in a situation where we try to attach the same root view twice I'm planning to remove mAttachedRootViews all together in a future diff, but for now let's avoid these crashes. Reviewed By: mmmulani Differential Revision: D12835167 fbshipit-source-id: ebef3fadc5f9f467eebb3b5644c685acc5ea10bf
Configuration menu - View commit details
-
Copy full SHA for be282b5 - Browse repository at this point
Copy the full SHA be282b5View commit details -
Only include ServerHost constant in debug builds
Summary: I recently changed the implementation of `getServerHost` to be more expensive. I am excluding it from constants in non-debug builds, since loading that module lies on a critical path. Reviewed By: axe-fb Differential Revision: D12982150 fbshipit-source-id: eaaa50418726dbb2da2d517d0810f39b0dc7fac2
Configuration menu - View commit details
-
Copy full SHA for 2bf0d54 - Browse repository at this point
Copy the full SHA 2bf0d54View commit details -
Reset module registry flag when resetting React Instance
Summary: D12911108 fixed a UBN race condition by adding a flag for module registry. This flag was never reset if react instance gets reset, causing an assert to fire in IG. Reviewed By: fkgozali Differential Revision: D13010651 fbshipit-source-id: e20453f3c546d759a58fd7fb93553f774410905f
Configuration menu - View commit details
-
Copy full SHA for 188cbb0 - Browse repository at this point
Copy the full SHA 188cbb0View commit details -
Moved androidID constant to a method
Summary: androidID was a constant that was exposed as a Platform constant, but it seems to use slightly expensive methods when they need to be computed. Moving this to a method so that it is computed only when needed. Test Plan Reviewed By: ejanzer Differential Revision: D6563853 fbshipit-source-id: 3c5929fcbc947c13c3a25f2bf473e145ac4bf73e
Configuration menu - View commit details
-
Copy full SHA for 9f9390d - Browse repository at this point
Copy the full SHA 9f9390dView commit details -
Fabric: Codemod: All
<fabric/...
includes were renamed to<react/...
Summary: We are moving to more stable APIs removing all mentiones of the effort name from the codebase. Reviewed By: mdvacca Differential Revision: D12912894 fbshipit-source-id: 4a0c6b9e7454b8b14e62d419e9e9311dc0c56e7a
Configuration menu - View commit details
-
Copy full SHA for 94d49e5 - Browse repository at this point
Copy the full SHA 94d49e5View commit details
Commits on Nov 11, 2018
-
Avoid pre-allocating views for non-layoutable shadow nodes
Summary: This diff changes the behavior of the Scheduler.schedulerDidRequestPreliminaryViewAllocation to avoid pre-allocating views that are non-layoutables Reviewed By: shergin Differential Revision: D12962008 fbshipit-source-id: cb2670beafdcbd2116fbdaf2dc5d1b4726330ec2
Configuration menu - View commit details
-
Copy full SHA for 33b9661 - Browse repository at this point
Copy the full SHA 33b9661View commit details
Commits on Nov 12, 2018
-
UITemplateProcessor: Fix case of include path (#22239)
Summary: This pull request fixes a path name to be a proper case in `UITemplateProcessor`, which fixes this build warning: ``` {snip}/react/uimanager/UITemplateProcessor.cpp:17:10: warning: non-portable path to file '<react/core/ComponentDescriptor.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <react/core/ComponentDescriptor.h> 1 warning generated. ``` Pull Request resolved: #22239 Differential Revision: D13020871 Pulled By: shergin fbshipit-source-id: 77555018cd569880518ff884ed8768effc4ea97e
Configuration menu - View commit details
-
Copy full SHA for 0436bfc - Browse repository at this point
Copy the full SHA 0436bfcView commit details -
DeltaPatcher: better support for the new Delta format
Summary: Adds support for the `deleted` key to remove modules from the bundle. Without this, source maps would break after removing a module, since it would still end up in the patched bundle but not in the source map. Reviewed By: mjesun Differential Revision: D12874011 fbshipit-source-id: 79239756854cb2c02f14ec8b0bb2b649766393fe
Configuration menu - View commit details
-
Copy full SHA for bea57d8 - Browse repository at this point
Copy the full SHA bea57d8View commit details -
Summary: GraphNotFoundError: When the user moves the app to the background on Android, restarts the Metro server and reopens the app, since the client hasn't requested either a delta or a bundle, the graph cache of the server is empty and thus we can't compute an update for the client (what if changes happened when the metro server was down?). RevisionNotFoundError: I didn't manage to reproduce that one. It could happen if two clients live side-by-side, requesting the exact same bundle. In the future, if we want to handle that case, we'll need to manage a list of clients listening to a single graph so that we don't try to update the same graph multiple times for a single file change. Disconnection: Same as GraphNotFoundError, but happens when the user moves the app to the background on iOS. Reviewed By: mjesun Differential Revision: D12960939 fbshipit-source-id: 5ac1dc7fd12bad5e0ee8dfa5a21c112773454ee5
Configuration menu - View commit details
-
Copy full SHA for c787866 - Browse repository at this point
Copy the full SHA c787866View commit details -
NetInfo: try to solve crash with releasing _firstTimeReachability
Summary: @public We're seeing a crash on line 191 when we do `CFRelease(self->_firstTimeReachability);`. My thinking is that there's a race condition between the deallocation coming from calling `getCurrentConnectivity` twice in a row and the callback coming back. Reviewed By: PeteTheHeat Differential Revision: D12982772 fbshipit-source-id: d3d882a074b67a5e547e7f480f561fcaf8d79ec4
Configuration menu - View commit details
-
Copy full SHA for eebc8e2 - Browse repository at this point
Copy the full SHA eebc8e2View commit details -
Summary: galavant-fistbump Reviewed By: jeanlauliac Differential Revision: D13027247 fbshipit-source-id: 3635527b6c745111b26d9f61666c30e696b04526
Configuration menu - View commit details
-
Copy full SHA for de60e86 - Browse repository at this point
Copy the full SHA de60e86View commit details
Commits on Nov 14, 2018
-
Update React Native OSS Yarn and Gradle caches
Summary: Update the yarn lockfile. Add `metro/src/DeltaBundler/Serializers/plainJSBundle` definition to OSS Flow config. Reviewed By: fkgozali, axe-fb Differential Revision: D13046780 fbshipit-source-id: f7f68edacc6a4ed61c9e7b269e49148f915249cb
Configuration menu - View commit details
-
Copy full SHA for 11d4512 - Browse repository at this point
Copy the full SHA 11d4512View commit details -
Allow CxxModules to implement methods with two callbacks (#21586)
Summary: When writing a native module in C++ using CxxModule, its not currently possible to write async methods which take two callbacks, that shouldn't be projected to JS as a promise. I hit this when trying to implement the AppState module in c++. AppState has a single method on it, getCurrentAppState, which takes two callbacks (a success and a failure callback). This change adds a couple of new CxxModule::Method ctors, which allow devs to specify that they want two callbacks, but not a promise. This is done using an extra tag in the ctor, similar to how you specify that you want to make a synchronous method. I used the existing AsyncTag to indicate that the 2 callback version should be async, and not a promise. Pull Request resolved: #21586 Reviewed By: shergin Differential Revision: D10520204 Pulled By: fkgozali fbshipit-source-id: bcb2dbd91cba3c1db987dc18960247218fdbc032
Configuration menu - View commit details
-
Copy full SHA for 8826d8b - Browse repository at this point
Copy the full SHA 8826d8bView commit details -
iOS: add moduleForNameForcedLoad: to lookup modules by name and force…
… load them Summary: Some module classes may not be loaded yet, so looking up via classes may not always give the correct instance. This diff added a new lookup method that delegate to the bridge delegate to force load the modules as needed. The existing moduleForName: method was left untouched because it's solely used by RCTUIManager at the moment. Reviewed By: dshahidehpour Differential Revision: D13033876 fbshipit-source-id: 4082fcd68498004f678b4b95adc82b5b134fefdf
Configuration menu - View commit details
-
Copy full SHA for d7a0c44 - Browse repository at this point
Copy the full SHA d7a0c44View commit details -
Guard Platform.isTesting under __DEV__
Summary: Testing is a __DEV__ time only, so let's optimize for prod bundles. Reviewed By: ejanzer Differential Revision: D13050583 fbshipit-source-id: a96e35e4d5f3bd09c235c11d4ece3e4d07882de7
Configuration menu - View commit details
-
Copy full SHA for 339d9d3 - Browse repository at this point
Copy the full SHA 339d9d3View commit details -
Android: Close websocket properly when remote server initiates close (#…
Configuration menu - View commit details
-
Copy full SHA for 2e465bc - Browse repository at this point
Copy the full SHA 2e465bcView commit details -
Fix regression in StyleSheet.setStyleAttributePreprocessor (#22262)
Summary: This regression was caused by 199c918 - property values are initialized to true rather than a string that matches the property name now. Pull Request resolved: #22262 Differential Revision: D13048839 Pulled By: hramos fbshipit-source-id: 09471334c37f3930aae7e35066943f33f8e617e5
Configuration menu - View commit details
-
Copy full SHA for 0408533 - Browse repository at this point
Copy the full SHA 0408533View commit details -
Configuration menu - View commit details
-
Copy full SHA for a508134 - Browse repository at this point
Copy the full SHA a508134View commit details -
added functionality using which child node can tell parent node to us…
…e it as a reference baseline Summary: @public Currently only parent can tell the layout to align its children based on baseline. But if one of the children is a column or row then basealign does not work as expected. We have added an api setReferenceBaseline which when set to true would mean that it's baseline would be considered as the reference baseline for parent amongst its siblings. If there are more than one siblings with referenceBaseline set, the first one would be considered. Reviewed By: davidaurelio Differential Revision: D12883323 fbshipit-source-id: 19beccfc47d98bb38f81f5b66ba764e83680f821
Configuration menu - View commit details
-
Copy full SHA for 6eb5bd3 - Browse repository at this point
Copy the full SHA 6eb5bd3View commit details -
Dispatch events asynchronously
Summary: This diff fixes the dispaching of Async Events in Android C++ layer to ensure proper asynchronouns dispatching in the JS thread. Reviewed By: shergin Differential Revision: D12988348 fbshipit-source-id: 7aa60b11e2c264c2e68354ed83eb75139060d211
Configuration menu - View commit details
-
Copy full SHA for e02a24b - Browse repository at this point
Copy the full SHA e02a24bView commit details -
iOS TM: Rename RCTJSINativeModule => RCTTurboModule
Summary: Simple codemod to rename RCTJSINativeModule => RCTTurboModule (the protocol) for less confusion. Reviewed By: PeteTheHeat Differential Revision: D13054206 fbshipit-source-id: 4829dc69838c623336475ea8ee11be815d79711c
Configuration menu - View commit details
-
Copy full SHA for 39b8fa9 - Browse repository at this point
Copy the full SHA 39b8fa9View commit details -
Remove unused loads from xplat.
Summary: Unused loads still take time to process and pollute execution environment. drop-conflicts Reviewed By: passy Differential Revision: D13054018 fbshipit-source-id: a8fe58d1c55c031925c2c0267e24e67f021cd91d
Configuration menu - View commit details
-
Copy full SHA for 9b781bd - Browse repository at this point
Copy the full SHA 9b781bdView commit details -
Fix crash when releasing RN views
Summary: There are cases where we're trying to drop a view that is not associated with a ViewManager. This is likely caused by race conditions that can occur if we're dropping a view from JS (when it's no longer used) but at the same time dropping it from native (when layout animation ends, when the rootview gets unmounted). In either of those cases, it should be safe to ignore the drop operation because the view was likely dropped already. Reviewed By: mdvacca Differential Revision: D13036643 fbshipit-source-id: 260ffb56d32a0d670ad08f449b8df165b2533195
Configuration menu - View commit details
-
Copy full SHA for 83405ff - Browse repository at this point
Copy the full SHA 83405ffView commit details -
nullptr -> folly::none in fbobjc/xplat
Summary: In preparation for D12843022, starting using folly::none instead of nullptr to indicate an empty optional. Reviewed By: nlutsenko Differential Revision: D13052075 fbshipit-source-id: ed869f98b5fb1556bca1e01e3ac3e44ea914dc52
Configuration menu - View commit details
-
Copy full SHA for 56a416e - Browse repository at this point
Copy the full SHA 56a416eView commit details -
Fix crash when removing root nodes
Summary: If a root node is being removed and has an id of NO_ID, it was likely already removed previously, likely due to a race condition caused by RN's async nature. In those cases, let's avoid crashing the app and instead silently ignore the root view removal. Reviewed By: mdvacca Differential Revision: D13055140 fbshipit-source-id: ec10f4c79f2ba21614f52f57557f6b3d734c9461
Configuration menu - View commit details
-
Copy full SHA for b649fa9 - Browse repository at this point
Copy the full SHA b649fa9View commit details -
Upgrade jest to v24.0.0-alpha.6
Summary: yayyay Reviewed By: mjesun Differential Revision: D13027838 fbshipit-source-id: ce51a82fa4c6dfa62e202e52c2733d161ae52883
Configuration menu - View commit details
-
Copy full SHA for 06c13b3 - Browse repository at this point
Copy the full SHA 06c13b3View commit details
Commits on Nov 15, 2018
-
Remove dynamic exception specification in RN MethodCall.h/cpp
Summary: Dynamic exception specifications are removed in C++17. Reviewed By: mhorowitz Differential Revision: D13078933 fbshipit-source-id: b1a1d7aed3f634c6bc699ab05a8c218bdddf5993
Configuration menu - View commit details
-
Copy full SHA for 5b71408 - Browse repository at this point
Copy the full SHA 5b71408View commit details -
Flow v0.86.0 in xplat/js [3/n]
Summary: allow-large-files bypass-lint ignore-conflict-markers ignore-signed-source ignore-nocommit drop-conflicts Reviewed By: avikchaudhuri Differential Revision: D12994045 fbshipit-source-id: 04552bf081ba742de58e80fba08f8280cb86b1c3
Configuration menu - View commit details
-
Copy full SHA for 43ad3a6 - Browse repository at this point
Copy the full SHA 43ad3a6View commit details -
Revert D12994045: Flow v0.86.0 in xplat/js [3/n]
Differential Revision: D12994045 Original commit changeset: 04552bf081ba fbshipit-source-id: 062b367b88a966a6efc895c99e9911f0ec0fe8ff
Configuration menu - View commit details
-
Copy full SHA for 984eef8 - Browse repository at this point
Copy the full SHA 984eef8View commit details -
Workaround a wrong fling direction for inverted ScrollViews on Androi…
…d P (#21117) Summary: This is a safe workaround to an issue in Android P: https://issuetracker.google.com/issues/112385925 It is based on a fact that even though `fling` receive a wrong sign in `velocityY`, `mOnScrollDispatchHelper.getYFlingVelocity()` still returns a fling direction. Fixes #19434 Pull Request resolved: #21117 Differential Revision: D13082740 Pulled By: hramos fbshipit-source-id: 1b28586d2c7bdcae4a111d3cead4a0455cebb99a
Configuration menu - View commit details
-
Copy full SHA for b971c5b - Browse repository at this point
Copy the full SHA b971c5bView commit details -
Back to yearless format for MIT license
Summary: @public Restores the yearless format of the MIT license. Reviewed By: SidharthGuglani Differential Revision: D13082510 fbshipit-source-id: f5a849b06652cedf68547d4a7963398b2627915f
Configuration menu - View commit details
-
Copy full SHA for 619de16 - Browse repository at this point
Copy the full SHA 619de16View commit details -
Fix React Native AsyncMode and DevTools
Summary: Fixes two problems I uncovered with React Native: 1. `FBCore/Prelude` points to `React.unstable_AsyncMode` which is not defined. (This type was renamed to `React.unstable_ConcurrentMode` in React v16.6.0. **As a result** people in the "react_native:async_rendering" GK will no longer get runtime errors on app start. 2. Updates `react-devtools` and (more importantly) `react-devtools-core` to 3.4.2 to handle the React-internal tag/type refactoring that happened prior to the release of 16.6.0. **As a result** DevTools will no longer cause a runtime error when connected to React Native. For the second change, I ran `js1 upgrade react-devtools -v ^3.4.2` Reviewed By: sebmarkbage Differential Revision: D13030590 fbshipit-source-id: 603f7f6259f282839039820bcdba4310064a7965
Configuration menu - View commit details
-
Copy full SHA for aacb06c - Browse repository at this point
Copy the full SHA aacb06cView commit details -
Fix compatibility issue for android 16 device.Fixes #22294 (#22295)
Summary: Fix compatibility issue for android 16 device. Related issue #22295. pass all current ci. none [GENERAL] [ANDROID] [Fixed] - Fix compatibility issue for android 16 device Pull Request resolved: #22295 Differential Revision: D13084152 Pulled By: hramos fbshipit-source-id: 42459ddc6f84f870affdda5ba19bcd8bb27b56d7
Configuration menu - View commit details
-
Copy full SHA for 5939d07 - Browse repository at this point
Copy the full SHA 5939d07View commit details -
JS: Switch from
new Buffer
toBuffer.from
Summary: Constructing `Buffer` using the constructor [[https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/ | has been deprecated in Node 10 due to security considerations]]. This is a simple and straightforward conversion. Reviewed By: mjesun Differential Revision: D13080655 fbshipit-source-id: 100d8f28c3b255422b26e820aaadcc4f32f41e0d
Configuration menu - View commit details
-
Copy full SHA for d9c2cda - Browse repository at this point
Copy the full SHA d9c2cdaView commit details
Commits on Nov 16, 2018
-
Changed front-facing camera so that it shows consistent image during …
…capture and preview Summary: Changed front-facing camera so that it shows consistent image during capture and preview Reviewed By: mmmulani Differential Revision: D13012715 fbshipit-source-id: 043cd9178fc49ef9e8e628a866dd8e52434f7306
Configuration menu - View commit details
-
Copy full SHA for 4aeea4d - Browse repository at this point
Copy the full SHA 4aeea4dView commit details -
Defining explicit clang-format for Objective-C part of React Native
Summary: Now, Objective-C part of RN is in `xplat` directory, so global Objective-C clang-format does not affect that. Explicit clang-format is also useful for external contributors who don't have access to the rest of monorepo. The actual rules are copy-paste from ReactCommon folder with small changes (like 120 characters max line length) that conform to regular Facebook code style and which make sense only for Objective-C. Reviewed By: fkgozali Differential Revision: D13093150 fbshipit-source-id: 79d64b4fba6eeb94e9b8d87ef9c3f86b3a5ed94e
Configuration menu - View commit details
-
Copy full SHA for 271ace9 - Browse repository at this point
Copy the full SHA 271ace9View commit details -
resizeMode applies to Image.defaultSource (#22216)
Summary: resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource. Changelog: ---------- [Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading. Pull Request resolved: #22216 Differential Revision: D13088220 Pulled By: mdvacca fbshipit-source-id: 92c66cf6228f3b7666b9ef2404d034f0005b5234
Configuration menu - View commit details
-
Copy full SHA for 673ef39 - Browse repository at this point
Copy the full SHA 673ef39View commit details -
New TextInput-test that would have prevented S168585
Summary: Adds a basic test that would have prevented S168585. We should expand coverage of this and other components as well. Reviewed By: TheSavior Differential Revision: D13038064 fbshipit-source-id: 14cf4742efd53d7bca2a3f8d1c5c34ebc6227674
Configuration menu - View commit details
-
Copy full SHA for a009406 - Browse repository at this point
Copy the full SHA a009406View commit details -
reapply TextInput es6 conversion with fixes, attemps to fix
Summary: D10515754 reapplied by backing out D12989604 and then fixed by manually forwarding the instance methods to the host function instead of using `forwardRef`. This also removes the need for the $flowFixMe. Reviewed By: TheSavior Differential Revision: D13048482 fbshipit-source-id: ff2447aff123e0960eddaef645f7dc976a426e14
Configuration menu - View commit details
-
Copy full SHA for 9ea1295 - Browse repository at this point
Copy the full SHA 9ea1295View commit details -
CxxReact: Silence 'unused lambda capture' warnings in open-source (#2…
…2240) Summary: This pull request silences build warnings like this in open-source: ``` {snip}/ReactCommon/cxxreact/CxxNativeModule.cpp:134:85: warning: lambda capture 'callId' is not used [-Wunused-lambda-capture] messageQueueThread_->runOnQueue([method, params=std::move(params), first, second, callId] () { ``` These are variables used by "fbsystrace", which is not open-sourced. An unused statement has been added to the affected files in the `#else` for the `#ifdef WITH_FBSYSTRACE` conditionals Pull Request resolved: #22240 Differential Revision: D13031358 Pulled By: shergin fbshipit-source-id: 8ccfc226b65e32abda6abb573f77a6589bd19dcd
Configuration menu - View commit details
-
Copy full SHA for 0c05409 - Browse repository at this point
Copy the full SHA 0c05409View commit details -
Summary: allow-large-files bypass-lint ignore-conflict-markers ignore-signed-source ignore-nocommit drop-conflicts Reviewed By: yungsters Differential Revision: D13081129 fbshipit-source-id: fbb0ccaf3c0a2f224a56f6f6ac6c26811ebba583
Configuration menu - View commit details
-
Copy full SHA for 8fb228f - Browse repository at this point
Copy the full SHA 8fb228fView commit details -
Add bounce method to TouchableBounce
Summary: Adds a `bounce` method that just bounces the element without invoking any callbacks. Differential Revision: D13085800 fbshipit-source-id: 310b273b260c924fbde32bfad1de7226d068bd57
Configuration menu - View commit details
-
Copy full SHA for 383ea99 - Browse repository at this point
Copy the full SHA 383ea99View commit details -
Back out "reapply TextInput es6 conversion with fixes, attemps to fix"
Summary: Back it out again. This time really not sure why this is breaking, but it seems to be production only. The error seems to be "RCTSinglelineTextInputView" was not found in the UIManager" but the relavent logic is not changed in this diff, just moved around, so unclear why it would trigger a failure. Reverting to be safe. When we re-apply the diff, we'll need to test a full OTA to prod to verify the fix. Reviewed By: blairvanderhoof Differential Revision: D13108463 fbshipit-source-id: 5f877a0c1a08dc114ce45921d6d92bf619575977
Configuration menu - View commit details
-
Copy full SHA for 6f34bc4 - Browse repository at this point
Copy the full SHA 6f34bc4View commit details
Commits on Nov 17, 2018
-
Add test for WritableNativeMap
Summary: A simple test for WritableNativeMap. Also includes a test to verify that the key name exists in the error message if a dynamic cast exception occurs (this will be implemented in the future) Reviewed By: mdvacca Differential Revision: D12914375 fbshipit-source-id: 654674b1b32e7b3f38cc1364a2302d1ce08ec33e
Configuration menu - View commit details
-
Copy full SHA for 17ced57 - Browse repository at this point
Copy the full SHA 17ced57View commit details -
create api to allow clients to present a client credential for authen…
…tication (#22316) Summary: Pull Request resolved: #22316 Pull Request resolved: #22315 In order for TLS Mutual Auth to work for webviews, the caller must present a credential. Expose a setter that can be called to set a credential. Reviewed By: RSNara Differential Revision: D13095969 fbshipit-source-id: d136556a0030f799651d574b6e47ce38295b108e
Configuration menu - View commit details
-
Copy full SHA for 8911353 - Browse repository at this point
Copy the full SHA 8911353View commit details -
Fabric: Fixed bug in RCTSurfaceTouchHandler::PointerHasher
Summary: Without this fix the PointerHasher hashed not a pointer, but an address where the pointer is stored, which is obviously incorrect. The incorrect hash function compromised the whole `_activeTouches` caused many issues with logically invalid invariants (e.g. removing element from the collection silently didn't work). Reviewed By: mdvacca Differential Revision: D13072804 fbshipit-source-id: d68289e940fe21e2df08a31439619b7e2fe0fa13
Configuration menu - View commit details
-
Copy full SHA for 1de79e1 - Browse repository at this point
Copy the full SHA 1de79e1View commit details -
Fabric: Using non-mutating
at
instead of[]
for `-[RCTSurfaceTouc……hHandler _activeTouches]` Summary: Every C++ engineer (except me several months ago) knows that `operator []` can mutate the collection (Yeah! Don't ask), so this is especially dangerous if your hash function is broken (see the previous diff). Reviewed By: mdvacca Differential Revision: D13072805 fbshipit-source-id: 4436a8ff12fb27a57bfb6ee0ff986d7a9a825549
Configuration menu - View commit details
-
Copy full SHA for 868406d - Browse repository at this point
Copy the full SHA 868406dView commit details -
Fabric: Proper implementation
-[RCTSurfaceTouchHandler reset]
Summary: Apparently, if a gesture recognizer got 'reset', OS does not call `touchesCancelled:` method, so we have to do it manually. To implement this we have to split `_dispatchTouches:eventType:` into two methods: the first converts Objective-C touches to C++ touches, the second consumes that. We have to do this because during reset we don't have a collection of UIKit touches. Reviewed By: mdvacca Differential Revision: D13072807 fbshipit-source-id: 677e2febf9f96dcdfaadfadf5b9ab3893f93e796
Configuration menu - View commit details
-
Copy full SHA for 560652c - Browse repository at this point
Copy the full SHA 560652cView commit details -
Cleanup old Fabric methods from ReactShadowNodeImpl
Summary: These methods and variables were used by Android implementation of Fabric, these are not used anymore. Reviewed By: shergin Differential Revision: D13108547 fbshipit-source-id: d169eb58ba20f3bfe117a124f0494ff3a4fb5dce
Configuration menu - View commit details
-
Copy full SHA for 74f6575 - Browse repository at this point
Copy the full SHA 74f6575View commit details -
Fix scrolling with multiple fingers in RN Fabric scrollView
Summary: Scrolling with multiple fingers produced a redbox in Fabric Reviewed By: shergin Differential Revision: D13108544 fbshipit-source-id: 7b70b3f55f325448191adc48c782f2014b502ad6
Configuration menu - View commit details
-
Copy full SHA for d3a7325 - Browse repository at this point
Copy the full SHA d3a7325View commit details -
Change font size default from 12 to 14
Summary: trivial change of the default font size from 12 to 14 to make it backward compatible with current version of RN Reviewed By: shergin Differential Revision: D13108543 fbshipit-source-id: e5e384c4459f2c87ee9589c4e00a0ab5d0c8a06a
Configuration menu - View commit details
-
Copy full SHA for dcf72ff - Browse repository at this point
Copy the full SHA dcf72ffView commit details -
NIT remove unnecessary cast in measure
Summary: Trivial clean up of unnecessary cast in measure methods Reviewed By: shergin Differential Revision: D13108542 fbshipit-source-id: 93661f2f5322a790f2d578e6897b89cd1e205c3d
Configuration menu - View commit details
-
Copy full SHA for 2dbe769 - Browse repository at this point
Copy the full SHA 2dbe769View commit details -
Implement layout constraint when measuring text
Summary: This diff adds support for layout constraint when measuring text Reviewed By: shergin Differential Revision: D13111434 fbshipit-source-id: 0c8689e9ac8ce2281b03386f275d2a8e034f88d8
Configuration menu - View commit details
-
Copy full SHA for 8367fa9 - Browse repository at this point
Copy the full SHA 8367fa9View commit details -
Fix padding for Text Views in Fabric
Summary: This diff extends Text View to support not only paddingLeft, paddingRight, etc but also padding props. Reviewed By: shergin Differential Revision: D13111433 fbshipit-source-id: 3b0efe8468f20a5ffaf31e3f1f180e96a5409865
Configuration menu - View commit details
-
Copy full SHA for 7b2030b - Browse repository at this point
Copy the full SHA 7b2030bView commit details -
DrawerLayoutAndroid: Convert to ES6 class (#21980)
Summary: This pull requests converts `DrawerLayoutAndroid` from a `createReactClass`-based component to an ES6 class component, removing its use of `NativeMethodsMixin` and `prop-types` in the process. Unfortunately this couldn't be moved over to a full `forwardRef` to the native component, because it has the methods `openDrawer` and `closeDrawer` as part of its API, and they can't be called directly on the native component. A `createRef`-based ref to the native component can be accessed from the `nativeRef` property of a `DrawerLayoutAndroid` instance if a native ref is needed. The Flow types for callbacks have also been filled out. Pull Request resolved: #21980 Reviewed By: TheSavior Differential Revision: D12901951 Pulled By: RSNara fbshipit-source-id: d35fa5f11b1059f49b466b52abeec902db1d22f7
Configuration menu - View commit details
-
Copy full SHA for bea3bb6 - Browse repository at this point
Copy the full SHA bea3bb6View commit details -
Surface: Using screen size as a default maximum size of Fabric Surface
Summary: That's a temporary change that useful only while we don't have deeper/proper intergration with UIKit's navigation infra. Reviewed By: mdvacca Differential Revision: D13104172 fbshipit-source-id: 024e71e04470d56d2c5e9b3f6c3392555ce50b63
Configuration menu - View commit details
-
Copy full SHA for 346c9d5 - Browse repository at this point
Copy the full SHA 346c9d5View commit details
Commits on Nov 18, 2018
-
Rename requiresMainThreadSetup -> requiresMainQueueSetup in code comm…
…ent (#22328) Summary: Update reference to property in code comment in `RCTBridgeModule`. There is no such thing as `requiresMainThreadSetup` in the codebase. Its called `requiresMainQueueSetup` now. Pull Request resolved: #22328 Differential Revision: D13115352 Pulled By: shergin fbshipit-source-id: 511d627388b51029821c4b1ddf4caac30e573040
Configuration menu - View commit details
-
Copy full SHA for 1fa56a0 - Browse repository at this point
Copy the full SHA 1fa56a0View commit details
Commits on Nov 20, 2018
-
Replace global.alert use to fix eslint warnings (#22184)
Summary: Replaces `alert` with `Alert.alert` to fix eslint warnings. Pull Request resolved: #22184 Reviewed By: TheSavior Differential Revision: D13105636 Pulled By: RSNara fbshipit-source-id: 82a9e55fd002051e3cf8238e29d37b2b33f66f0e
Configuration menu - View commit details
-
Copy full SHA for 55994f5 - Browse repository at this point
Copy the full SHA 55994f5View commit details -
Remove useless additionnal blur call (#22156)
Summary: I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component. After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur. By removing this line, I fix this unecessary multiple call. Pull Request resolved: #22156 Reviewed By: TheSavior Differential Revision: D13105396 Pulled By: RSNara fbshipit-source-id: 8e83461d8b288d8ee4047bc4a33c4480e193c349
Configuration menu - View commit details
-
Copy full SHA for 27cfba2 - Browse repository at this point
Copy the full SHA 27cfba2View commit details -
iOS: Support inline view truncation (#21456)
Summary: If text is truncated and an inline view appears after the truncation point, the user should not see the inline view. Instead, we have a bug such that the inline view is always visible at the end of the visible text. This commit fixes this by marking the inline view as hidden if it appears after the truncation point. This appears to be a regression. React Native used to have logic similar to what this commit is adding: https://github.com/facebook/react-native/blob/1e2a924ba60001c6f0587c7561536f00b2922cbf/Libraries/Text/RCTShadowText.m#L186-L192 **Before fix** Inline view (blue square) is visible even though it appears after the truncation point: ![image](https://user-images.githubusercontent.com/199935/46382038-d3a71200-c65d-11e8-8179-2ce4aad8d010.png) The full text being rendered was: ``` <Text numberOfLines={1}> Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna <View style={{width: 50, height: 50, backgroundColor: 'steelblue'}} /> </Text> ``` **After fix** Inline view is properly truncated: ![image](https://user-images.githubusercontent.com/199935/46382067-fdf8cf80-c65d-11e8-84ea-e2b71c229dae.png) **Test Plan** Tested that the inline view is hidden if it appears after the truncation point when `numberOfLines` is 1 and 2. Similarly, verified that the inline view is visible if it appears before the truncation point. **Release Notes** [IOS] [BUGFIX] [Text] - Fix case where inline view is visible even though it should have been truncated Adam Comella Microsoft Corp. Pull Request resolved: #21456 Differential Revision: D10182991 Pulled By: shergin fbshipit-source-id: a5bddddb1bb8672b61d4feaa04013a92c8224155
Configuration menu - View commit details
-
Copy full SHA for 70826db - Browse repository at this point
Copy the full SHA 70826dbView commit details -
iOS TM: RCTEnableJSINativeModule => RCTEnableTurboModule
Summary: Leftover name change from previous codemod. Reviewed By: shergin Differential Revision: D13117615 fbshipit-source-id: 2584a2a90d3db6ed9a9e9cb8727c51da34f0927c
Configuration menu - View commit details
-
Copy full SHA for aad83cc - Browse repository at this point
Copy the full SHA aad83ccView commit details
Commits on Nov 21, 2018
-
Flow strict TouchableBounce (#22197)
Summary: Related to #22100 Enhance TouchableBounce with press event types, callback and hitslop types. There is still some work to do in order to turn flow to strict mode. (requireNativeComponent and render function) - All flow tests succeed. [GENERAL] [ENHANCEMENT] [TouchableBounce.js] - Flow types Pull Request resolved: #22197 Reviewed By: TheSavior Differential Revision: D13032452 Pulled By: RSNara fbshipit-source-id: b21140722ce924698aa15323602e2e3fc663dbb6
Configuration menu - View commit details
-
Copy full SHA for 45c5183 - Browse repository at this point
Copy the full SHA 45c5183View commit details -
Flow strict TextProps (#22122)
Summary: Related to #22100 Turn on Flow strict mode for TextProps. I used ResponseHandlers type definition defined in Text.js. I wanted to move ResponseHandlers type to TextProps and reuse it inside the file. I know I could use $Shape<> to maybe keys but how do I elegantly maybe every values ? Unless having a straightforward solution, I found it clearer to copy paste these types. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [TextProps.js] - Flow strict mode Pull Request resolved: #22122 Reviewed By: TheSavior Differential Revision: D13055759 Pulled By: RSNara fbshipit-source-id: 230b43c7c94d7f82f5727ad11541b0cb98bc5e3a
Configuration menu - View commit details
-
Copy full SHA for 7927497 - Browse repository at this point
Copy the full SHA 7927497View commit details -
Flow strict TextInput (#22250)
Summary: Related to #22100 Enhance TextInput with callback event types. This is a first draft and I will need more help on this one. Flow checks are successful now but I am not sure types are accurate though. Moreover I find my separation approach kind of dirty for callback event types. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [TextInput.js] - Flow types [GENERAL] [ENHANCEMENT] [TextInputExample.android.js] - Fixing Flow types [GENERAL] [ENHANCEMENT] [TextInputExample.ios.js] - Fixing Flow types [GENERAL] [ENHANCEMENT] [XHRExampleFetch.js] - Fixing Flow types Pull Request resolved: #22250 Reviewed By: TheSavior Differential Revision: D13104820 Pulled By: RSNara fbshipit-source-id: 3fbb98d0ec2b62be676f71ae1053933d9c78485e
Configuration menu - View commit details
-
Copy full SHA for 35a65cd - Browse repository at this point
Copy the full SHA 35a65cdView commit details -
Summary: Some of the flow types were incomplete. So, I referenced the code in `~/fbsource/xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/views/textinput/` and in `~/fbsource/xplat/js/react-native-github/Libraries/Text/TextInput/` to make the flow types more specific. I also fixed internal breakages. To avoid having to sprinkle `$FlowFixMe`s everywhere, I had to refactor some types, and some code. Reviewed By: TheSavior Differential Revision: D13121871 fbshipit-source-id: 9796aafc861544baf52d7ade823ab1be2d3f12d1
Configuration menu - View commit details
-
Copy full SHA for da0b139 - Browse repository at this point
Copy the full SHA da0b139View commit details -
Fix jsc regression.Fixes #22274 (#22293)
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first #22295. Kudo plz review. ![image](https://user-images.githubusercontent.com/3759816/48561684-758f6f00-e92b-11e8-905b-e394f72349f7.png) Pull Request resolved: #22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
Configuration menu - View commit details
-
Copy full SHA for f22473e - Browse repository at this point
Copy the full SHA f22473eView commit details -
Flow strict TouchableHighlight (#22173)
Summary: Related to #22100 Enhance Flow types for TouchableOpacity specifying underlay functions and TvParallaxPropertiesType. I had to export and enhance TvParallaxPropertiesType from TVViewPropTypes file. This does not break this other PR also using this exported type. #22146 There is still some work to do in order to turn flow to strict mode. - All flow tests succeed. [GENERAL] [ENHANCEMENT] [TouchableHighlight.js] - Flow types [GENERAL] [ENHANCEMENT] [TVViewPropTypes.js] - Export and enhance type Pull Request resolved: #22173 Differential Revision: D13033441 Pulled By: RSNara fbshipit-source-id: 26a38970923dc7e6c02c03da5d08483a3f1fbd36
Configuration menu - View commit details
-
Copy full SHA for a97d104 - Browse repository at this point
Copy the full SHA a97d104View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb4825a - Browse repository at this point
Copy the full SHA fb4825aView commit details -
Flow strict-local in TimePickerAndroid.android.js (#22188)
Summary: Related to #22100 . I had this issue before(#22154 & #22172). Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.js. - [x] npm run prettier - [x] npm run flow - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] npm run lint - [x] npm run test - [x] ./scripts/run-android-local-unit-tests.sh [GENERAL][ENHANCEMENT][TimePickerAndroid.android.js] - apply flow strict-local Pull Request resolved: #22188 Reviewed By: TheSavior Differential Revision: D12972356 Pulled By: RSNara fbshipit-source-id: 838604a791dfdc86bacf8b49f6c399920a3f57bc
Configuration menu - View commit details
-
Copy full SHA for c127000 - Browse repository at this point
Copy the full SHA c127000View commit details -
Flow strict StatusBar (#22282)
Summary: Related to #22100 `Libraries/Components/StatusBar/StatusBar.js` Enhance StatusBar with mergePropsStack and _defaultProps. - [x] npm run prettier - [x] npm run flow - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] npm run lint - [x] npm run test - [x] ./scripts/run-android-local-unit-tests.sh [GENERAL][ENHANCEMENT][StatusBar.js] - apply flow strict-local Pull Request resolved: #22282 Reviewed By: TheSavior Differential Revision: D13103971 Pulled By: RSNara fbshipit-source-id: 27f69c6df3a8a7792fcd595c0ff362943ccab8ca
Configuration menu - View commit details
-
Copy full SHA for 6fa997d - Browse repository at this point
Copy the full SHA 6fa997dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3649a50 - Browse repository at this point
Copy the full SHA 3649a50View commit details
Commits on Nov 22, 2018
-
then to thenValue changes to allow deletion of value-taking continuat…
…ion form of then Summary: Future::then taking a value-taking function is deprecated and being deleted. This cleans up a few more callsites. Reviewed By: yfeldblum, shergin Differential Revision: D13163277 fbshipit-source-id: 98d1f78c5b34ca34603cc24d79157a4718573576
Configuration menu - View commit details
-
Copy full SHA for 1f32b5d - Browse repository at this point
Copy the full SHA 1f32b5dView commit details -
Fabric: ShadowNode::backtrackAncestors(...)
Summary: We have to have a way to backtrack a pointer to a parent node and this is generalized version of that. This is the first naive implementations of the algorithm. We will invest in optimizing this later. Reviewed By: mdvacca Differential Revision: D12920856 fbshipit-source-id: 9facb4e16a0b5608feb6747df3804952025ef093
Configuration menu - View commit details
-
Copy full SHA for 3ecf4ea - Browse repository at this point
Copy the full SHA 3ecf4eaView commit details -
Fabric: LayoutableShadowNode::getRelativeLayoutMetrics()
Summary: The generic method that returns relative (to some specified node) layout metrics. We need this as a building block to implement `UIManager.measure*()` methods family. Reviewed By: mdvacca Differential Revision: D12932549 fbshipit-source-id: 79064551d32b0cd40e72dc87d0ed194e3779ba29
Configuration menu - View commit details
-
Copy full SHA for 9eec2c3 - Browse repository at this point
Copy the full SHA 9eec2c3View commit details -
Fabric: Getting rid of leftovers in Scheduler
Summary: Trivial. Those are not used. Reviewed By: fkgozali Differential Revision: D13017883 fbshipit-source-id: cf285e537eb85c8fca6852f7c03a5ef661b85757
Configuration menu - View commit details
-
Copy full SHA for 71208f0 - Browse repository at this point
Copy the full SHA 71208f0View commit details -
Fabric: Introducing ShadowTreeRegistry
Summary: Why do we need a dedicated registry class? * We need to simplify registry-related logic in Scheduler. * We need to couple threading aspect of the registry with the registry itself, otherwise it's not clear why exactly we acquire the mutex. We also should not acquire the mutex in a per-method way (as we did before), because it's incorrect and misleading (only lines that access the registry should by protected). * We need to have a way to share the registry with other classes (e.g. UIManager) without passing a reference to the whole Scheduler. Reviewed By: mdvacca Differential Revision: D13036550 fbshipit-source-id: 644da910e823666c586834a3da2b4cdcb90eebb2
Configuration menu - View commit details
-
Copy full SHA for b4fa1fa - Browse repository at this point
Copy the full SHA b4fa1faView commit details -
Fabric: Sharing a pointer to ShadowTreeRegister with UIManager
Summary: The diff adds a pointer to ShadowTreeRegistry to UIManager which enables the possibility of implementing ShadowTree mutating and inspecting methods like `setNativeProps` and `getRelativeLayoutMetrics`. Reviewed By: mdvacca Differential Revision: D13036549 fbshipit-source-id: 5ed1252d84c8dd895fe0e6e8cc71afbaa9dab4b7
Configuration menu - View commit details
-
Copy full SHA for f8be867 - Browse repository at this point
Copy the full SHA f8be867View commit details -
Fabric:
UIManager::getRelativeLayoutMetrics
Summary: This method is underlying infra for all `measure`-like methods exposed to JavaScript. Reviewed By: mdvacca Differential Revision: D13036553 fbshipit-source-id: cb5135f1db97ec8144b31a24ee4fb9f5d61f0df1
Configuration menu - View commit details
-
Copy full SHA for 7e57755 - Browse repository at this point
Copy the full SHA 7e57755View commit details -
Fabric:
ParagraphShadowNode::updateLocalDataIfNeeded()
Summary: Now we don't update `LocalData` for `ParagraphShadowNode` if the attributed string hasn't changed. Reviewed By: mdvacca Differential Revision: D13160128 fbshipit-source-id: 6ffe76ad187452fa37ba36a132b885cbcedfd1d3
Configuration menu - View commit details
-
Copy full SHA for 9c96133 - Browse repository at this point
Copy the full SHA 9c96133View commit details -
Fix ReactAndroid build break. (#22377)
Summary: During C++ build, we need the libjsc.so. But arm64-v8a and x86_64 libjsc.so are in different path and this error raised: Android NDK: ERROR:/home/circleci/react-native/ReactAndroid/build/third-party-ndk/jsc/Android.mk:jsc: LOCAL_SRC_FILES points to a missing file /opt/ndk/android-ndk-r17c/build/core/prebuilt-library.mk:45: *** Android NDK: Aborting . Stop. Android NDK: Check that /home/circleci/react-native/ReactAndroid/build/third-party-ndk/jsc/jni/arm64-v8a/libjsc.so exists or that its path is correct The commit moves prebuilt libjsc.so into ReactAndroid/src/main/jni/third-party/jsc/jni and let ndkbuild script find the prebuilt libjsc.so. For AAR packaging, modify the jniLibs so that gradle android library plugin could find the prebuilt libjsc.so as well. Pull Request resolved: #22377 Differential Revision: D13166556 Pulled By: hramos fbshipit-source-id: 61daaede7defbc66491a3e2f20058e7d248ba13e
Configuration menu - View commit details
-
Copy full SHA for 0a293a0 - Browse repository at this point
Copy the full SHA 0a293a0View commit details -
Fix allocating Buffer in early commit (#22379)
Summary: Commit d9c2cda brings compatibility with Node 10, but replaced allocating buffer incorrectly. dulmandakh made two comments and shows how to do it based on NodeJS documentation https://nodejs.org/api/buffer.html#buffer_new_buffer_size This PR just fixes that commit. Pull Request resolved: #22379 Differential Revision: D13166867 Pulled By: hramos fbshipit-source-id: 207528739889c044021a4b97ef94c33d56de3e89
Configuration menu - View commit details
-
Copy full SHA for 02a3517 - Browse repository at this point
Copy the full SHA 02a3517View commit details -
Fabric: Fixed
AttributedString::operator==
Summary: Trivial and shameful erratum. Reviewed By: mdvacca Differential Revision: D13166689 fbshipit-source-id: 75128299502bbc9ff5458c4381e7833aa451dd04
Configuration menu - View commit details
-
Copy full SHA for ecc7012 - Browse repository at this point
Copy the full SHA ecc7012View commit details -
Add getUndefined() method to obtain the undefined value
Summary: Add getUndefined() method to obtain the undefined value. This would allow to obtain the Yoga undefined value in runtime, and not just in compile time Reviewed By: davidaurelio Differential Revision: D13136972 fbshipit-source-id: aa198aa1ea65bb6b7302abeba6f9f5d483a45ff3
Configuration menu - View commit details
-
Copy full SHA for 3337a1d - Browse repository at this point
Copy the full SHA 3337a1dView commit details -
Summary: @public Passes all `float`, `bool`, etc. by value, not by reference. Reviewed By: astreet Differential Revision: D13153500 fbshipit-source-id: 95529bc2efcff144044e2c25087915b2b7ede179
Configuration menu - View commit details
-
Copy full SHA for f8ff6bd - Browse repository at this point
Copy the full SHA f8ff6bdView commit details -
Dealloc JNI implementation experiment
Summary: @public Remove ability to configure Yoga to run with/without JNI fast calls on dalvik / art. This switches to always run with fast calls. Reviewed By: astreet Differential Revision: D13144652 fbshipit-source-id: 091aab0cd1290d46346323d3e26a11dd0bb17187
Configuration menu - View commit details
-
Copy full SHA for 64d162e - Browse repository at this point
Copy the full SHA 64d162eView commit details -
Summary: @public passes all enum values by value, not by reference. Reviewed By: astreet Differential Revision: D13156390 fbshipit-source-id: 56aea66c16ab3325594f67b9017afa18a678d281
Configuration menu - View commit details
-
Copy full SHA for c34ad17 - Browse repository at this point
Copy the full SHA c34ad17View commit details -
YGNodeComputeFlexBasisForChildren
: remove output paramSummary: @public `YGNodeComputeFlexBasisForChildren` was using an output parameter (`float&`) that is always initialised to `0.0f`. Here, we move the initialisation inside `YGNodeComputeFlexBasisForChildren`, and simply return the result. Reviewed By: astreet Differential Revision: D13167509 fbshipit-source-id: cbea20e2deb82ec75a1c158b16c94f4a3e5e4c99
Configuration menu - View commit details
-
Copy full SHA for 8f283b9 - Browse repository at this point
Copy the full SHA 8f283b9View commit details -
Use real flow types from metro
Summary: Stop ignoring `metro` folder from RN and use their flowtypes correctly Reviewed By: hramos Differential Revision: D13085169 fbshipit-source-id: f285223afb7e89ac2c63e53d36be2f3645fa6761
Configuration menu - View commit details
-
Copy full SHA for 98546e9 - Browse repository at this point
Copy the full SHA 98546e9View commit details -
Bump metro version in React Native
Summary: This is the tweak on the release process of metro: after publishing D13075199 and releasing a new version of Metro, this diff upgrades it in RN along with its yarn.lock file. This should allow us to publish new versions of metro without breaking the RN sanity scripts (or disable them). Reviewed By: hramos Differential Revision: D13084224 fbshipit-source-id: 19781ae142db11d7dd8b6ca4303366f7ccb32dcc
Configuration menu - View commit details
-
Copy full SHA for 3355c52 - Browse repository at this point
Copy the full SHA 3355c52View commit details
Commits on Nov 23, 2018
-
- Resolve two gradle deprecation warnings (#22360)
Summary: > Configure project :ReactAndroid > The Task.leftShift(Closure) method has been deprecated. This is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead. > Task :ReactAndroid:buildReactNdkLib > A problem was found with the configuration of task ':ReactAndroid:buildReactNdkLib'. Registering invalid inputs and outputs via TaskInputs and TaskOutputs methods has been deprecated and is scheduled to be removed in Gradle 5.0. > - File '[...]/react-native/ReactAndroid/src/main/jni/react' specified for property '$1' is not a file. Pull Request resolved: #22360 Differential Revision: D13176269 Pulled By: hramos fbshipit-source-id: cf6d498049b955d3920d356f2d68f3bc43008c56
Configuration menu - View commit details
-
Copy full SHA for 4514041 - Browse repository at this point
Copy the full SHA 4514041View commit details -
Back out "[react-native][PR] [flow-strict] Flow strict StatusBar"
Summary: Original commit changeset: 27f69c6df3a8 This reverts D13103971 Differential Revision: D13185679 fbshipit-source-id: 0de9da31bd75786c7978e2c3860486ac37420342
Configuration menu - View commit details
-
Copy full SHA for c3dea89 - Browse repository at this point
Copy the full SHA c3dea89View commit details
Commits on Nov 25, 2018
-
Summary: @public Adds types for a marker API in Yoga. This will allow us to register callbacks that Yoga can use to log performance data without hard-coding the backend system for that. Reviewed By: SidharthGuglani Differential Revision: D13118830 fbshipit-source-id: b42a42c609f0cf66212186f7f20ee572522d59e3
Configuration menu - View commit details
-
Copy full SHA for f2894e5 - Browse repository at this point
Copy the full SHA f2894e5View commit details
Commits on Nov 26, 2018
-
Ensure thread safety in the exeuction of RuntimeExecutor
Summary: This diff ensures thread safety for operations invoked by the runtime executor Reviewed By: shergin Differential Revision: D13136340 fbshipit-source-id: 119092dff29b37f39d4bcdcc34f1c34d638b7e07
Configuration menu - View commit details
-
Copy full SHA for 0357d0d - Browse repository at this point
Copy the full SHA 0357d0dView commit details -
Refactor types used during yoga meassure calls
Summary: This diff refactors the types used when Yoga requires to measure the size of a View in C++ Reviewed By: shergin Differential Revision: D13124086 fbshipit-source-id: 89dfe80bb41b4fb2eaba84af630d52ef2509b1e1
Configuration menu - View commit details
-
Copy full SHA for 10ce6c3 - Browse repository at this point
Copy the full SHA 10ce6c3View commit details -
Add systrace to calculation of Yoga layout() in Fabric
Summary: Simple diff that adds a systrace to start measuring the calculation of Yoga layout() in Fabric Reviewed By: shergin Differential Revision: D13124641 fbshipit-source-id: 6bd03e9f56524221f5d91606ffde50253673c1bb
Configuration menu - View commit details
-
Copy full SHA for 3b4d6d5 - Browse repository at this point
Copy the full SHA 3b4d6d5View commit details -
Expose hash as part of text localdata
Summary: In this diff we expose the text local data hash to android, this will be used in the future to cache metadata when rendering text in android Reviewed By: shergin Differential Revision: D13161873 fbshipit-source-id: cd13a4beba75a3fe62ac9ff3def26f88e874834b
Configuration menu - View commit details
-
Copy full SHA for eec9e4a - Browse repository at this point
Copy the full SHA eec9e4aView commit details -
Summary: This diff fixes re-measures of a text component result of a change of state. For details of the bug see: T36838266 Reviewed By: shergin Differential Revision: D13188601 fbshipit-source-id: ea9a889540f600d4e4e788105d5fa22e6cd5448c
Configuration menu - View commit details
-
Copy full SHA for 5be17c0 - Browse repository at this point
Copy the full SHA 5be17c0View commit details -
Remove max and min font size from serialization of text attribute
Summary: Removing two props that are not currently used They are being set as quiet_NaN in C++ and this brings problems in the Android side Reviewed By: shergin Differential Revision: D13188600 fbshipit-source-id: e8412497a80300cfbc3770b829e9633206aaf427
Configuration menu - View commit details
-
Copy full SHA for 3be2816 - Browse repository at this point
Copy the full SHA 3be2816View commit details -
Add caching of spannable text objects
Summary: This diff adds support to cache the Spannable objects that are created during measure() and updateLocalData() for text Reviewed By: shergin Differential Revision: D13188599 fbshipit-source-id: 6547d8ce2bb8b1dfb3c91e64facff3ba0cd97472
Configuration menu - View commit details
-
Copy full SHA for f341795 - Browse repository at this point
Copy the full SHA f341795View commit details -
Redefine hashcode for AttributedString
Summary: This diff changes the method to calculate the hash of an AttributedString (removing shadowNode and parentShadowNode from it). This is necessary becuase otherwise hashcode of clonned parent keep changing in every state change, when the text doesnt change With this change we are able to cache spannables in android properly Reviewed By: shergin Differential Revision: D13189110 fbshipit-source-id: c1f7372809ce98a5b4d091485cc15281a4ab5e1e
Configuration menu - View commit details
-
Copy full SHA for 89f647d - Browse repository at this point
Copy the full SHA 89f647dView commit details -
Fabric: Introducing
-[RCTComponentViewProtocol componentHandle]
Summary: The new method in the protocol enforces view component classes to expose a component handle of the component that the view component represents. That will allow us to wire up those classes with shadow views in runtime explicitly and in a much more performant way than it is now. Reviewed By: mdvacca Differential Revision: D13114663 fbshipit-source-id: 853187d978aab200f85719d9c1d9fea2e3ad4e55
Configuration menu - View commit details
-
Copy full SHA for eef3df8 - Browse repository at this point
Copy the full SHA eef3df8View commit details -
Introducing RCTComponentViewFactory
Summary: The whole mounting iOS infra now uses `ComponentHandle` instead of `std::string` as a reference to particular `ComponentView` implementation. All changes are pretty straightforward, we use a different thing/type to refer to the particular class; no changes in the logic besides a new `RCTComponentViewFactory` that serves the same role of classes registry as Objective-C runtime served previously. That has several benefits: * It should be slightly faster, mostly because we don't need to convert `char *` strings to `std::string` and then to `NSString *`. * We don't need string-based component-name maps anymore (at least on this layer). We can call classes as we want and it will work because of classes are now explicit about which ShadowNodes they are compatible with. * Most importantly, it's explicit now! That means that no runtime magic is involved anymore and we can rely on static linting tool now and not be afraid of improper code stripping/overoptimization. Reviewed By: mdvacca Differential Revision: D13130760 fbshipit-source-id: aadf70525a1335b96992443abae4da359efdc829
Configuration menu - View commit details
-
Copy full SHA for e581977 - Browse repository at this point
Copy the full SHA e581977View commit details -
Fabric: Stopping creating ShadowView instances for non-View ShadowNodes
Summary: Apparently, the previous behavior brings more problems than some *possible-in-the-future* features and flexibility. The new model allows us to easily implement "nested text" feature. (We temporary hope the old behavious for Android only for compatibility reasons.) Reviewed By: mdvacca Differential Revision: D13176277 fbshipit-source-id: 01f7bfb3c2e70cc89d76ecb78add016ee91cbd63
Configuration menu - View commit details
-
Copy full SHA for cd5f0bd - Browse repository at this point
Copy the full SHA cd5f0bdView commit details -
Fabric: Proper handling of memory pressure event in RCTComponentViewR…
…egistry Summary: View recycling can be pretty aggressive and memory intensive, so we can properly react on system memory-pressure notification. Reviewed By: mdvacca Differential Revision: D13176278 fbshipit-source-id: 38ea1b27da988aeaaa5db6ac0b94389a0bd2799e
Configuration menu - View commit details
-
Copy full SHA for c68e69c - Browse repository at this point
Copy the full SHA c68e69cView commit details -
Fix cookies not being sent after a redirected response (#22178)
Summary: Fixes #19376 On iOS, the `HTTPShouldHandleCookies` boolean has no effect when custom cookies are set (see https://developer.apple.com/documentation/foundation/nsmutableurlrequest/1415485-httpshouldhandlecookies?preferredLanguage=occ). Setting custom cookies prevents the cookies of a redirect response from being re-used in the subsequent request. This is why issue #19376 is opened. The fix is to intercept the redirect request, and to manually set the cookies. This effectively makes the Android and iOS behaviours converge. Changelog: ---------- [iOS] [Fixed] - Fix cookies not being sent on iOS after redirect Pull Request resolved: #22178 Differential Revision: D13191961 Pulled By: shergin fbshipit-source-id: 4445a2499034a9846c6d7c37c1f1b72c9fd30129
Configuration menu - View commit details
-
Copy full SHA for a686048 - Browse repository at this point
Copy the full SHA a686048View commit details -
Fix Xcode 10 builds (broken by folly upgrade) (#22394)
Summary: [Folly upgrade](a70625a) introduced changes that have to be applied to `Install Third Party` script in order to use `New build system` from Xcode 10. Unfortunately, this might happen again if someone changes folly. Also removes non-existent files from folly podspec. Pull Request resolved: #22394 Differential Revision: D13192463 Pulled By: hramos fbshipit-source-id: ea0eeb6e1e7f6d7dfcdb6d1dee28b1a640ee7097
Configuration menu - View commit details
-
Copy full SHA for 287934d - Browse repository at this point
Copy the full SHA 287934dView commit details -
Summary: This module simply forwards to the `promise` module. I inlined the code to remove the dependency. Reviewed By: yungsters Differential Revision: D13137980 fbshipit-source-id: e3d6208068911711fc5f5378f2d5bb6ac38f2eb2
Configuration menu - View commit details
-
Copy full SHA for dc8246d - Browse repository at this point
Copy the full SHA dc8246dView commit details -
Remove isNode call from Map polyfill
Summary: There are no DOM Nodes in React Native so our Map polyfill does not need to consider that use case. I deleted the references to `isNode` and `IE. In case this is important for react-native-web, I suggest to shim the Map polyfill with an IE compatible one outside of react-native. Reviewed By: yungsters Differential Revision: D13138030 fbshipit-source-id: 661511ea03b4477bd55d0fdf5e485178fe59d96b
Configuration menu - View commit details
-
Copy full SHA for f377926 - Browse repository at this point
Copy the full SHA f377926View commit details -
Inline
extractSingleTouch
from fbjsSummary: There is only a single use of this function across RN, and one more use in a test file. I inlined this function in both places to reduce the dependency on fbjs. Reviewed By: yungsters Differential Revision: D13138137 fbshipit-source-id: 32660c965a975d17e236bdd13ff0b2a8d64751ee
Configuration menu - View commit details
-
Copy full SHA for 2de01cb - Browse repository at this point
Copy the full SHA 2de01cbView commit details -
Remove fbjs/lib/emptyFunction from react-native
Summary: This removes `emptyFunction` usage from react-native. Reviewed By: yungsters Differential Revision: D13138187 fbshipit-source-id: eaa327884aac2cabb99024077e3407cb99c946d2
Configuration menu - View commit details
-
Copy full SHA for cfef04e - Browse repository at this point
Copy the full SHA cfef04eView commit details -
Summary: As suggested by yungsters in D13138187 Reviewed By: mjesun Differential Revision: D13192765 fbshipit-source-id: 8ab3dc74b3a9aaebf043bc3b5ed4f2590f480d10
Configuration menu - View commit details
-
Copy full SHA for 1f8b46a - Browse repository at this point
Copy the full SHA 1f8b46aView commit details -
calling markDirtyAndPropogate when setting isReferenceBaseline value
Summary: @public Marking the node as dirty when isReferenceBaseline property is changed Reviewed By: davidaurelio Differential Revision: D13147742 fbshipit-source-id: 3bbff1cfceeadfbf77380519e4638f2984fc2009
Configuration menu - View commit details
-
Copy full SHA for f000cf0 - Browse repository at this point
Copy the full SHA f000cf0View commit details -
Reviewed By: yungsters Differential Revision: D13176340 fbshipit-source-id: 0942970770866c2f2280f746b2c4c592ff0c383c
Configuration menu - View commit details
-
Copy full SHA for fed8b39 - Browse repository at this point
Copy the full SHA fed8b39View commit details -
jest: rename tests to follow the new convention
Summary: Renamed test files to match `-test.js`, so people can add test helpers without blacklisting. Codemod code: P60365841 Script executed: ``` cd xplat/js ./scripts/node/node rename-script.js > result.txt ``` Reviewed By: mjesun Differential Revision: D13185673 fbshipit-source-id: 87451635aa538c2c1d1886e75574d0e5c889596e
Configuration menu - View commit details
-
Copy full SHA for ffa9036 - Browse repository at this point
Copy the full SHA ffa9036View commit details -
jest: make regex for tests stricter
Summary: Updated the configuration for all projects on xplat/js to only consider tests that end with `-test.js`. All tests were migrated in the previous diff of the stack. Reviewed By: mjesun Differential Revision: D13185676 fbshipit-source-id: baaba94fabc403acb30b0b5a0462788813d7a870
Configuration menu - View commit details
-
Copy full SHA for 922e196 - Browse repository at this point
Copy the full SHA 922e196View commit details -
Back out "Add bounce method to TouchableBounce"
Summary: Reverting D13085800 Reviewed By: TheSavior Differential Revision: D13110727 fbshipit-source-id: d5a6e7ff962a350b7cb7d7459abaf861a1387754
Configuration menu - View commit details
-
Copy full SHA for 7fe3f90 - Browse repository at this point
Copy the full SHA 7fe3f90View commit details -
Fabric: Proper implementation of -[RCTViewComponentView prepareForRec…
…ycle] Summary: RCTViewComponentView retains an EventEmitter, so we have to clear this up after we recyled the view. Reviewed By: sahrens Differential Revision: D13196884 fbshipit-source-id: e9f2e2400be864c5c6177227255012101ed8c4d1
Configuration menu - View commit details
-
Copy full SHA for ffd2409 - Browse repository at this point
Copy the full SHA ffd2409View commit details -
Fabric: Proper implementation -[RCTParagraphComponentView prepareForR…
…ecycle]` Summary: Over-retaining a LocalData object inside the View can cause a crash during tearing down JS VM because LocalData can indirectly retain EventEmitter objects which were not properly "disabled". Reviewed By: sahrens Differential Revision: D13196887 fbshipit-source-id: 001d9fadf775c89f750c84fe8da9b84d4636631c
Configuration menu - View commit details
-
Copy full SHA for 215a0f0 - Browse repository at this point
Copy the full SHA 215a0f0View commit details -
Fabric: Fixed a retain cycle between ParagraphShadowNode, LocalData a…
…nd AttributedString Summary: Consider this: * ParagraphShadowNode retains LocalData, * LocalData contains AttributedString, * AttributedString contains Fragments, * Fragment can contain a pointer to parent shadow node, so it can be the ParagraphShadowNode. In this case it's a retain cycle. We actually don't need to store pointers to not TextShadowNodes, so we don't now. Later, after we fully migrate to ShadowView, we can remove this condition because it will become harmless. Reviewed By: sahrens Differential Revision: D13196885 fbshipit-source-id: d386ce0a067df0a72e6619d62d56038aaf80eccb
Configuration menu - View commit details
-
Copy full SHA for 0ec1d21 - Browse repository at this point
Copy the full SHA 0ec1d21View commit details -
Fabric: RCTWeakEventEmitterWrapper, NSAttributedString and co.
Summary: Previously, we stored a pointer to ShadowNode inside NSAttributedString's attributes to make possible retrieving an EventEmitter associated with some text fragment. That worked fine besides only one caveat: the internal implementation of NSAttributedString is quite strange and that causes a memory leak. Because of some reason, NSAttributedString does not release stored attributes after own destruction (maybe OS uses some kind of caching). So, now, instead of storing a strong pointer to ShadowNode inside NSAttributedString, we store a weak pointer to EventEmitter. Storing a weak pointer is okay because a desired lifetime of EventEmitter is guaranteed by LocalData stored inside a View. Storing a weak EventEmitter instead of weak ShadowNode will also help us with migration to ShadowView (we cannot store ShadowView weakly because it's a stack allocated object). Reviewed By: sahrens Differential Revision: D13196886 fbshipit-source-id: f8714e4b3709765629d6456edf0c635bf5f7c53b
Configuration menu - View commit details
-
Copy full SHA for e61a14e - Browse repository at this point
Copy the full SHA e61a14eView commit details
Commits on Nov 27, 2018
-
Create a recursive free with cleanup function
Reviewed By: davidaurelio Differential Revision: D13119307 fbshipit-source-id: 162bb4fd6d7620f61cbac010d0dc236d81738b71
Configuration menu - View commit details
-
Copy full SHA for b5571cd - Browse repository at this point
Copy the full SHA b5571cdView commit details -
Fix: Add displayName to ActivityIndicator (#22417)
Summary: Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes #21937 (a little bit more than it was already fixed). Pull Request resolved: #22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4
Configuration menu - View commit details
-
Copy full SHA for 53da585 - Browse repository at this point
Copy the full SHA 53da585View commit details -
Summary: Set the default text radius to 0 so that text shadows aren't applied to every text node Reviewed By: mdvacca Differential Revision: D13027589 fbshipit-source-id: 4f7386059ac1654b8f77dddf9eb1b772f6049e23
Configuration menu - View commit details
-
Copy full SHA for fd78eee - Browse repository at this point
Copy the full SHA fd78eeeView commit details -
Allow init of Native Module before bridge is initialized [2/N]
Summary: This may be controversial. Right now, RelayPrefetcher is initialized [here](https://fburl.com/p01iunr1), after bridge is initialized. I want to create a FBRelayPrefetcherModule instance eagerly (diff 3 in stack), and then pass that into the bridge module registry. This way, native side gets to use RelayPrefetcher before bridge is init, and JS still accesses the same instance of FBRelayPrefetcherModule. The only other option is drastically change bridge init, to allow passing in some eagerly initialized instances. Reviewed By: shergin Differential Revision: D13164277 fbshipit-source-id: b45111cd68d78820e61e4fca7e54a7e8df32a3f0
Configuration menu - View commit details
-
Copy full SHA for 18f3de9 - Browse repository at this point
Copy the full SHA 18f3de9View commit details -
eslint: Disable jasmine env and only enable jest env for test files
Summary: Modified the ESLint configuration to only enable the Jest environment for files we consider now tests, which are files with the `-test.js` suffix under `__tests__`. Also enabled some globals for test helpers (any file under `__tests__`). This will allow us to catch misspelled tests, while allowing test helpers to use most Jest APIs. Also disabled the Jasmine environment so people stop using Jasmine APIs and we can rollout Circus soon. Reviewed By: aaronabramov Differential Revision: D13199591 fbshipit-source-id: 12a32cf5835630b9987452b0c33d3f8085001689
Configuration menu - View commit details
-
Copy full SHA for 2ae559a - Browse repository at this point
Copy the full SHA 2ae559aView commit details -
Summary: On Android, `Switch` does not currently read its role as a "button". This fixes that and makes it consistent with iOS. Reviewed By: sahrens Differential Revision: D13136253 fbshipit-source-id: 0de5d54772d204168138cb2af7815cc458f72682
Configuration menu - View commit details
-
Copy full SHA for 0c8db08 - Browse repository at this point
Copy the full SHA 0c8db08View commit details -
Added
persistentScrollbar
prop in ScrollView component (#22300)Summary: This PR is a follow-up from the closed [discussions-and-proposals PR](react-native-community/discussions-and-proposals#39), that explains in more detail the rationale for adding this feature. Pull Request resolved: #22300 Reviewed By: fkgozali Differential Revision: D13121748 Pulled By: mdvacca fbshipit-source-id: 899641be79bdb41fa6649df0772c602a5e09b3b9
Configuration menu - View commit details
-
Copy full SHA for d3f3bfa - Browse repository at this point
Copy the full SHA d3f3bfaView commit details -
Fix TouchEvents on text after state changes
Summary: This diff fixes a bug that produces TouchEvents on text to stop working after a react state has happened. An easy way to reproduce this is opening a YellowBox, minimizing it and trying to open it again Reviewed By: shergin Differential Revision: D13198663 fbshipit-source-id: 19b08818bbff8014ab8227b3db1119edc4193389
Configuration menu - View commit details
-
Copy full SHA for 00681c3 - Browse repository at this point
Copy the full SHA 00681c3View commit details -
Use Changelog instead of Release Notes for danger bot (#22395)
Summary: In #22117 we changed the PR template to use `Changelog` instead of `Release notes` and now danger bot is complaining as it wasn't updated there. cc turnrye Pull Request resolved: #22395 Differential Revision: D13195006 Pulled By: TheSavior fbshipit-source-id: 36b9675c1e30c86fb8d002b121cc29239d6f78dd
Configuration menu - View commit details
-
Copy full SHA for 706888d - Browse repository at this point
Copy the full SHA 706888dView commit details -
Fix unmangled visibility in rn_defs
Summary: The wrappers exposed by `rn_defs.bzl` should mangle visibility to include the cell. Reviewed By: scottrice Differential Revision: D13219109 fbshipit-source-id: ded17e79a1d388d6b76fbdf2ab0d75e586092fcd
Configuration menu - View commit details
-
Copy full SHA for 7030d95 - Browse repository at this point
Copy the full SHA 7030d95View commit details -
Summary: D13105396 broke a few things, so I'm reverting it. See: https://fburl.com/toehyir8 Reviewed By: sahrens, mmmulani Differential Revision: D13220491 fbshipit-source-id: 35594099eea7f40d2fb948ae2010db4babb7093d
Configuration menu - View commit details
-
Copy full SHA for ada7089 - Browse repository at this point
Copy the full SHA ada7089View commit details
Commits on Nov 28, 2018
-
Summary: Instead of assigning all the constants exported by a NativeModule to the native module JavaScript object itself, we want to instead export a `getConstants()` method that can be used to access native module constants. This change simplifies the API of native modules. Eventually, we'll remove the ability to access constants as native module object properties alltogether, but that's comes later. **Note**: I didn't need to make any cpp changes because `JSIExecutor::NativeModuleProxy::get` calls `JSINativeModules::getModule` (here: https://goo.gl/QwPDWF), which eventually calls `JSINativeModules::createModule`, which uses `global.__fbGenNativeModule` (here: https://goo.gl/pSxMgE), which is just an alias to `genModule` in `NativeModules` (here: https://goo.gl/u2wjCs). Reviewed By: fkgozali Differential Revision: D13207152 fbshipit-source-id: 375aab1346232819187a5d5b272b33c55992346a
Configuration menu - View commit details
-
Copy full SHA for db43aa8 - Browse repository at this point
Copy the full SHA db43aa8View commit details -
Flow strict in Picker.js, PickerIOS.ios.js, PickerAndroid.android.js (#…
Configuration menu - View commit details
-
Copy full SHA for 23845fb - Browse repository at this point
Copy the full SHA 23845fbView commit details -
Small cleanup of TextInputExample
Summary: Use array+map like other examples for DRY. Reviewed By: TheSavior Differential Revision: D13222132 fbshipit-source-id: 15171e496eaef8794c02e853950f666d77372923
Configuration menu - View commit details
-
Copy full SHA for 7b2e3f8 - Browse repository at this point
Copy the full SHA 7b2e3f8View commit details -
Fabric:
UIManagerBinding::getRelativeLayoutMetrics
Summary: Exposing the getRelativeLayoutMetrics method to JS. Reviewed By: mdvacca Differential Revision: D13036552 fbshipit-source-id: de825dfde8e64163168510aea1eda77370753b29
Configuration menu - View commit details
-
Copy full SHA for d594d5a - Browse repository at this point
Copy the full SHA d594d5aView commit details -
Fabric:
ShadowTree::completeByReplacingShadowNode
Summary: This method is the core of the future features: `setNativeProps` and `LocalState`. Reviewed By: sahrens Differential Revision: D13114789 fbshipit-source-id: 2138496c43c171fe27784b1959d86d6eec4638ee
Configuration menu - View commit details
-
Copy full SHA for f42d2b9 - Browse repository at this point
Copy the full SHA f42d2b9View commit details -
Fabric: UIManager::setNativeProps
Summary: Pretty straightforward wiring UIManager and the new feature in ShadowTree: we get the node, clone with the new props and then replace this. Reviewed By: sahrens Differential Revision: D13114788 fbshipit-source-id: 3a34fb879f3ec564c26278034a19b88518302de8
Configuration menu - View commit details
-
Copy full SHA for 142dd76 - Browse repository at this point
Copy the full SHA 142dd76View commit details -
Fabric: UIManagerBinding::setNativeProps
Summary: Pretty straightforward. Reviewed By: sahrens Differential Revision: D13114836 fbshipit-source-id: ff86b28d8764955383d4b46a369faf978825f6eb
Configuration menu - View commit details
-
Copy full SHA for 28c3981 - Browse repository at this point
Copy the full SHA 28c3981View commit details -
Introducing
fabric/mounting
moduleSummary: ShadowView, ShadowViewMutation, and Differentiator were decoupled to separate module. That enables us to use ShadowView more widely without facing a circular dependency problem. Reviewed By: mdvacca Differential Revision: D13205229 fbshipit-source-id: 7373864bf153a7813c2f97edb263a41454ce0b88
Configuration menu - View commit details
-
Copy full SHA for 62173a1 - Browse repository at this point
Copy the full SHA 62173a1View commit details -
Fabric: std::hash for ShadowView
Summary: Trivial. We need this for future use as part of AttributedString's hash. Reviewed By: mdvacca Differential Revision: D13205231 fbshipit-source-id: 14a3decae72741030284a30abdb936616bafb3fe
Configuration menu - View commit details
-
Copy full SHA for 6c3b05f - Browse repository at this point
Copy the full SHA 6c3b05fView commit details -
Fabric: Using ShadowView instad of ShadowNode inside AttributedString
Summary: That's generally better because: * Avoids exposing ShadowNode to mounting layer; * Enables hashing and comparing the AttributedString based on actual meaningful data (not on just a pointer to ShadowNode). Reviewed By: mdvacca Differential Revision: D13205230 fbshipit-source-id: 7b79c1aad97b10d81e3faa10408be61b74f815cf
Configuration menu - View commit details
-
Copy full SHA for 7197aa0 - Browse repository at this point
Copy the full SHA 7197aa0View commit details -
Fabric: Fixed incorrect systrace marker in UIManagerBinding::dispatch…
…Event Summary: `SystraceSection` relies on RAII, so previously it measured only `if (eventTarget) {`'s body. Reviewed By: mdvacca Differential Revision: D13123047 fbshipit-source-id: 463fba783763f694b51325f98314d36b7da2f887
Configuration menu - View commit details
-
Copy full SHA for 106de12 - Browse repository at this point
Copy the full SHA 106de12View commit details -
Fabric: Coupling
Tag
insideTargetEventEmitter
Summary: Now instead of passing `reactTag` through the whole event pipeline, we store it inside `EventTargetWrapper` (and it does not leave `UIManagerBinding`). It helps with reducing the complexity of `EventEmitter` and will help us in migrating to JSI. Reviewed By: sahrens Differential Revision: D13123045 fbshipit-source-id: aa9ee94d5660ff3090369c1e55cf748d2e72b987
Configuration menu - View commit details
-
Copy full SHA for f4da876 - Browse repository at this point
Copy the full SHA f4da876View commit details -
Fabric:
ValueFactory
andEventEmitter::dispatchEvent
based on thatSummary: Now the event delive pipeline supports `JSI::Value`-based payload. Instead of passing `folly::dynamic`, now we are passing `std::function<jsi::Value(jsi::Runtime &runtime)>` as factory that can build a `JSI::Value` with given `jsi::Runtime` and any captured data. The old (now legacy) way of calling `EventEmitter::dispatchEvent(..., const folly::dynamic &payload, ...)` is also supported. Reviewed By: sahrens Differential Revision: D13123043 fbshipit-source-id: d65348bb215013042abb2fcfe5083a8c697333d0
Configuration menu - View commit details
-
Copy full SHA for dea8773 - Browse repository at this point
Copy the full SHA dea8773View commit details -
Fabric: Migrating SwitchEventEmitter to JSI-based payload
Summary: Pretty straight-forward migration to using `JSI` instead of `folly::dynamic` in SwitchEventEmitter. Reviewed By: sahrens Differential Revision: D13123046 fbshipit-source-id: f2e4905a96191540ceec633bae1871c93be724db
Configuration menu - View commit details
-
Copy full SHA for eeaf009 - Browse repository at this point
Copy the full SHA eeaf009View commit details -
Fabric: Migrating ViewEventEmitter to JSI-based payload
Summary: Pretty straight-forward migration to using `JSI` instead of `folly::dynamic` in ViewEventEmitter. Reviewed By: sahrens Differential Revision: D13123048 fbshipit-source-id: 3c323912d3e65b684f99df6cda99c785876164af
Configuration menu - View commit details
-
Copy full SHA for 610dac4 - Browse repository at this point
Copy the full SHA 610dac4View commit details -
Fabric: Migrating ScrollViewEventEmitter to JSI-based payload
Summary: Pretty straight-forward migration to using `JSI` instead of `folly::dynamic` in `ScrollViewEventEmitter`. Reviewed By: sahrens Differential Revision: D13123049 fbshipit-source-id: 2839976d0119c48fa2538dbaa53afbc24982c598
Configuration menu - View commit details
-
Copy full SHA for 847e6fd - Browse repository at this point
Copy the full SHA 847e6fdView commit details -
Fabric: Migrating TouchEventEmitter to JSI-based payload
Summary: Pretty straight-forward migration to using `JSI` instead of `folly::dynamic` in `TouchEventEmitter`. Reviewed By: sahrens Differential Revision: D13123042 fbshipit-source-id: 594b89b6e3986d6a04846194701e3a727b152cec
Configuration menu - View commit details
-
Copy full SHA for c30c803 - Browse repository at this point
Copy the full SHA c30c803View commit details -
Summary: Upgrades to `chalk@^2.4.1`. Verified no dependencies to the breaking changes in `[email protected]`. Reviewed By: cpojer Differential Revision: D13192150 fbshipit-source-id: 27a1a53d50a3c7628528a4f21e7166d452b2f205
Configuration menu - View commit details
-
Copy full SHA for 4355b2d - Browse repository at this point
Copy the full SHA 4355b2dView commit details -
Summary: Fixes a minor Flow type error when `minimist` is typed via `flow-typed`. Reviewed By: TheSavior Differential Revision: D13188680 fbshipit-source-id: 9ad35a3222c8937163a998a2751efd95945af3c7
Configuration menu - View commit details
-
Copy full SHA for 51d983b - Browse repository at this point
Copy the full SHA 51d983bView commit details -
DeltaClient: split DeltaBundle's modules into added and modified
Summary: The reasoning behind this change is that right now, having both added and modified modules inside of a single `modules` field doesn't allow for basic operations like combining two deltas. For instance, say I have three different bundle revisions: A, B and C. Module 42 was added in B, and then removed in C. A->B = `{modules: [42, "..."], deleted: []}` B->C = `{modules: [], deleted: [42]}` A->C = `{modules: [], deleted: []}` However, were we to compute A->C as the combination of A->B and B->C, it would result in `{modules: [], deleted: [42]}` because we have no way of knowing that module 42 was only just added in B. This means that the `deleted` field of delta X->Y might eventually contain module ids that were never present in revision X, because they were added and then removed between revisions X and Y. The last time I changed the delta format, we had a few bug reports pop out from people who had desync issues between their version of React Native and their version of Metro. As such, I've tried to make this change backwards compatible in at least one direction (new RN, old Metro). However, this will still break if someone is using a newer version of Metro and an older version of RN. I created T37123645 to follow up on this. Reviewed By: rafeca, fromcelticpark Differential Revision: D13156514 fbshipit-source-id: 4a4ee3b6cc0cdff5dca7368a46d7bf663769e281
Configuration menu - View commit details
-
Copy full SHA for e81adb9 - Browse repository at this point
Copy the full SHA e81adb9View commit details -
Fix rename legacy component lifecycles (#22125)
Summary: Adding an “UNSAFE_” prefix to `componentWillMount`. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. - [x] yarn test - [x] yarn flow - [x] yarn flow-check-ios - [x] yarn flow-check-android [General] [Fixed] - adding an UNSAFE_ prefix Pull Request resolved: #22125 Differential Revision: D13237831 Pulled By: mmmulani fbshipit-source-id: b4ca1e4628f93e89fd5680c40b0e3f7c7db6ad38
Configuration menu - View commit details
-
Copy full SHA for c293f29 - Browse repository at this point
Copy the full SHA c293f29View commit details
Commits on Nov 29, 2018
-
JSBigString: Explicitly include unistd.h (#22330)
Summary: `JSBigString` is using functions from `unistd.h`, like `getpagesize`, `dup`, `open`, etc. but was not directly including it. It was being included from inside the glog `logging.h` header, which in turn was getting included by the Folly headers `JSBigString` was using. This was discovered while building CxxReact with a custom shimmed Glog. Pull Request resolved: #22330 Differential Revision: D13115346 Pulled By: shergin fbshipit-source-id: 9fe4e3b28f74c0ca351ac6308484e375eace4db4
Configuration menu - View commit details
-
Copy full SHA for d6d31a4 - Browse repository at this point
Copy the full SHA d6d31a4View commit details -
Calling -[UIScrollView setContentOffset] with NaN values can cause a crash. That's not clear why exactly the computation returns NaN sometime, but the implemented sanitizing should help to detect this problem during development (and this also prevents the app from crashing). See attached task for more details. Reviewed By: fkgozali Differential Revision: D13242729 fbshipit-source-id: 747bf1b42e02597e9f1300eee24547563ab29b27
Configuration menu - View commit details
-
Copy full SHA for 585f7b9 - Browse repository at this point
Copy the full SHA 585f7b9View commit details -
Summary: allow-large-files Reviewed By: samwgoldman Differential Revision: D13230018 fbshipit-source-id: f07e2371a3b7382de0592cc7c7b20e7f4faa6889
Configuration menu - View commit details
-
Copy full SHA for ef2084c - Browse repository at this point
Copy the full SHA ef2084cView commit details -
Summary: @public Add YGMarker files to XCode project Reviewed By: SidharthGuglani Differential Revision: D13255283 fbshipit-source-id: 2035111cca6f0e5265a4ebe99eee701af4eff51e
Configuration menu - View commit details
-
Copy full SHA for dac29e8 - Browse repository at this point
Copy the full SHA dac29e8View commit details -
Adjust yearless format for MIT license
Summary: @public Adjust license headers throughout the project Reviewed By: SidharthGuglani Differential Revision: D13255691 fbshipit-source-id: 98be2aa372a94e7a54a65e3d64e5c6a436b18083
Configuration menu - View commit details
-
Copy full SHA for ea734dc - Browse repository at this point
Copy the full SHA ea734dcView commit details