Fix Xcode 10 builds (broken by folly upgrade) #22394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
These files were removed from folly
Co-Authored-By: Kudo Chien <[email protected]>
gengjiawen
approved these changes
Nov 24, 2018
Kudo
approved these changes
Nov 24, 2018
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
@kelset is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
that referenced
this pull request
Nov 27, 2018
Summary: [Folly upgrade](a70625a) introduced changes that have to be applied to `Install Third Party` script in order to use `New build system` from Xcode 10. Unfortunately, this might happen again if someone changes folly. Also removes non-existent files from folly podspec. Pull Request resolved: #22394 Differential Revision: D13192463 Pulled By: hramos fbshipit-source-id: ea0eeb6e1e7f6d7dfcdb6d1dee28b1a640ee7097
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: [Folly upgrade](facebook@a70625a) introduced changes that have to be applied to `Install Third Party` script in order to use `New build system` from Xcode 10. Unfortunately, this might happen again if someone changes folly. Also removes non-existent files from folly podspec. Pull Request resolved: facebook#22394 Differential Revision: D13192463 Pulled By: hramos fbshipit-source-id: ea0eeb6e1e7f6d7dfcdb6d1dee28b1a640ee7097
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: [Folly upgrade](facebook/react-native@a70625a) introduced changes that have to be applied to `Install Third Party` script in order to use `New build system` from Xcode 10. Unfortunately, this might happen again if someone changes folly. Also removes non-existent files from folly podspec. Pull Request resolved: facebook/react-native#22394 Differential Revision: D13192463 Pulled By: hramos fbshipit-source-id: ea0eeb6e1e7f6d7dfcdb6d1dee28b1a640ee7097
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folly upgrade introduced changes that have to be applied to
Install Third Partyscript in order to useNew build systemfrom Xcode 10. Unfortunately, this might happen again if someone changes folly. Also removes non-existent files from folly podspec.Test Plan:
Run RNTester before applying this change, apply this commit and try the build again.
Release notes:
[IOS] [FIXED] - Fixed Xcode 10 build broken by folly upgrade