Remove useless additionnal blur call #22156
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
cc @sahrens. It seems like you introduced this line back in 2015. This looks like it's fairly harmless, but I wonder if you intentionally added this line (as a hack) to fix some bug (that may or may not exist now). Should we just land this as is? |
There was a problem hiding this comment.
@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
gazoudoudou merged commit 27cfba2 into |
Summary: I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component. After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur. By removing this line, I fix this unecessary multiple call. Pull Request resolved: #22156 Reviewed By: TheSavior Differential Revision: D13105396 Pulled By: RSNara fbshipit-source-id: 8e83461d8b288d8ee4047bc4a33c4480e193c349
|
Apparently this "extra" blur call was necessary on Android. Reverting this PR fixes #22425 |
Summary: I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component. After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur. By removing this line, I fix this unecessary multiple call. Pull Request resolved: facebook#22156 Reviewed By: TheSavior Differential Revision: D13105396 Pulled By: RSNara fbshipit-source-id: 8e83461d8b288d8ee4047bc4a33c4480e193c349
I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component.
After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur.
By removing this line, I fix this unecessary multiple call.