Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation on View prop 'elevation' #13823

Closed
JReinhold opened this issue May 7, 2017 · 2 comments
Closed

Missing documentation on View prop 'elevation' #13823

JReinhold opened this issue May 7, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@JReinhold
Copy link

Description

Documentation on what styles can be given to a View have been removed in v0.44, and is now replaced with the simple line style?: stylePropType. (I don't know if this is on purpose or not, but it's rather confusing, and not very informative)

As a consequence, documentation on style props mut now be found under Shadow Props and
Layout Props.
None of these pages include documentation on the Android-only elevation prop, that handles shadows on Android.

Reproduction Steps and Sample Code

See 0.43 View style prop vs 0.44 View style prop

Solution

It would be misleading to document the elevation prop on the Shadow Props page, as the props listed there are suppose to go into a StyleSheet, while the elevation is a prop on View. Instead I would recommend documenting the prop on the View documentation.

Additional Information

  • React Native version: 0.44
  • Platform: Docs
  • Development Operating System: Not applicable
  • Dev tools: Not applicable
@shermango
Copy link

bump

@hramos
Copy link
Contributor

hramos commented Jul 20, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 20, 2017
@hramos hramos closed this as completed Jul 20, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants