Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rename legacy component lifecycles #22125

Closed
wants to merge 1 commit into from
Closed

Fix rename legacy component lifecycles #22125

wants to merge 1 commit into from

Conversation

yushimatenjin
Copy link

@yushimatenjin yushimatenjin commented Nov 5, 2018 •
edited
Loading

Adding an “UNSAFE_” prefix to componentWillMount.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.

Test Plan:

  • yarn test
  • yarn flow
  • yarn flow-check-ios
  • yarn flow-check-android

Release Notes:

[General] [Fixed] - adding an UNSAFE_ prefix

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ✅pr adds tests labels Nov 5, 2018
@pull-bot
Copy link

pull-bot commented Nov 5, 2018

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@yushimatenjin yushimatenjin changed the title adding an UNSAFE_ prefix Fix rename legacy component lifecycles Nov 5, 2018
@turnrye
Copy link
Contributor

turnrye commented Nov 5, 2018

Hi @yushimatenjin! Thanks for the help! Is this related to #22100? I plan to combine those entries in the changelog to a single entry, so the changelog section in this PR is n/a. I'll make sure that once this PR lands, you're attributed for your contribution.

@yushimatenjin
Copy link
Author

Hi @yushimatenjin! Thanks for the help! Is this related to #22100? I plan to combine those entries in the changelog to a single entry, so the changelog section in this PR is n/a. I'll make sure that once this PR lands, you're attributed for your contribution.

This pull request is not #22100

I'd like to do #22100

facebook-github-bot
facebook-github-bot reviewed Nov 28, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmmulani has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 28, 2018
@mmmulani
Copy link
Contributor

ありがとうございました！🙇🏾‍♂️

@react-native-bot
Copy link
Collaborator

@yushimatenjin merged commit c293f29 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Nov 28, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 28, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Jul 18, 2019
@facebook-github-bot
Fix rename legacy component lifecycles (#22125)
b4a3150 
Summary:
Adding an “UNSAFE_” prefix to `componentWillMount`.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.

- [x] yarn test
- [x] yarn flow
- [x] yarn flow-check-ios
- [x] yarn flow-check-android

[General] [Fixed] - adding an UNSAFE_ prefix
Pull Request resolved: facebook/react-native#22125

Differential Revision: D13237831

Pulled By: mmmulani

fbshipit-source-id: b4ca1e4628f93e89fd5680c40b0e3f7c7db6ad38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mmmulani mmmulani mmmulani approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yushimatenjin @pull-bot @turnrye @mmmulani @react-native-bot @facebook-github-bot @hramos