Fix allocating Buffer in early commit #22379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
@dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Dec 3, 2018
Summary: Commit facebook/react-native@d9c2cda brings compatibility with Node 10, but replaced allocating buffer incorrectly. dulmandakh made two comments and shows how to do it based on NodeJS documentation https://nodejs.org/api/buffer.html#buffer_new_buffer_size This PR just fixes that commit. Pull Request resolved: facebook/react-native#22379 Differential Revision: D13166867 Pulled By: hramos fbshipit-source-id: 207528739889c044021a4b97ef94c33d56de3e89
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Commit facebook@d9c2cda brings compatibility with Node 10, but replaced allocating buffer incorrectly. dulmandakh made two comments and shows how to do it based on NodeJS documentation https://nodejs.org/api/buffer.html#buffer_new_buffer_size This PR just fixes that commit. Pull Request resolved: facebook#22379 Differential Revision: D13166867 Pulled By: hramos fbshipit-source-id: 207528739889c044021a4b97ef94c33d56de3e89
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d9c2cda brings compatibility with Node 10, but replaced allocating buffer incorrectly.
@dulmandakh made two comments and shows how to do it based on NodeJS documentation https://nodejs.org/api/buffer.html#buffer_new_buffer_size
This PR just fixes that commit.
Test Plan:
CI Green.
Changelog:
No changelog, it is internal fix.