JSBigString: Explicitly include unistd.h #22330
Conversation
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
Do you know why this failed to land internally? |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit d6d31a4 into |
hramos
removed
Import Started
JSBigStringis using functions fromunistd.h, likegetpagesize,dup,open, etc. but was not directly including it.It was being included from inside the glog
logging.hheader, which in turn was getting included by the Folly headersJSBigStringwas using.This was discovered while building CxxReact with a custom shimmed Glog.
Test Plan:
No build regressions have been noticed.
Changelog:
[General] [Fixed] -
JSBigString: Explicitly included dependant headerunistd.h(minor)