feat(plasma-b2c,plasma-web): Button size_xs/xxs #780
Conversation
Yeti-or
requested review from
neretin-trike,
Yakutoc and
kayman233
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/plasma-b2c/src/components/Button/Button.stories.tsx
Dismissed
Show dismissed
Hide dismissed
packages/plasma-b2c/src/components/Button/Button.stories.tsx
Dismissed
Show dismissed
Hide dismissed
packages/plasma-b2c/src/components/Button/Button.stories.tsx
Dismissed
Show dismissed
Hide dismissed
packages/plasma-b2c/src/components/Button/Button.stories.tsx
Dismissed
Show dismissed
Hide dismissed
packages/plasma-b2c/src/components/Button/Button.stories.tsx
Dismissed
Show dismissed
Hide dismissed
packages/plasma-b2c/src/components/Button/Button.stories.tsx
Dismissed
Show dismissed
Hide dismissed
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-780/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-780/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
| @@ -1,11 +1,40 @@ | |||
| import styled from 'styled-components'; | |||
| import { ButtonRoot, getButtonSizesMixin, buttonSizes, buttonTypography } from '@salutejs/plasma-core'; | |||
| import type { ButtonSizeProps, ButtonViewProps } from '@salutejs/plasma-core'; | |||
| import { bodyXSBold, bodyXXSBold } from '@salutejs/plasma-typo'; | |||
There was a problem hiding this comment.
кажется, что тут пока нельзя использовать новую типографику, т.к. без подключения файла compatible токены не подянутся, и будет как у тебя на снапшоте
то есть тут лучше использовать старые токены
There was a problem hiding this comment.
как в файле Button.props.ts
There was a problem hiding this comment.
fuck
но откуда их взять то
There was a problem hiding this comment.
нет токенов для таких размеров ж
There was a problem hiding this comment.
для xs размера можно использовать миксин caption , а вот для xxs пока хз 🤔
There was a problem hiding this comment.
в принципе можно underline попробовать. Только нужно будет его добавить в мапу compatible + перебить text-transform
There was a problem hiding this comment.
слушай я решил долбануть прям as-is
There was a problem hiding this comment.
а почему не захотел так сделать?
neretin-trike
changed the title
Yeti-or
force-pushed
the
yeti-or.button-sizes
branch
from
2975f21 to
c85ae94
Compare
| contentLeft={(contentType === 'Left' || contentType === 'Text+Left') && <IconPlaceholder />} | ||
| contentRight={contentType === 'Text+Right' && <IconPlaceholder />} | ||
| contentLeft={ | ||
| (contentType === 'Left' || contentType === 'Text+Left') && <IconPlaceholder size={iconSize[rest.size]} /> |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| contentLeft={ | ||
| (contentType === 'Left' || contentType === 'Text+Left') && <IconPlaceholder size={iconSize[rest.size]} /> | ||
| } | ||
| contentRight={contentType === 'Text+Right' && <IconPlaceholder size={iconSize[rest.size]} />} |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| contentLeft={(contentType === 'Left' || contentType === 'Text+Left') && <IconPlaceholder />} | ||
| contentRight={contentType === 'Text+Right' && <IconPlaceholder />} | ||
| contentLeft={ | ||
| (contentType === 'Left' || contentType === 'Text+Left') && <IconPlaceholder size={iconSize[rest.size]} /> |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| contentLeft={ | ||
| (contentType === 'Left' || contentType === 'Text+Left') && <IconPlaceholder size={iconSize[rest.size]} /> | ||
| } | ||
| contentRight={contentType === 'Text+Right' && <IconPlaceholder size={iconSize[rest.size]} />} |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| contentRight={contentType === 'Text+Right' && <IconPlaceholder />} | ||
| contentLeft={ | ||
| (contentType === 'Left' || contentType === 'Text+Left') && ( | ||
| <IconPlaceholder size={iconSize[rest.size]} /> |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| <IconPlaceholder size={iconSize[rest.size]} /> | ||
| ) | ||
| } | ||
| contentRight={contentType === 'Text+Right' && <IconPlaceholder size={iconSize[rest.size]} />} |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-780/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-780/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
Button_size_xs / Button_size_xxs
Добавили два размера кнопки: 'xs', 'xxs'
🐤 Download canary assets:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
Version
Published prerelease version:
@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]Changelog
Release Notes
plasma-web: Pass
refto DropdownItem (#769)Добавлена возможность использовать свойство
refдля компонентаDropdownItemplasma-infra: Update version (#770)
Выключили sync package-lock's файлов для приватных пакетов.
What/why Changed
При попытке установить приватный пакет, получаем ошибку 404 - Not found.
Поэтому принято решение не запускать
npm i --package-lock-onlyдля приватнных пакетов.Добавлен флаг
--legacy-peer-depsчто бы исключить ошибки:plasma-infra: Update private packages version with @auto-it (#734)
Включили обновление версий для всех пакетов, включая приватные.
What/why Changed
Сделали патчи для
@auto-it/coreи@auto-it/npmчто бы можно было включить в обработку все пакеты.Как оказалось в
@auto-it/coreв методеgetLernaPackages(packages/core/src/utils/get-lerna-packages.ts)была логика фильтрующая пакеты по полюprivate:C помощью
patch-packageсделал патчи для изменения этой логики.В этом commit из песочнице можно посмотреть как это работает.
Запуск локально проекта
auto next --dry-run(Report what command will do but do not actually do anything)при изменениях в пакете
plasma-web:Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.
🚀 Enhancement
Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-hopeRadioboxcomponent #775 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)refto DropdownItem #769 (@Yakutoc)@salutejs/plasma-webRadioboxcomponent with new design and core #775 (@neretin-trike)Checkboxfrom plasma-new-hope and update snapshots #754 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-b2cRadioboxcomponent with new design and core #775 (@neretin-trike)Checkboxcomponent with new design and core #754 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-new-hopeRadioboxcomponent with new design and core #775 (@neretin-trike)Checkboxcomponent with new design and core #754 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-core,@salutejs/plasma-new-hopeSpinnercomponent with new design and core #736 (@neretin-trike)@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-tokens@salutejs/plasma-tokens-utils@salutejs/plasma-tokens,@salutejs/plasma-tokens-utils@salutejs/plasma-ui🐛 Bug Fix
@salutejs/plasma-b2c,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-core,@salutejs/plasma-hope@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-coredev@salutejs/plasma-b2c,@salutejs/plasma-hope,@salutejs/plasma-new-hope,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-new-hope,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-new-hope,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-b2c,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-tokens-b2b,@salutejs/plasma-tokens-b2c,@salutejs/plasma-tokens-web,@salutejs/plasma-tokens,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-cy-utils,@salutejs/plasma-sb-utils,@salutejs/plasma-tokens-utils@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-tokens-web,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils,@salutejs/plasma-tokens-utils@salutejs/plasma-new-hope@salutejs/plasma-temple,@salutejs/plasma-uiAuthors: 7