Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-infra: Update private packages version with @auto-it #734

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Sep 20, 2023

Release Notes

Включили обновление версий для всех пакетов, включая приватные.

What/why Changed

Сделали патчи для @auto-it/core и @auto-it/npm что бы можно было включить в обработку все пакеты.

Как оказалось в @auto-it/core в методе getLernaPackages(packages/core/src/utils/get-lerna-packages.ts) была логика фильтрующая пакеты по полю private:

   if (version !== "MISSING" && isPrivate !== "PRIVATE") {
      packages.push({ path: packagePath, name, version });
    }

C помощью patch-package сделал патчи для изменения этой логики.

В этом commit из песочнице можно посмотреть как это работает.

Запуск локально проекта auto next --dry-run (Report what command will do but do not actually do anything)

при изменениях в пакете plasma-web:

Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.


🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.734.6245473475.ts
borderRadius_plasma_b2c_react-native--canary.734.6245473475.ts
borderRadius_plasma_web_react-native--canary.734.6245473475.ts
borderRadius_sberHealth_react-native--canary.734.6245473475.ts
borderRadius_sbermarket_business_react-native--canary.734.6245473475.ts
borderRadius_sbermarket_metro_react-native--canary.734.6245473475.ts
borderRadius_sbermarket_react-native--canary.734.6245473475.ts
borderRadius_sbermarket_selgros_react-native--canary.734.6245473475.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.734.6245473475.ts
borderRadius_sberonline_react-native--canary.734.6245473475.ts
borderRadius_sberprime_react-native--canary.734.6245473475.ts
borderRadius_stylesSalute_react-native--canary.734.6245473475.ts
color
color_default_ios-swift--canary.734.6245473475.swift
color_default_kotlin--canary.734.6245473475.kt
color_default_react-native--canary.734.6245473475.ts
color_default_xml--canary.734.6245473475.xml
color_plasma_b2c_ios-swift--canary.734.6245473475.swift
color_plasma_b2c_kotlin--canary.734.6245473475.kt
color_plasma_b2c_react-native--canary.734.6245473475.ts
color_plasma_b2c_xml--canary.734.6245473475.xml
color_plasma_web_ios-swift--canary.734.6245473475.swift
color_plasma_web_kotlin--canary.734.6245473475.kt
color_plasma_web_react-native--canary.734.6245473475.ts
color_plasma_web_xml--canary.734.6245473475.xml
color_sberHealth_ios-swift--canary.734.6245473475.swift
color_sberHealth_kotlin--canary.734.6245473475.kt
color_sberHealth_react-native--canary.734.6245473475.ts
color_sberHealth_xml--canary.734.6245473475.xml
color_sbermarket_business_ios-swift--canary.734.6245473475.swift
color_sbermarket_business_kotlin--canary.734.6245473475.kt
color_sbermarket_business_react-native--canary.734.6245473475.ts
color_sbermarket_business_xml--canary.734.6245473475.xml
color_sbermarket_ios-swift--canary.734.6245473475.swift
color_sbermarket_kotlin--canary.734.6245473475.kt
color_sbermarket_metro_ios-swift--canary.734.6245473475.swift
color_sbermarket_metro_kotlin--canary.734.6245473475.kt
color_sbermarket_metro_react-native--canary.734.6245473475.ts
color_sbermarket_metro_xml--canary.734.6245473475.xml
color_sbermarket_react-native--canary.734.6245473475.ts
color_sbermarket_selgros_ios-swift--canary.734.6245473475.swift
color_sbermarket_selgros_kotlin--canary.734.6245473475.kt
color_sbermarket_selgros_react-native--canary.734.6245473475.ts
color_sbermarket_selgros_xml--canary.734.6245473475.xml
color_sbermarket_wlbusiness_ios-swift--canary.734.6245473475.swift
color_sbermarket_wlbusiness_kotlin--canary.734.6245473475.kt
color_sbermarket_wlbusiness_react-native--canary.734.6245473475.ts
color_sbermarket_wlbusiness_xml--canary.734.6245473475.xml
color_sbermarket_xml--canary.734.6245473475.xml
color_sberonline_ios-swift--canary.734.6245473475.swift
color_sberonline_kotlin--canary.734.6245473475.kt
color_sberonline_react-native--canary.734.6245473475.ts
color_sberonline_xml--canary.734.6245473475.xml
color_sberprime_ios-swift--canary.734.6245473475.swift
color_sberprime_kotlin--canary.734.6245473475.kt
color_sberprime_react-native--canary.734.6245473475.ts
color_sberprime_xml--canary.734.6245473475.xml
color_stylesSalute_ios-swift--canary.734.6245473475.swift
color_stylesSalute_kotlin--canary.734.6245473475.kt
color_stylesSalute_react-native--canary.734.6245473475.ts
color_stylesSalute_xml--canary.734.6245473475.xml
shadow
shadow_default_react-native--canary.734.6245473475.ts
shadow_plasma_b2c_react-native--canary.734.6245473475.ts
shadow_plasma_web_react-native--canary.734.6245473475.ts
shadow_sberHealth_react-native--canary.734.6245473475.ts
shadow_sbermarket_business_react-native--canary.734.6245473475.ts
shadow_sbermarket_metro_react-native--canary.734.6245473475.ts
shadow_sbermarket_react-native--canary.734.6245473475.ts
shadow_sbermarket_selgros_react-native--canary.734.6245473475.ts
shadow_sbermarket_wlbusiness_react-native--canary.734.6245473475.ts
shadow_sberonline_react-native--canary.734.6245473475.ts
shadow_sberprime_react-native--canary.734.6245473475.ts
shadow_stylesSalute_react-native--canary.734.6245473475.ts
spacing
spacing_default_react-native--canary.734.6245473475.ts
spacing_plasma_b2c_react-native--canary.734.6245473475.ts
spacing_plasma_web_react-native--canary.734.6245473475.ts
spacing_sberHealth_react-native--canary.734.6245473475.ts
spacing_sbermarket_business_react-native--canary.734.6245473475.ts
spacing_sbermarket_metro_react-native--canary.734.6245473475.ts
spacing_sbermarket_react-native--canary.734.6245473475.ts
spacing_sbermarket_selgros_react-native--canary.734.6245473475.ts
spacing_sbermarket_wlbusiness_react-native--canary.734.6245473475.ts
spacing_sberonline_react-native--canary.734.6245473475.ts
spacing_sberprime_react-native--canary.734.6245473475.ts
spacing_stylesSalute_react-native--canary.734.6245473475.ts
typo
typo_mage_ios-swift--canary.734.6245473475.swift
typo_mage_kotlin--canary.734.6245473475.kt
typo_mage_react-native--canary.734.6245473475.ts
typo_plasma_ios-swift--canary.734.6245473475.swift
typo_plasma_kotlin--canary.734.6245473475.kt
typo_plasma_react-native--canary.734.6245473475.ts
typo_ruler_ios-swift--canary.734.6245473475.swift
typo_ruler_kotlin--canary.734.6245473475.kt
typo_ruler_react-native--canary.734.6245473475.ts
typo_sage_ios-swift--canary.734.6245473475.swift
typo_sage_kotlin--canary.734.6245473475.kt
typo_sage_react-native--canary.734.6245473475.ts
typo_sbermarket_ios-swift--canary.734.6245473475.swift
typo_sbermarket_kotlin--canary.734.6245473475.kt
typo_sbermarket_react-native--canary.734.6245473475.ts
typo_soulmate_ios-swift--canary.734.6245473475.swift
typo_soulmate_kotlin--canary.734.6245473475.kt
typo_soulmate_react-native--canary.734.6245473475.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]

Version

Published prerelease version: @salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Changelog

Release Notes

plasma-infra: Update private packages version with @auto-it (#734)

Включили обновление версий для всех пакетов, включая приватные.

What/why Changed

Сделали патчи для @auto-it/core и @auto-it/npm что бы можно было включить в обработку все пакеты.

Как оказалось в @auto-it/core в методе getLernaPackages(packages/core/src/utils/get-lerna-packages.ts) была логика фильтрующая пакеты по полю private:

   if (version !== "MISSING" && isPrivate !== "PRIVATE") {
      packages.push({ path: packagePath, name, version });
    }

C помощью patch-package сделал патчи для изменения этой логики.

В этом commit из песочнице можно посмотреть как это работает.

Запуск локально проекта auto next --dry-run (Report what command will do but do not actually do anything)

при изменениях в пакете plasma-web:

Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.



🐛 Bug Fix

⚠️ Pushed to dev

Authors: 3

use this package for patching @auto-it/core and @auto-it/npm
add "includesPrivatePackage" flag
@Yakutoc Yakutoc self-assigned this Sep 20, 2023
@Yakutoc Yakutoc force-pushed the ci-improve-update-version branch from dcf5f67 to d38e6c0 Compare September 20, 2023 05:42
@Yakutoc Yakutoc force-pushed the ci-improve-update-version branch from bf6fc4d to 3fd894d Compare September 20, 2023 06:04
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@Yakutoc Yakutoc force-pushed the ci-improve-update-version branch 2 times, most recently from 8d3df6a to fab9ea0 Compare September 20, 2023 06:59
@Yakutoc Yakutoc marked this pull request as ready for review September 20, 2023 07:36
@Yakutoc Yakutoc force-pushed the ci-improve-update-version branch from 93b7a13 to fab9ea0 Compare September 20, 2023 07:37
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-734/

@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Sep 20, 2023
@@ -30,9 +30,9 @@
"@docusaurus/theme-live-codeblock": "2.0.0-beta.6",
"@mdx-js/react": "^1.6.21",
"@salutejs/plasma-docs-ui": "0.138.0",
"@salutejs/plasma-icons": "~1.156.0-dev.0",
"@salutejs/plasma-tokens": "~1.60.0-dev.0",
"@salutejs/plasma-ui": "~1.203.0-dev.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а тут будет dev после влития?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yeti-or Да, после того как будут выпущены RC версии этих пакетов.

Сейчас у этих пакетов - latest

@Yakutoc Yakutoc added this pull request to the merge queue Sep 20, 2023
Merged via the queue into dev with commit 0599d52 Sep 20, 2023
32 checks passed
@Yakutoc Yakutoc deleted the ci-improve-update-version branch September 20, 2023 10:20
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

3 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

2 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants