plasma-web: Pass `ref` to DropdownItem #769

Yakutoc · 2023-09-25T08:45:37Z

Release Notes

Добавлена возможность использовать свойство ref для компонента DropdownItem

🐤 Download canary assets:

borderRadius

borderRadius_default_react-native--canary.769.6310497681.ts
borderRadius_plasma_b2c_react-native--canary.769.6310497681.ts
borderRadius_plasma_web_react-native--canary.769.6310497681.ts
borderRadius_sberHealth_react-native--canary.769.6310497681.ts
borderRadius_sbermarket_business_react-native--canary.769.6310497681.ts
borderRadius_sbermarket_metro_react-native--canary.769.6310497681.ts
borderRadius_sbermarket_react-native--canary.769.6310497681.ts
borderRadius_sbermarket_selgros_react-native--canary.769.6310497681.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.769.6310497681.ts
borderRadius_sberonline_react-native--canary.769.6310497681.ts
borderRadius_sberprime_react-native--canary.769.6310497681.ts
borderRadius_stylesSalute_react-native--canary.769.6310497681.ts

color

color_default_ios-swift--canary.769.6310497681.swift
color_default_kotlin--canary.769.6310497681.kt
color_default_react-native--canary.769.6310497681.ts
color_default_xml--canary.769.6310497681.xml
color_plasma_b2c_ios-swift--canary.769.6310497681.swift
color_plasma_b2c_kotlin--canary.769.6310497681.kt
color_plasma_b2c_react-native--canary.769.6310497681.ts
color_plasma_b2c_xml--canary.769.6310497681.xml
color_plasma_web_ios-swift--canary.769.6310497681.swift
color_plasma_web_kotlin--canary.769.6310497681.kt
color_plasma_web_react-native--canary.769.6310497681.ts
color_plasma_web_xml--canary.769.6310497681.xml
color_sberHealth_ios-swift--canary.769.6310497681.swift
color_sberHealth_kotlin--canary.769.6310497681.kt
color_sberHealth_react-native--canary.769.6310497681.ts
color_sberHealth_xml--canary.769.6310497681.xml
color_sbermarket_business_ios-swift--canary.769.6310497681.swift
color_sbermarket_business_kotlin--canary.769.6310497681.kt
color_sbermarket_business_react-native--canary.769.6310497681.ts
color_sbermarket_business_xml--canary.769.6310497681.xml
color_sbermarket_ios-swift--canary.769.6310497681.swift
color_sbermarket_kotlin--canary.769.6310497681.kt
color_sbermarket_metro_ios-swift--canary.769.6310497681.swift
color_sbermarket_metro_kotlin--canary.769.6310497681.kt
color_sbermarket_metro_react-native--canary.769.6310497681.ts
color_sbermarket_metro_xml--canary.769.6310497681.xml
color_sbermarket_react-native--canary.769.6310497681.ts
color_sbermarket_selgros_ios-swift--canary.769.6310497681.swift
color_sbermarket_selgros_kotlin--canary.769.6310497681.kt
color_sbermarket_selgros_react-native--canary.769.6310497681.ts
color_sbermarket_selgros_xml--canary.769.6310497681.xml
color_sbermarket_wlbusiness_ios-swift--canary.769.6310497681.swift
color_sbermarket_wlbusiness_kotlin--canary.769.6310497681.kt
color_sbermarket_wlbusiness_react-native--canary.769.6310497681.ts
color_sbermarket_wlbusiness_xml--canary.769.6310497681.xml
color_sbermarket_xml--canary.769.6310497681.xml
color_sberonline_ios-swift--canary.769.6310497681.swift
color_sberonline_kotlin--canary.769.6310497681.kt
color_sberonline_react-native--canary.769.6310497681.ts
color_sberonline_xml--canary.769.6310497681.xml
color_sberprime_ios-swift--canary.769.6310497681.swift
color_sberprime_kotlin--canary.769.6310497681.kt
color_sberprime_react-native--canary.769.6310497681.ts
color_sberprime_xml--canary.769.6310497681.xml
color_stylesSalute_ios-swift--canary.769.6310497681.swift
color_stylesSalute_kotlin--canary.769.6310497681.kt
color_stylesSalute_react-native--canary.769.6310497681.ts
color_stylesSalute_xml--canary.769.6310497681.xml

shadow

shadow_default_react-native--canary.769.6310497681.ts
shadow_plasma_b2c_react-native--canary.769.6310497681.ts
shadow_plasma_web_react-native--canary.769.6310497681.ts
shadow_sberHealth_react-native--canary.769.6310497681.ts
shadow_sbermarket_business_react-native--canary.769.6310497681.ts
shadow_sbermarket_metro_react-native--canary.769.6310497681.ts
shadow_sbermarket_react-native--canary.769.6310497681.ts
shadow_sbermarket_selgros_react-native--canary.769.6310497681.ts
shadow_sbermarket_wlbusiness_react-native--canary.769.6310497681.ts
shadow_sberonline_react-native--canary.769.6310497681.ts
shadow_sberprime_react-native--canary.769.6310497681.ts
shadow_stylesSalute_react-native--canary.769.6310497681.ts

spacing

spacing_default_react-native--canary.769.6310497681.ts
spacing_plasma_b2c_react-native--canary.769.6310497681.ts
spacing_plasma_web_react-native--canary.769.6310497681.ts
spacing_sberHealth_react-native--canary.769.6310497681.ts
spacing_sbermarket_business_react-native--canary.769.6310497681.ts
spacing_sbermarket_metro_react-native--canary.769.6310497681.ts
spacing_sbermarket_react-native--canary.769.6310497681.ts
spacing_sbermarket_selgros_react-native--canary.769.6310497681.ts
spacing_sbermarket_wlbusiness_react-native--canary.769.6310497681.ts
spacing_sberonline_react-native--canary.769.6310497681.ts
spacing_sberprime_react-native--canary.769.6310497681.ts
spacing_stylesSalute_react-native--canary.769.6310497681.ts

typo

typo_mage_ios-swift--canary.769.6310497681.swift
typo_mage_kotlin--canary.769.6310497681.kt
typo_mage_react-native--canary.769.6310497681.ts
typo_plasma_ios-swift--canary.769.6310497681.swift
typo_plasma_kotlin--canary.769.6310497681.kt
typo_plasma_react-native--canary.769.6310497681.ts
typo_ruler_ios-swift--canary.769.6310497681.swift
typo_ruler_kotlin--canary.769.6310497681.kt
typo_ruler_react-native--canary.769.6310497681.ts
typo_sage_ios-swift--canary.769.6310497681.swift
typo_sage_kotlin--canary.769.6310497681.kt
typo_sage_react-native--canary.769.6310497681.ts
typo_sbermarket_ios-swift--canary.769.6310497681.swift
typo_sbermarket_kotlin--canary.769.6310497681.kt
typo_sbermarket_react-native--canary.769.6310497681.ts
typo_soulmate_ios-swift--canary.769.6310497681.swift
typo_soulmate_kotlin--canary.769.6310497681.kt
typo_soulmate_react-native--canary.769.6310497681.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Version

Published prerelease version: @salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Changelog

Release Notes

plasma-web: Pass `ref` to DropdownItem (#769)

Добавлена возможность использовать свойство ref для компонента DropdownItem

plasma-infra: Update version (#770)

Выключили sync package-lock's файлов для приватных пакетов.

What/why Changed

При попытке установить приватный пакет, получаем ошибку 404 - Not found.

Поэтому принято решение не запускать npm i --package-lock-only для приватнных пакетов.

Добавлен флаг --legacy-peer-deps что бы исключить ошибки:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @salutejs/[email protected]
npm ERR! Found: @salutejs/[email protected]
npm ERR! node_modules/@salutejs/plasma-icons
npm ERR!   @salutejs/plasma-icons@"1.162.0-dev.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @salutejs/plasma-icons@"^1.0.0" from @salutejs/[email protected]
npm ERR! node_modules/@salutejs/plasma-b2c
npm ERR!   @salutejs/plasma-b2c@"1.228.0-dev.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

plasma-infra: Update private packages version with @auto-it (#734)

Включили обновление версий для всех пакетов, включая приватные.

What/why Changed

Сделали патчи для @auto-it/core и @auto-it/npm что бы можно было включить в обработку все пакеты.

Как оказалось в @auto-it/core в методе getLernaPackages(packages/core/src/utils/get-lerna-packages.ts) была логика фильтрующая пакеты по полю private:

   if (version !== "MISSING" && isPrivate !== "PRIVATE") {
      packages.push({ path: packagePath, name, version });
    }

C помощью patch-package сделал патчи для изменения этой логики.

В этом commit из песочнице можно посмотреть как это работает.

Запуск локально проекта auto next --dry-run (Report what command will do but do not actually do anything)

при изменениях в пакете plasma-web:

@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.

🚀 Enhancement

feat(plasma-theme-builder): Update building tokens for new tokens value #729 (@neretin-trike)
feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-hope
- feat(plasma-web): add api report #769 (@Yakutoc)
- plasma-web: Pass ref to DropdownItem #769 (@Yakutoc)
@salutejs/plasma-tokens
- feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-tokens-utils
- feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-tokens, @salutejs/plasma-tokens-utils
- feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-new-hope
- feat(plasma-new-hope): 🚀 boostrap && init #691 (@Yeti-or)
@salutejs/plasma-ui
- feat(plasma-ui): add prop "buttonsDirection" #701 (@Yakutoc)

🐛 Bug Fix

plasma-infra: Update version #770 (@Yakutoc)
chore: up perftool #730 (@akhdrv)
ci: new endpoint for perftool-send-report #730 (@akhdrv)
chore: update package-locks (@Salute-Eva)
ci("PR Documentation and Storybook"): delete "HAS_PLASMA_WEBSITE" flag #734 (@Yakutoc)
plasma-infra: Update private packages version with @auto-it #734 (@Yakutoc)
chore(github): add pull request template #685 (@Yakutoc)
ci: fix website main-page in pr #700 (@kayman233)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
- chore: update version #770 (@Yakutoc)
@salutejs/plasma-core
- fix(plasma-ui,plasma-web,plasma-b2c): Button Spinner checked color #748 (@Yeti-or)

⚠️ Pushed to `dev`

Update versions (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-tokens-b2b, @salutejs/plasma-tokens-b2c, @salutejs/plasma-tokens-web, @salutejs/plasma-tokens, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-cy-utils, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-tokens-web, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
- chore: update package-locks (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
- Update versions (@Salute-Eva)
@salutejs/plasma-new-hope
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)
@salutejs/plasma-temple, @salutejs/plasma-ui
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)

Authors: 6

@kayman233
@Salute-Eva
Alex Czech (@Yakutoc)
Artem Khaydarov (@akhdrv)
neretinaa (@neretin-trike)
Vasiliy (@Yeti-or)

Salute-Eva · 2023-09-25T08:48:49Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-769/

Salute-Eva · 2023-09-25T08:58:33Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-769/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-769/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-769/web-storybook/

website/plasma-web-docs/docs/components/Dropdown.mdx

Salute-Eva · 2023-09-26T09:09:43Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-769/

Salute-Eva · 2023-09-26T09:30:49Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-769/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-769/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-769/web-storybook/

Salute-Eva · 2023-09-26T10:07:23Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-09-26T10:07:26Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Yakutoc added the plasma-web label Sep 25, 2023

Yakutoc self-assigned this Sep 25, 2023

Yakutoc marked this pull request as ready for review September 25, 2023 09:06

Yakutoc requested review from Yeti-or, neretin-trike and kayman233 as code owners September 25, 2023 09:06

kayman233 approved these changes Sep 25, 2023

View reviewed changes

Yeti-or approved these changes Sep 25, 2023

View reviewed changes

website/plasma-web-docs/docs/components/Dropdown.mdx Show resolved Hide resolved

neretin-trike approved these changes Sep 25, 2023

View reviewed changes

Yakutoc added this pull request to the merge queue Sep 26, 2023

Yakutoc removed this pull request from the merge queue due to a manual request Sep 26, 2023

Yakutoc added 2 commits September 26, 2023 16:06

feat(plasma-web): pass ref to "DropdownItem"

6c24f27

feat(plasma-web): add api report

8061c09

Yakutoc force-pushed the feat-dropdown-item-pass-ref branch from 95445d6 to 8061c09 Compare September 26, 2023 09:06

Yakutoc added this pull request to the merge queue Sep 26, 2023

Merged via the queue into dev with commit 5aad27f Sep 26, 2023
20 checks passed

Yakutoc deleted the feat-dropdown-item-pass-ref branch September 26, 2023 09:40

Salute-Eva added the prerelease label Sep 26, 2023

This was referenced Sep 28, 2023

feat(plasma-web/b2c/new-hope): Add Radiobox component with new design and core #775

Merged

feat(plasma-b2c,plasma-web): Button size_xs/xxs #780

Merged

feat(plasma-ui): add labels for time pickers #749

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plasma-web: Pass `ref` to DropdownItem #769

plasma-web: Pass `ref` to DropdownItem #769

Yakutoc commented Sep 25, 2023 •

edited by Salute-Eva

Loading

Salute-Eva commented Sep 25, 2023

Salute-Eva commented Sep 25, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

plasma-web: Pass ref to DropdownItem #769

plasma-web: Pass ref to DropdownItem #769

Conversation

Yakutoc commented Sep 25, 2023 • edited by Salute-Eva Loading

Release Notes

Version

Release Notes

plasma-web: Pass ref to DropdownItem (#769)

plasma-infra: Update version (#770)

What/why Changed

plasma-infra: Update private packages version with @auto-it (#734)

What/why Changed

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to dev

Authors: 6

Salute-Eva commented Sep 25, 2023

Salute-Eva commented Sep 25, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

plasma-web: Pass `ref` to DropdownItem #769

plasma-web: Pass `ref` to DropdownItem #769

Yakutoc commented Sep 25, 2023 •

edited by Salute-Eva

Loading

plasma-web: Pass `ref` to DropdownItem (#769)

⚠️ Pushed to `dev`