feat(plasma-web, plasma-b2c): Popover component #732

kayman233 · 2023-09-19T19:24:48Z

Компонент Popup - deprecated

Добавлен компонент Popover.
Свойства компонента:

isOpen: boolean - Открыто ли окно.
trigger?: 'hover' | 'click' - Способ открытия всплывающего окна - наведение или клик мышью.
placement?: PopoverPlacement | Array<PopoverBasicPlacement> - Сторона открытия окна относительно target элемента.
- auto - по умолчанию.
- left, right, top, bottom и их комбинации в виде массива.
offset?: [number, number] - Отступ окна относительно элемента, у которого оно вызвано.
target?: ReactNode - Элемент, рядом с которым произойдет вызов всплывающего окна.
children?: React.ReactNode - Контент всплывающего окна.
onToggle?: (isOpen: boolean, event: SyntheticEvent | Event) => void - Событие сворачивания/разворачивания всплывающего окна.
arrow?: ReactNode - Стрелка над элементом.
isFocusTrapped?: boolean - Блокировать ли фокус на всплывающем окне.
closeOnOverlayClick?: boolean - Закрывать окно при нажатии вне области окна(по умолчанию true).
closeOnEsc?: boolean - Закрывать окно при нажатии ESC(по умолчанию true).

Текущий API:

<Popover 
    isOpen={isOpen}
    onToggle={() => setIsOpen(false)}
    target={<Button>Toggle popover</Button>}
    placement='bottom'
    arrow={<Arrow/>}
>
    Hello World of Plasma
</Popover>

Добавлена story у storybook для компонента.

🐤 Download canary assets:

borderRadius

borderRadius_default_react-native--canary.732.6322248227.ts
borderRadius_plasma_b2c_react-native--canary.732.6322248227.ts
borderRadius_plasma_web_react-native--canary.732.6322248227.ts
borderRadius_sberHealth_react-native--canary.732.6322248227.ts
borderRadius_sbermarket_business_react-native--canary.732.6322248227.ts
borderRadius_sbermarket_metro_react-native--canary.732.6322248227.ts
borderRadius_sbermarket_react-native--canary.732.6322248227.ts
borderRadius_sbermarket_selgros_react-native--canary.732.6322248227.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.732.6322248227.ts
borderRadius_sberonline_react-native--canary.732.6322248227.ts
borderRadius_sberprime_react-native--canary.732.6322248227.ts
borderRadius_stylesSalute_react-native--canary.732.6322248227.ts

color

color_default_ios-swift--canary.732.6322248227.swift
color_default_kotlin--canary.732.6322248227.kt
color_default_react-native--canary.732.6322248227.ts
color_default_xml--canary.732.6322248227.xml
color_plasma_b2c_ios-swift--canary.732.6322248227.swift
color_plasma_b2c_kotlin--canary.732.6322248227.kt
color_plasma_b2c_react-native--canary.732.6322248227.ts
color_plasma_b2c_xml--canary.732.6322248227.xml
color_plasma_web_ios-swift--canary.732.6322248227.swift
color_plasma_web_kotlin--canary.732.6322248227.kt
color_plasma_web_react-native--canary.732.6322248227.ts
color_plasma_web_xml--canary.732.6322248227.xml
color_sberHealth_ios-swift--canary.732.6322248227.swift
color_sberHealth_kotlin--canary.732.6322248227.kt
color_sberHealth_react-native--canary.732.6322248227.ts
color_sberHealth_xml--canary.732.6322248227.xml
color_sbermarket_business_ios-swift--canary.732.6322248227.swift
color_sbermarket_business_kotlin--canary.732.6322248227.kt
color_sbermarket_business_react-native--canary.732.6322248227.ts
color_sbermarket_business_xml--canary.732.6322248227.xml
color_sbermarket_ios-swift--canary.732.6322248227.swift
color_sbermarket_kotlin--canary.732.6322248227.kt
color_sbermarket_metro_ios-swift--canary.732.6322248227.swift
color_sbermarket_metro_kotlin--canary.732.6322248227.kt
color_sbermarket_metro_react-native--canary.732.6322248227.ts
color_sbermarket_metro_xml--canary.732.6322248227.xml
color_sbermarket_react-native--canary.732.6322248227.ts
color_sbermarket_selgros_ios-swift--canary.732.6322248227.swift
color_sbermarket_selgros_kotlin--canary.732.6322248227.kt
color_sbermarket_selgros_react-native--canary.732.6322248227.ts
color_sbermarket_selgros_xml--canary.732.6322248227.xml
color_sbermarket_wlbusiness_ios-swift--canary.732.6322248227.swift
color_sbermarket_wlbusiness_kotlin--canary.732.6322248227.kt
color_sbermarket_wlbusiness_react-native--canary.732.6322248227.ts
color_sbermarket_wlbusiness_xml--canary.732.6322248227.xml
color_sbermarket_xml--canary.732.6322248227.xml
color_sberonline_ios-swift--canary.732.6322248227.swift
color_sberonline_kotlin--canary.732.6322248227.kt
color_sberonline_react-native--canary.732.6322248227.ts
color_sberonline_xml--canary.732.6322248227.xml
color_sberprime_ios-swift--canary.732.6322248227.swift
color_sberprime_kotlin--canary.732.6322248227.kt
color_sberprime_react-native--canary.732.6322248227.ts
color_sberprime_xml--canary.732.6322248227.xml
color_stylesSalute_ios-swift--canary.732.6322248227.swift
color_stylesSalute_kotlin--canary.732.6322248227.kt
color_stylesSalute_react-native--canary.732.6322248227.ts
color_stylesSalute_xml--canary.732.6322248227.xml

shadow

shadow_default_react-native--canary.732.6322248227.ts
shadow_plasma_b2c_react-native--canary.732.6322248227.ts
shadow_plasma_web_react-native--canary.732.6322248227.ts
shadow_sberHealth_react-native--canary.732.6322248227.ts
shadow_sbermarket_business_react-native--canary.732.6322248227.ts
shadow_sbermarket_metro_react-native--canary.732.6322248227.ts
shadow_sbermarket_react-native--canary.732.6322248227.ts
shadow_sbermarket_selgros_react-native--canary.732.6322248227.ts
shadow_sbermarket_wlbusiness_react-native--canary.732.6322248227.ts
shadow_sberonline_react-native--canary.732.6322248227.ts
shadow_sberprime_react-native--canary.732.6322248227.ts
shadow_stylesSalute_react-native--canary.732.6322248227.ts

spacing

spacing_default_react-native--canary.732.6322248227.ts
spacing_plasma_b2c_react-native--canary.732.6322248227.ts
spacing_plasma_web_react-native--canary.732.6322248227.ts
spacing_sberHealth_react-native--canary.732.6322248227.ts
spacing_sbermarket_business_react-native--canary.732.6322248227.ts
spacing_sbermarket_metro_react-native--canary.732.6322248227.ts
spacing_sbermarket_react-native--canary.732.6322248227.ts
spacing_sbermarket_selgros_react-native--canary.732.6322248227.ts
spacing_sbermarket_wlbusiness_react-native--canary.732.6322248227.ts
spacing_sberonline_react-native--canary.732.6322248227.ts
spacing_sberprime_react-native--canary.732.6322248227.ts
spacing_stylesSalute_react-native--canary.732.6322248227.ts

typo

typo_mage_ios-swift--canary.732.6322248227.swift
typo_mage_kotlin--canary.732.6322248227.kt
typo_mage_react-native--canary.732.6322248227.ts
typo_plasma_ios-swift--canary.732.6322248227.swift
typo_plasma_kotlin--canary.732.6322248227.kt
typo_plasma_react-native--canary.732.6322248227.ts
typo_ruler_ios-swift--canary.732.6322248227.swift
typo_ruler_kotlin--canary.732.6322248227.kt
typo_ruler_react-native--canary.732.6322248227.ts
typo_sage_ios-swift--canary.732.6322248227.swift
typo_sage_kotlin--canary.732.6322248227.kt
typo_sage_react-native--canary.732.6322248227.ts
typo_sbermarket_ios-swift--canary.732.6322248227.swift
typo_sbermarket_kotlin--canary.732.6322248227.kt
typo_sbermarket_react-native--canary.732.6322248227.ts
typo_soulmate_ios-swift--canary.732.6322248227.swift
typo_soulmate_kotlin--canary.732.6322248227.kt
typo_soulmate_react-native--canary.732.6322248227.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Version

Published prerelease version: @salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Changelog

Release Notes

plasma-web: Pass `ref` to DropdownItem (#769)

Добавлена возможность использовать свойство ref для компонента DropdownItem

plasma-infra: Update version (#770)

Выключили sync package-lock's файлов для приватных пакетов.

What/why Changed

При попытке установить приватный пакет, получаем ошибку 404 - Not found.

Поэтому принято решение не запускать npm i --package-lock-only для приватнных пакетов.

Добавлен флаг --legacy-peer-deps что бы исключить ошибки:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @salutejs/[email protected]
npm ERR! Found: @salutejs/[email protected]
npm ERR! node_modules/@salutejs/plasma-icons
npm ERR!   @salutejs/plasma-icons@"1.162.0-dev.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @salutejs/plasma-icons@"^1.0.0" from @salutejs/[email protected]
npm ERR! node_modules/@salutejs/plasma-b2c
npm ERR!   @salutejs/plasma-b2c@"1.228.0-dev.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

plasma-infra: Update private packages version with @auto-it (#734)

Включили обновление версий для всех пакетов, включая приватные.

What/why Changed

Сделали патчи для @auto-it/core и @auto-it/npm что бы можно было включить в обработку все пакеты.

Как оказалось в @auto-it/core в методе getLernaPackages(packages/core/src/utils/get-lerna-packages.ts) была логика фильтрующая пакеты по полю private:

   if (version !== "MISSING" && isPrivate !== "PRIVATE") {
      packages.push({ path: packagePath, name, version });
    }

C помощью patch-package сделал патчи для изменения этой логики.

В этом commit из песочнице можно посмотреть как это работает.

Запуск локально проекта auto next --dry-run (Report what command will do but do not actually do anything)

при изменениях в пакете plasma-web:

@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.

🚀 Enhancement

feat(plasma-theme-builder): Update building tokens for new tokens value #729 (@neretin-trike)
feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-web
- fix(plasma-core): Popover refactoring #732 (@kayman233)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-web
- feat(plasma-web, plasma-b2c): Popover component #732 (@kayman233)
@salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-web
- feat(plasma-web, plasma-b2c): Popover component #732 (@kayman233)
@salutejs/plasma-hope
- feat(plasma-web): add api report #769 (@Yakutoc)
- plasma-web: Pass ref to DropdownItem #769 (@Yakutoc)
@salutejs/plasma-tokens
- feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-tokens-utils
- feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-tokens, @salutejs/plasma-tokens-utils
- feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
@salutejs/plasma-new-hope
- feat(plasma-new-hope): 🚀 boostrap && init #691 (@Yeti-or)
@salutejs/plasma-ui
- feat(plasma-ui): add prop "buttonsDirection" #701 (@Yakutoc)

🐛 Bug Fix

plasma-infra: Update version #770 (@Yakutoc)
chore: up perftool #730 (@akhdrv)
ci: new endpoint for perftool-send-report #730 (@akhdrv)
chore: update package-locks (@Salute-Eva)
ci("PR Documentation and Storybook"): delete "HAS_PLASMA_WEBSITE" flag #734 (@Yakutoc)
plasma-infra: Update private packages version with @auto-it #734 (@Yakutoc)
chore(github): add pull request template #685 (@Yakutoc)
ci: fix website main-page in pr #700 (@kayman233)
@salutejs/plasma-core, @salutejs/plasma-hope
- feat(plasma-web, plasma-b2c): Popover component #732 (@kayman233)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
- chore: update version #770 (@Yakutoc)
@salutejs/plasma-core
- fix(plasma-ui,plasma-web,plasma-b2c): Button Spinner checked color #748 (@Yeti-or)

⚠️ Pushed to `dev`

Update versions (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-hope, @salutejs/plasma-web
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-tokens-b2b, @salutejs/plasma-tokens-b2c, @salutejs/plasma-tokens-web, @salutejs/plasma-tokens, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-cy-utils, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-tokens-web, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
- chore: update package-locks (@Salute-Eva)
@salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
- Update versions (@Salute-Eva)
@salutejs/plasma-new-hope
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)
@salutejs/plasma-temple, @salutejs/plasma-ui
- chore: update package-locks (@Salute-Eva)
- Update versions (@Salute-Eva)

Authors: 6

@kayman233
@Salute-Eva
Alex Czech (@Yakutoc)
Artem Khaydarov (@akhdrv)
neretinaa (@neretin-trike)
Vasiliy (@Yeti-or)

Salute-Eva · 2023-09-19T19:27:48Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-19T19:42:55Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-19T19:49:00Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-20T06:51:40Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-20T07:08:26Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-20T07:18:16Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-20T11:03:09Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-20T11:15:53Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-20T11:21:28Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-21T06:35:38Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-21T06:48:35Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-21T06:50:40Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-21T09:50:02Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-21T10:06:52Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-21T10:43:42Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

packages/plasma-core/src/components/Popover/Popover.tsx

Salute-Eva · 2023-09-22T06:46:23Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-22T07:06:25Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-22T07:36:21Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-22T09:51:30Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-22T10:02:31Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-26T11:29:35Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-26T11:33:41Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Yeti-or

Компонент Popup - deprecated

Добавлен компонент Popover, основанный на Popup.

не совсем понятно почему Popup deprecated если на нем основан Popover

<Popover target={<Button>Toggle popover</Button>} placement='bottom' arrow={<Arrow/>}>
	 Hello World of Plasma
</Popover>

давай добавим в премер state: isOpen и onToggle => setState

placement?: PopoverPlacement | Array - позиция на экране
это же сторона раскрытия наверно а не совсем позиция ?

trigger: 'hover' | 'click' - Сп ??
я же правильно понимаю что программно можно тоже его вызывать через isOpen тогда trigger опционален ?

Yeti-or · 2023-09-26T13:43:44Z

packages/plasma-core/src/hooks/index.ts

@@ -3,3 +3,4 @@ export { useForkRef } from './useForkRef';
 export { useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect';
 export { useUniqId } from './useUniqId';
 export { useResizeObserver } from './useResizeObserver';
+export { useFocusTrap } from './useFocusTrap';


А почему мы useFocusTrap выносим в plasma-core ?

а я кажется понял, типа Popup в core поэтому и Popover туда положили

да, именно

Yeti-or · 2023-09-26T13:50:50Z

packages/plasma-web/src/components/Popover/Popover.stories.tsx

+    decorators: [InSpacingDecorator],
+} as Meta;
+
+const StyledArrow = styled.div`


А мы не хотим это положить внутрь либы ?

типо добавить дефолтную стрелочку? Или дать отдельно сам компонент этот?
В целом я ее так выносил, потому что не хотел особо водить никак со стилями(у нас тут у стрелки и контейнера одинаковый background)

давай отдельно тогда задачу на стрелку замутим

Yeti-or · 2023-09-26T13:54:00Z

packages/plasma-web/src/components/Popover/Popover.stories.tsx

+    trigger: 'click',
+    closeOnOverlayClick: true,
+    closeOnEsc: true,
+    isFocusTrapped: false,


может true по умолчанию ?

Yeti-or · 2023-09-26T13:56:40Z

packages/plasma-core/src/components/Popover/Popover.tsx

+ * и вызова по клику либо ховеру.
+ */
+export const Popover = memo<PopoverProps & RefAttributes<HTMLDivElement>>(
+    React.forwardRef<HTMLDivElement, PopoverProps>(


А зачем нам реф на popover ?

У нас как-то была задача по добавлению рефа для Тултипа, поэтому подумал, что логично и на Popover навесить

🤔 наверно норм тогда

Yeti-or · 2023-09-26T13:57:22Z

packages/plasma-core/src/components/Popover/Popover.tsx

+                arrow,
+                placement = 'auto',
+                offset = [0, 0],
+                isFocusTrapped = false,


не хотим по умолчанию true ?

Salute-Eva · 2023-09-26T18:32:20Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-26T18:47:16Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-26T18:49:51Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Yeti-or · 2023-09-26T22:31:58Z

packages/plasma-core/src/components/Popover/Popover.tsx

+    /**
+     * Способ всплывающего окна - наведение или клик мышью.
+     */
+    trigger: 'hover' | 'click';


не понял только про trigger обязательный ли он

не обязателен. А на коммент выше, то да, можно программно открывать через isOpen

Yeti-or · 2023-09-26T22:34:50Z

packages/plasma-core/src/components/Popover/Popover.tsx

+    /**
+     * Всплывающее окно раскрыто или нет.
+     */
+    isOpen?: boolean;


а isOpen опционален ?

нам не обязательно иметь state ?

сделал обязательным

Salute-Eva · 2023-09-27T06:32:15Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-732/

Salute-Eva · 2023-09-27T06:44:57Z

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

Salute-Eva · 2023-09-27T06:47:21Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-732/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-732/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-732/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-732/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-732/temple-storybook/

Salute-Eva · 2023-09-27T09:02:30Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-09-27T09:02:33Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-09-27T09:02:36Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-09-27T09:02:38Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

kayman233 force-pushed the kayman233/popover.PLASMA-1818 branch from 3f35f24 to 6763e7d Compare September 20, 2023 10:59

kayman233 force-pushed the kayman233/popover.PLASMA-1818 branch from 6763e7d to be6269d Compare September 21, 2023 06:32

kayman233 force-pushed the kayman233/popover.PLASMA-1818 branch from be6269d to 8805bdf Compare September 21, 2023 09:47

kayman233 marked this pull request as ready for review September 21, 2023 10:04

kayman233 requested review from Yeti-or, neretin-trike and Yakutoc as code owners September 21, 2023 10:04

Yakutoc reviewed Sep 22, 2023

View reviewed changes

packages/plasma-core/src/components/Popover/Popover.tsx Outdated Show resolved Hide resolved

Yakutoc reviewed Sep 22, 2023

View reviewed changes

packages/plasma-core/src/components/Popover/Popover.tsx Show resolved Hide resolved

kayman233 force-pushed the kayman233/popover.PLASMA-1818 branch from ac9b1bb to e9a82ba Compare September 22, 2023 09:47

Yeti-or reviewed Sep 26, 2023

View reviewed changes

kayman233 force-pushed the kayman233/popover.PLASMA-1818 branch from ba203af to 2366fa8 Compare September 26, 2023 18:29

Yeti-or reviewed Sep 26, 2023

View reviewed changes

fix(plasma-core): Popover refactoring

21ff51f

kayman233 force-pushed the kayman233/popover.PLASMA-1818 branch from 2366fa8 to 21ff51f Compare September 27, 2023 06:28

Yeti-or approved these changes Sep 27, 2023

View reviewed changes

kayman233 added this pull request to the merge queue Sep 27, 2023

Merged via the queue into dev with commit 6cbfd2e Sep 27, 2023

kayman233 deleted the kayman233/popover.PLASMA-1818 branch September 27, 2023 08:26

Salute-Eva added the prerelease label Sep 27, 2023

feat(plasma-web, plasma-b2c): Popover component #732

feat(plasma-web, plasma-b2c): Popover component #732

Conversation

kayman233 commented Sep 19, 2023 • edited by Salute-Eva Loading

Version

Release Notes

plasma-web: Pass ref to DropdownItem (#769)

plasma-infra: Update version (#770)

What/why Changed

plasma-infra: Update private packages version with @auto-it (#734)

What/why Changed

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to dev

Authors: 6

Salute-Eva commented Sep 19, 2023

Salute-Eva commented Sep 19, 2023

Salute-Eva commented Sep 19, 2023

Salute-Eva commented Sep 20, 2023

Salute-Eva commented Sep 20, 2023

Salute-Eva commented Sep 20, 2023

Salute-Eva commented Sep 20, 2023

Salute-Eva commented Sep 20, 2023

Salute-Eva commented Sep 20, 2023

Salute-Eva commented Sep 21, 2023

Salute-Eva commented Sep 21, 2023

Salute-Eva commented Sep 21, 2023

Salute-Eva commented Sep 21, 2023

Salute-Eva commented Sep 21, 2023

Salute-Eva commented Sep 21, 2023

Salute-Eva commented Sep 22, 2023

Salute-Eva commented Sep 22, 2023

Salute-Eva commented Sep 22, 2023

Salute-Eva commented Sep 22, 2023

Salute-Eva commented Sep 22, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Yeti-or left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Salute-Eva commented Sep 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Salute-Eva commented Sep 27, 2023

Salute-Eva commented Sep 27, 2023

Salute-Eva commented Sep 27, 2023

Salute-Eva commented Sep 27, 2023

Salute-Eva commented Sep 27, 2023

Salute-Eva commented Sep 27, 2023

Salute-Eva commented Sep 27, 2023

kayman233 commented Sep 19, 2023 •

edited by Salute-Eva

Loading

plasma-web: Pass `ref` to DropdownItem (#769)

⚠️ Pushed to `dev`