-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plasma-web/b2c/new-hope): Add Link
component with new design and core
#696
Conversation
2f4f2bd
to
d5bfda9
Compare
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
d5bfda9
to
8a7244e
Compare
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
8a7244e
to
641b25f
Compare
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
1 similar comment
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
641b25f
to
a4a21d3
Compare
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
a4a21d3
to
943b195
Compare
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
@@ -9,4 +9,6 @@ perl -p -i -e "s/import { styled } from '\@linaria\/react'/import styled from 's | |||
perl -p -i -e "s/import { css } from '\@linaria\/core'/import { css } from 'styled-components'/g" $files | |||
|
|||
rm -rf src-sc/engines/linaria.tsx | |||
perl -p -i -e "s/linaria/styled-components/g" src-sc/engines/index.ts | |||
perl -p -i -e "s/import { css as cssLibrary } from '\@linaria\/core'/import { css as cssLibrary } from 'styled-components'/g" src-sc/engines/index.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neretin-trike Можем добавить небольшой комментарий что/зачем делает скрипт?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вообще этот файл нужен для того, чтобы после сборки подменять все импорты из @linaria
на импорты из styled-components
. Это нужно для того поддерживать сборку компонент сразу для двух систем (в зависимости от того, какая используется на проекте пользователя)
943b195
to
4ece2f2
Compare
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
e9221f5
to
c0cfcdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/ |
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-696/ |
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
2 similar comments
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
5 similar comments
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
Добавлена типизация для движка пакета
@salutejs/plasma-new-hope
.Добавлена реализация компонента
Link
в новой архитектуре.Добавлены сборки компонента для новых тем plasma_web и plasma_b2c с новыми пропсами:
view
,disabled
,focused
.Добавлены сборки компонента для старых библиотек
@salutejs/plasma-web
,@salutejs/plasma-b2c
.Удалён компонент из
@salutejs/plasma-hope
.#585
🐤 Download canary assets:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
Version
Published prerelease version:
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
Changelog
Release Notes
plasma-web: Pass
ref
to DropdownItem (#769)Добавлена возможность использовать свойство
ref
для компонентаDropdownItem
plasma-infra: Update version (#770)
Выключили sync package-lock's файлов для приватных пакетов.
What/why Changed
При попытке установить приватный пакет, получаем ошибку 404 - Not found.
Поэтому принято решение не запускать
npm i --package-lock-only
для приватнных пакетов.Добавлен флаг
--legacy-peer-deps
что бы исключить ошибки:plasma-infra: Update private packages version with @auto-it (#734)
Включили обновление версий для всех пакетов, включая приватные.
What/why Changed
Сделали патчи для
@auto-it/core
и@auto-it/npm
что бы можно было включить в обработку все пакеты.Как оказалось в
@auto-it/core
в методеgetLernaPackages(packages/core/src/utils/get-lerna-packages.ts)
была логика фильтрующая пакеты по полюprivate
:C помощью
patch-package
сделал патчи для изменения этой логики.В этом commit из песочнице можно посмотреть как это работает.
Запуск локально проекта
auto next --dry-run
(Report what command will do but do not actually do anything)при изменениях в пакете
plasma-web
:Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.
🚀 Enhancement
Link
component with new design and core #696 (@neretin-trike)@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-icons
,@salutejs/plasma-temple
,@salutejs/plasma-ui
,@salutejs/plasma-web
,@salutejs/plasma-sb-utils
@salutejs/plasma-new-hope
Link
component with new design and core #696 (@neretin-trike)@salutejs/plasma-hope
Link
component with new design and core #696 (@neretin-trike)ref
to DropdownItem #769 (@Yakutoc)@salutejs/plasma-web
Link
component with new design and core #696 (@neretin-trike)@salutejs/plasma-b2c
Link
component with new design and core #696 (@neretin-trike)@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-web
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-web
@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-web
@salutejs/plasma-tokens
@salutejs/plasma-tokens-utils
@salutejs/plasma-tokens
,@salutejs/plasma-tokens-utils
@salutejs/plasma-ui
🐛 Bug Fix
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-web
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-web
@salutejs/plasma-core
,@salutejs/plasma-hope
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-icons
,@salutejs/plasma-temple
,@salutejs/plasma-ui
,@salutejs/plasma-web
,@salutejs/plasma-sb-utils
@salutejs/plasma-core
dev
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-icons
,@salutejs/plasma-temple
,@salutejs/plasma-ui
,@salutejs/plasma-web
,@salutejs/plasma-sb-utils
@salutejs/plasma-b2c
,@salutejs/plasma-hope
,@salutejs/plasma-web
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-icons
,@salutejs/plasma-temple
,@salutejs/plasma-tokens-b2b
,@salutejs/plasma-tokens-b2c
,@salutejs/plasma-tokens-web
,@salutejs/plasma-tokens
,@salutejs/plasma-ui
,@salutejs/plasma-web
,@salutejs/plasma-cy-utils
,@salutejs/plasma-sb-utils
,@salutejs/plasma-tokens-utils
@salutejs/plasma-b2c
,@salutejs/plasma-core
,@salutejs/plasma-hope
,@salutejs/plasma-icons
,@salutejs/plasma-temple
,@salutejs/plasma-tokens-web
,@salutejs/plasma-ui
,@salutejs/plasma-web
,@salutejs/plasma-sb-utils
,@salutejs/plasma-tokens-utils
@salutejs/plasma-new-hope
@salutejs/plasma-temple
,@salutejs/plasma-ui
Authors: 7