Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plasma-web/b2c/new-hope): Add Link component with new design and core #696

Merged
merged 9 commits into from
Sep 27, 2023

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Sep 13, 2023

Добавлена типизация для движка пакета @salutejs/plasma-new-hope.

Добавлена реализация компонента Link в новой архитектуре.

Добавлены сборки компонента для новых тем plasma_web и plasma_b2c с новыми пропсами: view, disabled, focused.

Добавлены сборки компонента для старых библиотек @salutejs/plasma-web, @salutejs/plasma-b2c.

Удалён компонент из @salutejs/plasma-hope.

#585

🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.696.6325727264.ts
borderRadius_plasma_b2c_react-native--canary.696.6325727264.ts
borderRadius_plasma_web_react-native--canary.696.6325727264.ts
borderRadius_sberHealth_react-native--canary.696.6325727264.ts
borderRadius_sbermarket_business_react-native--canary.696.6325727264.ts
borderRadius_sbermarket_metro_react-native--canary.696.6325727264.ts
borderRadius_sbermarket_react-native--canary.696.6325727264.ts
borderRadius_sbermarket_selgros_react-native--canary.696.6325727264.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.696.6325727264.ts
borderRadius_sberonline_react-native--canary.696.6325727264.ts
borderRadius_sberprime_react-native--canary.696.6325727264.ts
borderRadius_stylesSalute_react-native--canary.696.6325727264.ts
color
color_default_ios-swift--canary.696.6325727264.swift
color_default_kotlin--canary.696.6325727264.kt
color_default_react-native--canary.696.6325727264.ts
color_default_xml--canary.696.6325727264.xml
color_plasma_b2c_ios-swift--canary.696.6325727264.swift
color_plasma_b2c_kotlin--canary.696.6325727264.kt
color_plasma_b2c_react-native--canary.696.6325727264.ts
color_plasma_b2c_xml--canary.696.6325727264.xml
color_plasma_web_ios-swift--canary.696.6325727264.swift
color_plasma_web_kotlin--canary.696.6325727264.kt
color_plasma_web_react-native--canary.696.6325727264.ts
color_plasma_web_xml--canary.696.6325727264.xml
color_sberHealth_ios-swift--canary.696.6325727264.swift
color_sberHealth_kotlin--canary.696.6325727264.kt
color_sberHealth_react-native--canary.696.6325727264.ts
color_sberHealth_xml--canary.696.6325727264.xml
color_sbermarket_business_ios-swift--canary.696.6325727264.swift
color_sbermarket_business_kotlin--canary.696.6325727264.kt
color_sbermarket_business_react-native--canary.696.6325727264.ts
color_sbermarket_business_xml--canary.696.6325727264.xml
color_sbermarket_ios-swift--canary.696.6325727264.swift
color_sbermarket_kotlin--canary.696.6325727264.kt
color_sbermarket_metro_ios-swift--canary.696.6325727264.swift
color_sbermarket_metro_kotlin--canary.696.6325727264.kt
color_sbermarket_metro_react-native--canary.696.6325727264.ts
color_sbermarket_metro_xml--canary.696.6325727264.xml
color_sbermarket_react-native--canary.696.6325727264.ts
color_sbermarket_selgros_ios-swift--canary.696.6325727264.swift
color_sbermarket_selgros_kotlin--canary.696.6325727264.kt
color_sbermarket_selgros_react-native--canary.696.6325727264.ts
color_sbermarket_selgros_xml--canary.696.6325727264.xml
color_sbermarket_wlbusiness_ios-swift--canary.696.6325727264.swift
color_sbermarket_wlbusiness_kotlin--canary.696.6325727264.kt
color_sbermarket_wlbusiness_react-native--canary.696.6325727264.ts
color_sbermarket_wlbusiness_xml--canary.696.6325727264.xml
color_sbermarket_xml--canary.696.6325727264.xml
color_sberonline_ios-swift--canary.696.6325727264.swift
color_sberonline_kotlin--canary.696.6325727264.kt
color_sberonline_react-native--canary.696.6325727264.ts
color_sberonline_xml--canary.696.6325727264.xml
color_sberprime_ios-swift--canary.696.6325727264.swift
color_sberprime_kotlin--canary.696.6325727264.kt
color_sberprime_react-native--canary.696.6325727264.ts
color_sberprime_xml--canary.696.6325727264.xml
color_stylesSalute_ios-swift--canary.696.6325727264.swift
color_stylesSalute_kotlin--canary.696.6325727264.kt
color_stylesSalute_react-native--canary.696.6325727264.ts
color_stylesSalute_xml--canary.696.6325727264.xml
shadow
shadow_default_react-native--canary.696.6325727264.ts
shadow_plasma_b2c_react-native--canary.696.6325727264.ts
shadow_plasma_web_react-native--canary.696.6325727264.ts
shadow_sberHealth_react-native--canary.696.6325727264.ts
shadow_sbermarket_business_react-native--canary.696.6325727264.ts
shadow_sbermarket_metro_react-native--canary.696.6325727264.ts
shadow_sbermarket_react-native--canary.696.6325727264.ts
shadow_sbermarket_selgros_react-native--canary.696.6325727264.ts
shadow_sbermarket_wlbusiness_react-native--canary.696.6325727264.ts
shadow_sberonline_react-native--canary.696.6325727264.ts
shadow_sberprime_react-native--canary.696.6325727264.ts
shadow_stylesSalute_react-native--canary.696.6325727264.ts
spacing
spacing_default_react-native--canary.696.6325727264.ts
spacing_plasma_b2c_react-native--canary.696.6325727264.ts
spacing_plasma_web_react-native--canary.696.6325727264.ts
spacing_sberHealth_react-native--canary.696.6325727264.ts
spacing_sbermarket_business_react-native--canary.696.6325727264.ts
spacing_sbermarket_metro_react-native--canary.696.6325727264.ts
spacing_sbermarket_react-native--canary.696.6325727264.ts
spacing_sbermarket_selgros_react-native--canary.696.6325727264.ts
spacing_sbermarket_wlbusiness_react-native--canary.696.6325727264.ts
spacing_sberonline_react-native--canary.696.6325727264.ts
spacing_sberprime_react-native--canary.696.6325727264.ts
spacing_stylesSalute_react-native--canary.696.6325727264.ts
typo
typo_mage_ios-swift--canary.696.6325727264.swift
typo_mage_kotlin--canary.696.6325727264.kt
typo_mage_react-native--canary.696.6325727264.ts
typo_plasma_ios-swift--canary.696.6325727264.swift
typo_plasma_kotlin--canary.696.6325727264.kt
typo_plasma_react-native--canary.696.6325727264.ts
typo_ruler_ios-swift--canary.696.6325727264.swift
typo_ruler_kotlin--canary.696.6325727264.kt
typo_ruler_react-native--canary.696.6325727264.ts
typo_sage_ios-swift--canary.696.6325727264.swift
typo_sage_kotlin--canary.696.6325727264.kt
typo_sage_react-native--canary.696.6325727264.ts
typo_sbermarket_ios-swift--canary.696.6325727264.swift
typo_sbermarket_kotlin--canary.696.6325727264.kt
typo_sbermarket_react-native--canary.696.6325727264.ts
typo_soulmate_ios-swift--canary.696.6325727264.swift
typo_soulmate_kotlin--canary.696.6325727264.kt
typo_soulmate_react-native--canary.696.6325727264.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Version

Published prerelease version: @salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Changelog

Release Notes

plasma-web: Pass ref to DropdownItem (#769)

Добавлена возможность использовать свойство ref для компонента DropdownItem


plasma-infra: Update version (#770)

Выключили sync package-lock's файлов для приватных пакетов.

What/why Changed

При попытке установить приватный пакет, получаем ошибку 404 - Not found.

Поэтому принято решение не запускать npm i --package-lock-only для приватнных пакетов.

Добавлен флаг --legacy-peer-deps что бы исключить ошибки:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @salutejs/[email protected]
npm ERR! Found: @salutejs/[email protected]
npm ERR! node_modules/@salutejs/plasma-icons
npm ERR!   @salutejs/plasma-icons@"1.162.0-dev.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @salutejs/plasma-icons@"^1.0.0" from @salutejs/[email protected]
npm ERR! node_modules/@salutejs/plasma-b2c
npm ERR!   @salutejs/plasma-b2c@"1.228.0-dev.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

plasma-infra: Update private packages version with @auto-it (#734)

Включили обновление версий для всех пакетов, включая приватные.

What/why Changed

Сделали патчи для @auto-it/core и @auto-it/npm что бы можно было включить в обработку все пакеты.

Как оказалось в @auto-it/core в методе getLernaPackages(packages/core/src/utils/get-lerna-packages.ts) была логика фильтрующая пакеты по полю private:

   if (version !== "MISSING" && isPrivate !== "PRIVATE") {
      packages.push({ path: packagePath, name, version });
    }

C помощью patch-package сделал патчи для изменения этой логики.

В этом commit из песочнице можно посмотреть как это работает.

Запуск локально проекта auto next --dry-run (Report what command will do but do not actually do anything)

при изменениях в пакете plasma-web:

Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.



🚀 Enhancement

  • feat(plasma-web/b2c/new-hope): Add Link component with new design and core #696 (@neretin-trike)
  • feat(plasma-theme-builder): Update building tokens for new tokens value #729 (@neretin-trike)
  • feat(plasma-*): Add support linked tokens from color palette #729 (@neretin-trike)
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
  • @salutejs/plasma-new-hope
    • feat(plasma-web/b2c/new-hope): Add Link component with new design and core #696 (@neretin-trike)
    • feat(plasma-new-hope): 🚀 boostrap && init #691 (@Yeti-or)
  • @salutejs/plasma-hope
  • @salutejs/plasma-web
    • feat(plasma-web/b2c/new-hope): Add Link component with new design and core #696 (@neretin-trike)
  • @salutejs/plasma-b2c
    • feat(plasma-web/b2c/new-hope): Add Link component with new design and core #696 (@neretin-trike)
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-web
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-web
  • @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-web
  • @salutejs/plasma-tokens
  • @salutejs/plasma-tokens-utils
  • @salutejs/plasma-tokens, @salutejs/plasma-tokens-utils
  • @salutejs/plasma-ui
    • feat(plasma-ui): add prop "buttonsDirection" #701 (@Yakutoc)

🐛 Bug Fix

  • docs: update import deprecated darkSber #772 (@azeek21)
  • ci: enable semgrep workflow #738 (@Yakutoc)
  • plasma-infra: Update version #770 (@Yakutoc)
  • chore: up perftool #730 (@akhdrv)
  • ci: new endpoint for perftool-send-report #730 (@akhdrv)
  • chore: update package-locks (@Salute-Eva)
  • ci("PR Documentation and Storybook"): delete "HAS_PLASMA_WEBSITE" flag #734 (@Yakutoc)
  • plasma-infra: Update private packages version with @auto-it #734 (@Yakutoc)
  • chore(github): add pull request template #685 (@Yakutoc)
  • ci: fix website main-page in pr #700 (@kayman233)
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-web
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-web
  • @salutejs/plasma-core, @salutejs/plasma-hope
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
  • @salutejs/plasma-core
    • fix(plasma-ui,plasma-web,plasma-b2c): Button Spinner checked color #748 (@Yeti-or)

⚠️ Pushed to dev

  • Update versions (@Salute-Eva)
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils
  • @salutejs/plasma-b2c, @salutejs/plasma-hope, @salutejs/plasma-web
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-tokens-b2b, @salutejs/plasma-tokens-b2c, @salutejs/plasma-tokens-web, @salutejs/plasma-tokens, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-cy-utils, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
  • @salutejs/plasma-b2c, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-tokens-web, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
  • @salutejs/plasma-new-hope
  • @salutejs/plasma-temple, @salutejs/plasma-ui

Authors: 7

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

@Yakutoc Yakutoc force-pushed the neretinaa/add-new-hope-link branch from 8a7244e to 641b25f Compare September 14, 2023 07:52
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

1 similar comment
@Salute-Eva
Copy link
Contributor

@neretin-trike neretin-trike force-pushed the neretinaa/add-new-hope-link branch from 641b25f to a4a21d3 Compare September 14, 2023 18:45
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

@@ -9,4 +9,6 @@ perl -p -i -e "s/import { styled } from '\@linaria\/react'/import styled from 's
perl -p -i -e "s/import { css } from '\@linaria\/core'/import { css } from 'styled-components'/g" $files

rm -rf src-sc/engines/linaria.tsx
perl -p -i -e "s/linaria/styled-components/g" src-sc/engines/index.ts
perl -p -i -e "s/import { css as cssLibrary } from '\@linaria\/core'/import { css as cssLibrary } from 'styled-components'/g" src-sc/engines/index.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neretin-trike Можем добавить небольшой комментарий что/зачем делает скрипт?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вообще этот файл нужен для того, чтобы после сборки подменять все импорты из @linaria на импорты из styled-components. Это нужно для того поддерживать сборку компонент сразу для двух систем (в зависимости от того, какая используется на проекте пользователя)

@neretin-trike neretin-trike force-pushed the neretinaa/add-new-hope-link branch from 943b195 to 4ece2f2 Compare September 25, 2023 11:50
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

@neretin-trike neretin-trike force-pushed the neretinaa/add-new-hope-link branch from e9221f5 to c0cfcdf Compare September 27, 2023 12:11
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-696/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

@neretin-trike neretin-trike added this pull request to the merge queue Sep 27, 2023
Merged via the queue into dev with commit 4559654 Sep 27, 2023
@neretin-trike neretin-trike deleted the neretinaa/add-new-hope-link branch September 27, 2023 12:57
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

2 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

5 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plasma-web: Link – redesign & refactoring ( PLASMA-2064 )
6 participants