feat(plasma-web/b2c/new-hope): Add Checkbox component with new design and core
#754
Conversation
neretin-trike
requested review from
Yeti-or,
Yakutoc and
kayman233
as code owners
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
985f1de to
ead0243
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
ead0243 to
a666f5b
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
a666f5b to
c9d4247
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
c9d4247 to
ab3483a
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
ab3483a to
547fea9
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
547fea9 to
ce69a73
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
ce69a73 to
9e5def1
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
9e5def1 to
825997c
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
packages/plasma-b2c/src/components/Checkbox/Checkbox.config.tsx
Outdated
Show resolved
Hide resolved
packages/plasma-b2c/src/components/Checkbox/Checkbox.config.tsx
Outdated
Show resolved
Hide resolved
| @@ -183,6 +204,8 @@ Default.args = { | |||
| disabled: false, | |||
| singleLine: false, | |||
| size: 'm', | |||
| view: 'accent', | |||
| focused: true, | |||
There was a problem hiding this comment.
по дефолту же должно врубаться?
There was a problem hiding this comment.
да, оно врубается по дефолту, но тут это нужно, чтобы в сторибуке было значение у контрола проставлено
|
|
||
| input[data-focus-visible-added]:checked + label .checkbox-trigger, | ||
| input[type='checkbox'][data-focus-visible-added]:indeterminate + label .checkbox-trigger { | ||
| ${addFocus('-0.125rem', '0.063rem', 'calc(var(--plasma-checkbox-trigger-border-radius) + 0.125rem)')} |
There was a problem hiding this comment.
ну справедливости ради, в styled-components у нас точно такие же селекторы :D Пока особо нет идей, как это можно сделать (и надо ли?)
packages/plasma-new-hope/src/components/Checkbox/_size/tokens.json
Outdated
Show resolved
Hide resolved
neretin-trike
force-pushed
the
neretinaa/add-new-hope-checkbox
branch
from
825997c to
fdd561c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const allChildren = getChildren(value); | ||
|
|
||
| if (!allChildren.length) { | ||
| return { checked: values[value], indeterminate: false }; |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| return { checked: values[value], indeterminate: false }; | ||
| } | ||
|
|
||
| const checkedChildren = allChildren.filter((child) => values[child.value]); |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| const allChildren = getChildren(value); | ||
|
|
||
| if (!allChildren.length) { | ||
| return { checked: values[value], indeterminate: false }; |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
| return { checked: values[value], indeterminate: false }; | ||
| } | ||
|
|
||
| const checkedChildren = allChildren.filter((child) => values[child.value]); |
Check warning
Code scanning / Semgrep
Semgrep Finding: gitlab.eslint.detect-object-injection Warning
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-754/ |
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-754/ |
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
1 similar comment
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
2 similar comments
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
Добавлена реализация компонента
Checkboxв новой архитектуре.Добавлены сборки компонента для новых тем plasma_web и plasma_b2c с новыми пропсами:
view,disabled,focused.Добавлены сборки компонента для старых библиотек
@salutejs/plasma-web,@salutejs/plasma-b2c.Добавлена обёртка для layout создаваемого компонента для проброса дефолтных значений из конфигов.
Исправлено поведение, при котором при фокусе на ссылку внутри описания, рамка обрезалась.
Было:
Стало:
#586
🐤 Download canary assets:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
Version
Published prerelease version:
@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]Changelog
Release Notes
plasma-web: Pass
refto DropdownItem (#769)Добавлена возможность использовать свойство
refдля компонентаDropdownItemplasma-infra: Update version (#770)
Выключили sync package-lock's файлов для приватных пакетов.
What/why Changed
При попытке установить приватный пакет, получаем ошибку 404 - Not found.
Поэтому принято решение не запускать
npm i --package-lock-onlyдля приватнных пакетов.Добавлен флаг
--legacy-peer-depsчто бы исключить ошибки:plasma-infra: Update private packages version with @auto-it (#734)
Включили обновление версий для всех пакетов, включая приватные.
What/why Changed
Сделали патчи для
@auto-it/coreи@auto-it/npmчто бы можно было включить в обработку все пакеты.Как оказалось в
@auto-it/coreв методеgetLernaPackages(packages/core/src/utils/get-lerna-packages.ts)была логика фильтрующая пакеты по полюprivate:C помощью
patch-packageсделал патчи для изменения этой логики.В этом commit из песочнице можно посмотреть как это работает.
Запуск локально проекта
auto next --dry-run(Report what command will do but do not actually do anything)при изменениях в пакете
plasma-web:Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.
🚀 Enhancement
Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-webCheckboxfrom plasma-new-hope and update snapshots #754 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-b2cCheckboxcomponent with new design and core #754 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-new-hopeCheckboxcomponent with new design and core #754 (@neretin-trike)Spinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)@salutejs/plasma-hopeSpinnercomponent with new design and core #736 (@neretin-trike)Linkcomponent with new design and core #696 (@neretin-trike)refto DropdownItem #769 (@Yakutoc)@salutejs/plasma-core,@salutejs/plasma-new-hopeSpinnercomponent with new design and core #736 (@neretin-trike)@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-tokens@salutejs/plasma-tokens-utils@salutejs/plasma-tokens,@salutejs/plasma-tokens-utils@salutejs/plasma-ui🐛 Bug Fix
@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-core,@salutejs/plasma-hope@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-coredev@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-new-hope,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-b2c,@salutejs/plasma-hope,@salutejs/plasma-new-hope,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils@salutejs/plasma-b2c,@salutejs/plasma-hope,@salutejs/plasma-web@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-tokens-b2b,@salutejs/plasma-tokens-b2c,@salutejs/plasma-tokens-web,@salutejs/plasma-tokens,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-cy-utils,@salutejs/plasma-sb-utils,@salutejs/plasma-tokens-utils@salutejs/plasma-b2c,@salutejs/plasma-core,@salutejs/plasma-hope,@salutejs/plasma-icons,@salutejs/plasma-temple,@salutejs/plasma-tokens-web,@salutejs/plasma-ui,@salutejs/plasma-web,@salutejs/plasma-sb-utils,@salutejs/plasma-tokens-utils@salutejs/plasma-new-hope@salutejs/plasma-temple,@salutejs/plasma-uiAuthors: 7