Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plasma-ui,plasma-web,plasma-b2c): Button Spinner checked color #748

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

Yeti-or
Copy link
Contributor

@Yeti-or Yeti-or commented Sep 22, 2023

Release Notes

Починили цвет внутри

What/why Changed

Было
Screenshot 2023-09-24 at 21 47 48
Стало
Screenshot 2023-09-24 at 21 47 51

🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.748.6271372613.ts
borderRadius_plasma_b2c_react-native--canary.748.6271372613.ts
borderRadius_plasma_web_react-native--canary.748.6271372613.ts
borderRadius_sberHealth_react-native--canary.748.6271372613.ts
borderRadius_sbermarket_business_react-native--canary.748.6271372613.ts
borderRadius_sbermarket_metro_react-native--canary.748.6271372613.ts
borderRadius_sbermarket_react-native--canary.748.6271372613.ts
borderRadius_sbermarket_selgros_react-native--canary.748.6271372613.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.748.6271372613.ts
borderRadius_sberonline_react-native--canary.748.6271372613.ts
borderRadius_sberprime_react-native--canary.748.6271372613.ts
borderRadius_stylesSalute_react-native--canary.748.6271372613.ts
color
color_default_ios-swift--canary.748.6271372613.swift
color_default_kotlin--canary.748.6271372613.kt
color_default_react-native--canary.748.6271372613.ts
color_default_xml--canary.748.6271372613.xml
color_plasma_b2c_ios-swift--canary.748.6271372613.swift
color_plasma_b2c_kotlin--canary.748.6271372613.kt
color_plasma_b2c_react-native--canary.748.6271372613.ts
color_plasma_b2c_xml--canary.748.6271372613.xml
color_plasma_web_ios-swift--canary.748.6271372613.swift
color_plasma_web_kotlin--canary.748.6271372613.kt
color_plasma_web_react-native--canary.748.6271372613.ts
color_plasma_web_xml--canary.748.6271372613.xml
color_sberHealth_ios-swift--canary.748.6271372613.swift
color_sberHealth_kotlin--canary.748.6271372613.kt
color_sberHealth_react-native--canary.748.6271372613.ts
color_sberHealth_xml--canary.748.6271372613.xml
color_sbermarket_business_ios-swift--canary.748.6271372613.swift
color_sbermarket_business_kotlin--canary.748.6271372613.kt
color_sbermarket_business_react-native--canary.748.6271372613.ts
color_sbermarket_business_xml--canary.748.6271372613.xml
color_sbermarket_ios-swift--canary.748.6271372613.swift
color_sbermarket_kotlin--canary.748.6271372613.kt
color_sbermarket_metro_ios-swift--canary.748.6271372613.swift
color_sbermarket_metro_kotlin--canary.748.6271372613.kt
color_sbermarket_metro_react-native--canary.748.6271372613.ts
color_sbermarket_metro_xml--canary.748.6271372613.xml
color_sbermarket_react-native--canary.748.6271372613.ts
color_sbermarket_selgros_ios-swift--canary.748.6271372613.swift
color_sbermarket_selgros_kotlin--canary.748.6271372613.kt
color_sbermarket_selgros_react-native--canary.748.6271372613.ts
color_sbermarket_selgros_xml--canary.748.6271372613.xml
color_sbermarket_wlbusiness_ios-swift--canary.748.6271372613.swift
color_sbermarket_wlbusiness_kotlin--canary.748.6271372613.kt
color_sbermarket_wlbusiness_react-native--canary.748.6271372613.ts
color_sbermarket_wlbusiness_xml--canary.748.6271372613.xml
color_sbermarket_xml--canary.748.6271372613.xml
color_sberonline_ios-swift--canary.748.6271372613.swift
color_sberonline_kotlin--canary.748.6271372613.kt
color_sberonline_react-native--canary.748.6271372613.ts
color_sberonline_xml--canary.748.6271372613.xml
color_sberprime_ios-swift--canary.748.6271372613.swift
color_sberprime_kotlin--canary.748.6271372613.kt
color_sberprime_react-native--canary.748.6271372613.ts
color_sberprime_xml--canary.748.6271372613.xml
color_stylesSalute_ios-swift--canary.748.6271372613.swift
color_stylesSalute_kotlin--canary.748.6271372613.kt
color_stylesSalute_react-native--canary.748.6271372613.ts
color_stylesSalute_xml--canary.748.6271372613.xml
shadow
shadow_default_react-native--canary.748.6271372613.ts
shadow_plasma_b2c_react-native--canary.748.6271372613.ts
shadow_plasma_web_react-native--canary.748.6271372613.ts
shadow_sberHealth_react-native--canary.748.6271372613.ts
shadow_sbermarket_business_react-native--canary.748.6271372613.ts
shadow_sbermarket_metro_react-native--canary.748.6271372613.ts
shadow_sbermarket_react-native--canary.748.6271372613.ts
shadow_sbermarket_selgros_react-native--canary.748.6271372613.ts
shadow_sbermarket_wlbusiness_react-native--canary.748.6271372613.ts
shadow_sberonline_react-native--canary.748.6271372613.ts
shadow_sberprime_react-native--canary.748.6271372613.ts
shadow_stylesSalute_react-native--canary.748.6271372613.ts
spacing
spacing_default_react-native--canary.748.6271372613.ts
spacing_plasma_b2c_react-native--canary.748.6271372613.ts
spacing_plasma_web_react-native--canary.748.6271372613.ts
spacing_sberHealth_react-native--canary.748.6271372613.ts
spacing_sbermarket_business_react-native--canary.748.6271372613.ts
spacing_sbermarket_metro_react-native--canary.748.6271372613.ts
spacing_sbermarket_react-native--canary.748.6271372613.ts
spacing_sbermarket_selgros_react-native--canary.748.6271372613.ts
spacing_sbermarket_wlbusiness_react-native--canary.748.6271372613.ts
spacing_sberonline_react-native--canary.748.6271372613.ts
spacing_sberprime_react-native--canary.748.6271372613.ts
spacing_stylesSalute_react-native--canary.748.6271372613.ts
typo
typo_mage_ios-swift--canary.748.6271372613.swift
typo_mage_kotlin--canary.748.6271372613.kt
typo_mage_react-native--canary.748.6271372613.ts
typo_plasma_ios-swift--canary.748.6271372613.swift
typo_plasma_kotlin--canary.748.6271372613.kt
typo_plasma_react-native--canary.748.6271372613.ts
typo_ruler_ios-swift--canary.748.6271372613.swift
typo_ruler_kotlin--canary.748.6271372613.kt
typo_ruler_react-native--canary.748.6271372613.ts
typo_sage_ios-swift--canary.748.6271372613.swift
typo_sage_kotlin--canary.748.6271372613.kt
typo_sage_react-native--canary.748.6271372613.ts
typo_sbermarket_ios-swift--canary.748.6271372613.swift
typo_sbermarket_kotlin--canary.748.6271372613.kt
typo_sbermarket_react-native--canary.748.6271372613.ts
typo_soulmate_ios-swift--canary.748.6271372613.swift
typo_soulmate_kotlin--canary.748.6271372613.kt
typo_soulmate_react-native--canary.748.6271372613.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Version

Published prerelease version: @salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Changelog

Release Notes

plasma-infra: Update private packages version with @auto-it (#734)

Включили обновление версий для всех пакетов, включая приватные.

What/why Changed

Сделали патчи для @auto-it/core и @auto-it/npm что бы можно было включить в обработку все пакеты.

Как оказалось в @auto-it/core в методе getLernaPackages(packages/core/src/utils/get-lerna-packages.ts) была логика фильтрующая пакеты по полю private:

   if (version !== "MISSING" && isPrivate !== "PRIVATE") {
      packages.push({ path: packagePath, name, version });
    }

C помощью patch-package сделал патчи для изменения этой логики.

В этом commit из песочнице можно посмотреть как это работает.

Запуск локально проекта auto next --dry-run (Report what command will do but do not actually do anything)

при изменениях в пакете plasma-web:

Так же откатили/удалили все что было связанно с ручным обновлением версий в приватных пакетах.



🚀 Enhancement

  • @salutejs/plasma-new-hope
    • feat(plasma-new-hope): 🚀 boostrap && init #691 (@Yeti-or)
  • @salutejs/plasma-ui
    • feat(plasma-ui): add prop "buttonsDirection" #701 (@Yakutoc)

🐛 Bug Fix

  • chore: up perftool #730 (@akhdrv)
  • ci: new endpoint for perftool-send-report #730 (@akhdrv)
  • ci("PR Documentation and Storybook"): delete "HAS_PLASMA_WEBSITE" flag #734 (@Yakutoc)
  • plasma-infra: Update private packages version with @auto-it #734 (@Yakutoc)
  • chore(github): add pull request template #685 (@Yakutoc)
  • ci: fix website main-page in pr #700 (@kayman233)
  • @salutejs/plasma-core
    • fix(plasma-ui,plasma-web,plasma-b2c): Button Spinner checked color #748 (@Yeti-or)

⚠️ Pushed to dev

Authors: 5

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-748/

@Salute-Eva
Copy link
Contributor

@Yeti-or Yeti-or merged commit 5846129 into dev Sep 24, 2023
22 checks passed
@Yeti-or Yeti-or deleted the yeti-or.Button-Looader-Colour branch September 24, 2023 18:49
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants