Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization of sagelib: Break out a separate package sagemath-standard-no-symbolics #32601

Open
mkoeppe opened this issue Sep 30, 2021 · 164 comments · May be fixed by #35095
Open

Modularization of sagelib: Break out a separate package sagemath-standard-no-symbolics #32601

mkoeppe opened this issue Sep 30, 2021 · 164 comments · May be fixed by #35095

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 30, 2021

This is a subset distribution that includes all of sagemath-standard except for sage.symbolic and modules that use that.

As preparation, we remove gratuitous module-level imports from sage.symbolic, sage.functions, sage.calculus which block this modularization.

To test:

./bootstrap && ./configure && make build && ./sage -sh -c '(cd pkgs/sagemath-standard-no-symbolics && SAGE_NUM_THREADS=16 tox -v -v -v -e sagepython-sagewheels-nopypi)'

See also:

Depends on #34547
Depends on #16522
Depends on #34855

CC: @kliem @egourgoulhon @tobiasdiez @anneschilling

Component: refactoring

Issue created by migration from https://trac.sagemath.org/ticket/32601

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 30, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Changed dependencies from #29865 to #29865, #32599, #32593

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Changed dependencies from #29865, #32599, #32593 to #32575, #29865, #32599, #32593

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Changed dependencies from #32575, #29865, #32599, #32593 to #32575, #32442, #29865, #32599, #32593

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Last 10 new commits:

adae38etrac 32575: Sphinx's install-requires.txt: allow version 4.2
1131c86Merge #32575
8af6041Merge tag '9.5.beta2' into t/32442/__configure__make___with_sage_venv_the_default
b3f7d34.gitignore: Add /venv
fc4b641configure.ac: Remove conveniene symlinks before (re)creating them
8bcbf1dMakefile (distclean): Remove convenience symlinks prefix, venv
dcb4a08configure.ac: Indicate default in help string for --with-sage-venv
9a63841Merge #32442
934fc6bsrc/setup.cfg.m4, src/pyproject.toml.m4: Add memory_allocator
89bb042pkgs/sagemath-standard-no-symbolics: Fixup

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Commit: 89bb042

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

Changed dependencies from #32575, #32442, #29865, #32599, #32593 to #32575, #32442, #29865, #32599, #32593, #32608

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

80baf7bsage.{dynamics,geometry,interfaces}.all: Use lazy_import for imports from modules not in sagemath-standard-no-symbolics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2021

Changed commit from 89bb042 to 80baf7b

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 2, 2021

comment:8
    from sage.quadratic_forms.genera.genus import genera
  File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/pkgs/sagemath-standard-no-symbolics/.tox/python-sagewheels-nopypi/lib/python3.9/site-packages/sage/quadratic_forms/genera/genus.py", line 35, in <module>
    from sage.functions.gamma import gamma
ModuleNotFoundError: No module named 'sage.functions'

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 17, 2021

Changed dependencies from #32575, #32442, #29865, #32599, #32593, #32608 to #32575, #32442, #29865, #32599, #32593, #32608, #32708

@mkoeppe

This comment has been minimized.

@egourgoulhon
Copy link
Member

Changed dependencies from #32575, #32442, #29865, #32599, #32593, #32608, #32708 to #32575, #32442, #29865, #32599, #32593, #32608, #32708, #32712

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 18, 2021

Changed dependencies from #32575, #32442, #29865, #32599, #32593, #32608, #32708, #32712 to #32575, #32442, #29865, #32599, #32593, #32608, #32708, #32712, #32665, #32619

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b484d51src/sage/symbolic/callable.py: Fixup
fad87c0Expression.is_callable: New
4bc059bsrc/sage/ext/fast_callable.pyx: Remove use of is_CallableSymbolicExpression
8624925src/sage/symbolic/ring.pyx: Update doctest output with deprecation warning
37da733src/sage/sets/condition_set.py: Remove use of is_CallableSymbolicExpression
80a8f9esage.plot: Remove use of is_CallableSymbolicExpression, is_SymbolicEquation
a287531src/sage/schemes/elliptic_curves/constructor.py: Remove use of SR, is_SymbolicEquation; add test for symbolic input
c9861d1src/sage/interfaces/qepcad.py: Remove use of is_SymbolicEquation
341337asrc/sage/ext/fast_callable.pyx: Remove use of is_SymbolicVariable
2c02ba9Merge #32665

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Changed commit from 80baf7b to 2c02ba9

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

e9fc48dMerge tag '9.5.beta3' into t/29865/t/29865-modularizarion-sage-objects
f79f0f8pkgs/sagemath-objects/setup.py: On sdist or egg_info, do not run find_python_sources
9600217pkgs/sagemath-objects/tox.ini: passenv SAGE_NUM_THREADS*
6bd807bpkgs/sagemath-categories/tox.ini: passenv SAGE_NUM_THREADS*
c60d2d4Merge #29865
c38d3d6src/requirements.txt.m4: Add memory_allocator

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Changed commit from 2c02ba9 to c38d3d6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Changed commit from c38d3d6 to efb68ff

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

d5f9cf5Merge tag '9.8.beta0' into t/32601/modularization_of_sagelib__break_out_a_separate_package_sagemath_standard_no_symbolics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9de7a1aMerge tag '9.8.beta3' into t/32601/modularization_of_sagelib__break_out_a_separate_package_sagemath_standard_no_symbolics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 15, 2022

Changed commit from d5f9cf5 to 9de7a1a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2022

Changed commit from 9de7a1a to c4425da

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c4425daMerge tag '9.8.beta4' into t/32601/modularization_of_sagelib__break_out_a_separate_package_sagemath_standard_no_symbolics

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2022

Changed dependencies from #32913 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b102b12pkgs/sagemath-standard-no-symbolics: Update

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 6, 2022

Changed commit from c4425da to b102b12

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Changed commit from b102b12 to cf6b1fb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b82d660Merge tag '9.8.beta5' into t/32601/modularization_of_sagelib__break_out_a_separate_package_sagemath_standard_no_symbolics
cf6b1fbFix imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0810d7aFix imports
2d7dd53src/sage/all_cmdline.py: Do not use lazy_import for predefined x

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Changed commit from cf6b1fb to 2d7dd53

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bd534cbpkgs/sagemath-standard-no-symbolics/sage_setup: Remove

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Changed commit from 2d7dd53 to bd534cb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Changed commit from bd534cb to 6b1c674

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6b1c674Fix imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e426400Fix imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Changed commit from 6b1c674 to e426400

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2022

Dependencies: #34547, #16522

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

250da03trac 34547: use lazy imports in much of sage.interfaces.all
9566546trac 34547: remove two "import sage.interfaces.all" lines
5789608Merge #34547
a29a25dtrac 16522: introduce debugging routine to access LazyImport attributes and a routine to clean namespaces of misconfigured LazyImport objects
1fa627bclean sage.all and user_globals upon initialization
6e384f5src/sage/misc/lazy_import.pyx: Codestyle/markup fixes
4acb9d7src/sage/misc/lazy_import.pyx (clean_namespace): Default for namespace like lazy_import
05ea54esrc/sage/misc/lazy_import.pyx: Codestyle fixes
9837decChange order of cases in `Partitions` to put cheaper tests first
7f1da65Merge #16522

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2022

Changed commit from e426400 to 7f1da65

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Changed dependencies from #34547, #16522 to #34547, #16522, #34855

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

2f4b053pkgs/sagemath-standard/setup.py: Run finder also for sdist, egg_info, dist_info
00deebepkgs/sagemath-objects/setup.py: Run finder also for sdist, egg_info, dist_info
39bd748src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import of typing_extensions
e229436Merge #34859
2b39b3dMerge #34858
c59622abuild/pkgs/sagemath*/spkg-src: Use build
7fc93d0build/pkgs/sagemath*/spkg-src: Use --skip-dependency-check
4940db4build/make/Makefile.in: Add targets SPKG-src for script packages
573fcfdbuild/make/Makefile.in: Move targets pypi-sdists, wheel, pypi-wheels here; use SPKG-sdist targets
8039865Merge #34855

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Changed commit from 7f1da65 to 8039865

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 17, 2023

Removed branch from issue description; replaced by PR #35150

@mkoeppe mkoeppe modified the milestones: sage-10.0, sage-10.1 Apr 30, 2023
@mkoeppe mkoeppe removed this from the sage-10.1 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment