Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.tensor.modules: remove dependency on sage.manifolds #32708

Closed
egourgoulhon opened this issue Oct 17, 2021 · 6 comments
Closed

sage.tensor.modules: remove dependency on sage.manifolds #32708

egourgoulhon opened this issue Oct 17, 2021 · 6 comments
Labels
c: manifolds p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@egourgoulhon
Copy link
Member

In view of Sage modularization, this ticket removes the only import from sage.manifolds in the module sage.tensor.modules.
This was an import of Chart in FreeModuleTensor._preparse_display. This is avoided by reimplementing _preparse_display in TensorFieldParal.

CC: @mkoeppe @tscrim

Component: manifolds

Keywords: tensor display

Author: Eric Gourgoulhon

Branch/Commit: 1635bd3

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32708
@egourgoulhon egourgoulhon added this to the sage-9.5 milestone Oct 17, 2021
@egourgoulhon
Copy link
Member Author

Commit: 1635bd3

@egourgoulhon
Copy link
Member Author

New commits:

1635bd3Remove import of Chart in sage.tensor.modules (#32708)

@egourgoulhon
Copy link
Member Author

Branch: public/manifolds/no_chart_import_in_tensor_modules-32708

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 18, 2021

Reviewer: Matthias Koeppe

@egourgoulhon
Copy link
Member Author

comment:3

Thank you for the review!

@vbraun
Copy link
Member

vbraun commented Oct 20, 2021

Changed branch from public/manifolds/no_chart_import_in_tensor_modules-32708 to 1635bd3

@vbraun vbraun closed this as completed in 11684c2 Oct 20, 2021
This was referenced Jan 30, 2023
Open
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#32708
1c25889
@egourgoulhon egourgoulhon mentioned this issue Apr 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mkoeppe