-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy_import: Muffle diagnostic messages for "at_startup" #32619
Comments
New commits:
|
Author: Matthias Koeppe |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Green bot => positive review. |
Reviewer: Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
There still is one doctest failure in |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:16
LGTM. |
comment:17
Thanks! |
Changed branch from u/mkoeppe/lazy_import__muffle_diagnostic_messages_for__at_startup_ to |
When loading a modularized part of Sage instead of
sage.all
, we should suppress the second of these two messages:Also, instead of
print
, we should usewarnings.warn
.Previous discussion:
CC: @tscrim @jhpalmieri @nthiery
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
4a8f409
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32619
The text was updated successfully, but these errors were encountered: