Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct use of "setup.py sdist", add targets "make SPKG-sdist" #34855

Closed
mkoeppe opened this issue Dec 17, 2022 · 11 comments · Fixed by #35104
Closed

Remove direct use of "setup.py sdist", add targets "make SPKG-sdist" #34855

mkoeppe opened this issue Dec 17, 2022 · 11 comments · Fixed by #35104
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 17, 2022 •
edited
Loading

Direct use of "setup.py sdist" is deprecated. Instead we use build to create the sdists.

We add new targets make sagemath_objects-sdist etc.

We move targets make pypi-sdists (which now uses the new targets), make wheel, and make pypi-wheels from the top-level Makefile to build/make/Makefile.in. This improves make pypi-wheels: It no longer builds the sagemath-objects wheel multiple times (as dependencies of other packages).

Depends on #34858

CC: @kiwifb

Component: build

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34855
@mkoeppe mkoeppe added this to the sage-9.8 milestone Dec 17, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 17, 2022

Branch: u/mkoeppe/remove_direct_use_of__setup_py_sdist_

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

New commits:

cc58c2dbuild/pkgs/sagelib/spkg-src: Use build
eee3f1aMakefile (pypi-sdists): Install python_build

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Commit: eee3f1a

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Dependencies: #34858

@mkoeppe mkoeppe changed the title Remove direct use of "setup.py sdist" Remove direct use of "setup.py sdist", add targets "make SPKG-sdist" Dec 19, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ef75d6asrc/MANIFEST.in: Add pxd files etc
2f4b053pkgs/sagemath-standard/setup.py: Run finder also for sdist, egg_info, dist_info
00deebepkgs/sagemath-objects/setup.py: Run finder also for sdist, egg_info, dist_info
39bd748src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import of typing_extensions
e229436Merge #34859
2b39b3dMerge #34858
c59622abuild/pkgs/sagemath*/spkg-src: Use build
7fc93d0build/pkgs/sagemath*/spkg-src: Use --skip-dependency-check
4940db4build/make/Makefile.in: Add targets SPKG-src for script packages
573fcfdbuild/make/Makefile.in: Move targets pypi-sdists, wheel, pypi-wheels here; use SPKG-sdist targets

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Changed commit from eee3f1a to 573fcfd

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0bd13acbuild/make/Makefile.in: Remove duplicate setting of PYPI_WHEEL_PACKAGES

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2022

Changed commit from 573fcfd to 0bd13ac

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
@isuruf isuruf mentioned this issue Jan 7, 2023
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34855
6bf44ec
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Removed branch from issue description; replaced by PR #35104

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#34855
8039865
vbraun pushed a commit that referenced this issue Mar 19, 2023
gh-35104: Remove direct use of "setup.py sdist", add targets "make SP…
df5d71a 
…KG-sdist"

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Fixes #34855

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35104
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
mkoeppe added a commit to mkoeppe/sage that referenced this issue May 22, 2023
@mkoeppe
Merge sagemath#34855
88e18d0
mkoeppe added a commit to mkoeppe/sage that referenced this issue May 22, 2023
@mkoeppe
Merge sagemath#34855
f712d67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

Remove direct use of "setup.py sdist", add targets "make SPKG-sdist" mkoeppe/sage
1 participant
@mkoeppe