Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.structure, sage.sets: Remove hard dependencies on the symbolic ring / polynomial rings #32599

Closed
mkoeppe opened this issue Sep 30, 2021 · 12 comments
Closed

sage.structure, sage.sets: Remove hard dependencies on the symbolic ring / polynomial rings #32599

mkoeppe opened this issue Sep 30, 2021 · 12 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 30, 2021

(partially cherry-picked from #32432)

CC: @tscrim @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 73aabd2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32599
@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 30, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Branch: u/mkoeppe/sage_structure__sage_sets__remove_hard_dependencies_on_the_symbolic_ring___polynomial_rings

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

New commits:

8e27fdcsrc/sage/structure/sequence.py: Do not fail if polynomial rings cannot be imported
b43a50csrc/sage/sets/condition_set.py: Do not fail if sage.symbolic cannot be imported

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Commit: b43a50c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

73aabd2src/sage/sets/condition_set.py: Fix up import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 2, 2021

Changed commit from b43a50c to 73aabd2

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2021

comment:8

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

comment:9

Thank you!

@vbraun
Copy link
Member

vbraun commented Oct 13, 2021

Changed branch from u/mkoeppe/sage_structure__sage_sets__remove_hard_dependencies_on_the_symbolic_ring___polynomial_rings to 73aabd2

@vbraun vbraun closed this as completed in 12f3702 Oct 13, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#32599
d366c6a
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#32599
39e4b5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe