Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization of sagelib: Break out a separate package sagemath-standard-no-symbolics #35150

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 17, 2023

📚 Description

Fixes #32601

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Feb 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Patch coverage: 90.80% and project coverage change: -0.89 ⚠️

Comparison is base (f449b14) 88.62% compared to head (c394e43) 87.73%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35150      +/-   ##
===========================================
- Coverage    88.62%   87.73%   -0.89%     
===========================================
  Files         2148     2147       -1     
  Lines       398653   398817     +164     
===========================================
- Hits        353308   349908    -3400     
- Misses       45345    48909    +3564     
Impacted Files Coverage Δ
...age/algebras/hecke_algebras/ariki_koike_algebra.py 96.03% <0.00%> (ø)
src/sage/arith/misc.py 90.99% <ø> (ø)
src/sage/categories/additive_magmas.py 97.77% <ø> (ø)
src/sage/categories/additive_semigroups.py 100.00% <ø> (ø)
src/sage/categories/affine_weyl_groups.py 100.00% <ø> (ø)
src/sage/categories/algebra_functor.py 80.00% <ø> (-20.00%) ⬇️
src/sage/categories/algebra_ideals.py 88.88% <ø> (ø)
src/sage/categories/algebra_modules.py 100.00% <ø> (ø)
src/sage/categories/algebras.py 100.00% <ø> (ø)
src/sage/categories/algebras_with_basis.py 96.22% <ø> (ø)
... and 236 more

... and 264 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 28, 2023

This is the last part of the log of testing this distribution

...
sage -t --random-seed=228944954937657511694224272655345237546 /Users/kwankyu/GitHub/sage-dev/local/share/doc/sage/html/en/thematic_tutorials/_sources/geometry/visualization.rst.txt  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 1376.9 seconds
    cpu time: 6674.4 seconds
    cumulative wall time: 8638.3 seconds
Features detected for doctesting: 4ti2,csdp,cvxopt,dvipng,gfan,graphviz,imagemagick,nauty,palp,pandoc,pdf2svg,pdftocairo,polytopes_db,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.pari,sage.misc.cython,sage.plot,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.rings.real_mpfr,sagemath_doc_html,sphinx
pytest is not installed in the venv, skip checking tests that rely on it
sagepython-sagewheels-nopypi: 2028389 C exit 5 (1388.49 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sagemath-standard-no-symbolics> sage -t -p --initial --installed pid=81355 [tox/execute/api.py:275]
.pkg-sagepython-sagewheels-nopypi: 2028398 W _exit> python /usr/local/Cellar/tox/4.4.6/libexec/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta [tox/tox_env/api.py:428]
Backend: run command _exit with args {}
Backend: Wrote response {'return': 0} to /var/folders/td/fw1q9ljs311ggyph77rs53_40000gn/T/pep517__exit-jz2f044r.json
.pkg-sagepython-sagewheels-nopypi: 2028446 I exit None (0.05 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sagemath-standard-no-symbolics> python /usr/local/Cellar/tox/4.4.6/libexec/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta pid=78662 [tox/execute/api.py:275]
.pkg-sagepython-sagewheels-nopypi: 2028566 D delete package /Users/kwankyu/GitHub/sage-dev/pkgs/sagemath-standard-no-symbolics/.tox/.tmp/package/1/sagemath-standard-no-symbolics-10.0b2.tar.gz [tox/tox_env/python/virtual_env/package/pyproject.py:179]
  sagepython-sagewheels-nopypi: FAIL code 5 (2028.33=setup[636.16]+cmd[1.73,1.95,1388.49] seconds)
  evaluation failed :( (2028.45 seconds)

I don't understand but the last lines seem to say something failed.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 28, 2023

Yes, this distribution still has lots and lots of doctest failures, so sage -t exits with an error status

@mkoeppe mkoeppe force-pushed the t/32601/modularization_of_sagelib__break_out_a_separate_package_sagemath_standard_no_symbolics branch from ae1e5ca to 4dd1517 Compare March 13, 2023 01:44
Matthias Koeppe added 20 commits March 18, 2023 14:13
Matthias Koeppe added 25 commits April 30, 2023 11:30
SageMath version 10.0.rc3, Release Date: 2023-05-12
…__break_out_a_separate_package_sagemath_standard_no_symbolics
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: d74d929

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 13, 2023

Merged this branch into #35095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modularization of sagelib: Break out a separate package sagemath-standard-no-symbolics
4 participants