-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ceil, floor from sage.functions.other in non-symbolic uses #32731
Comments
Dependencies: #32717 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Matthias Koeppe |
comment:5
LGTM. |
Reviewer: Travis Scrimshaw |
comment:6
Thank you! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Waiting for another round of the patchbot. |
comment:10
The failure in |
comment:11
Thank you (again)! |
Changed branch from u/mkoeppe/avoid_ceil__floor_from_sage_functions_other_in_non_symbolic_uses to |
floor(.../...)
can be rewritten as integer division...//...
Other uses can be replaced by
integer_ceil
,integer_floor
fromsage.arith.misc
Depends on #32717
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
33a2e7b
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32731
The text was updated successfully, but these errors were encountered: