-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split convex set methods of polyhedra into base1.py #32776
Comments
Changed branch from u/gh-kliem/polyhedron_base1 to u/mkoeppe/polyhedron_base1 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Merged some tickets to avoid merge conflicts later on. LGTM, thanks for working on this! |
Reviewer: Matthias Koeppe |
comment:10
Thank you. Well, this whole overly large file has always been annoying me. At some point I wanted to optimize polyhedral constructions and it is really difficult to locate them all (ok there is quickref). |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:12
trivial merge |
Changed branch from u/mkoeppe/polyhedron_base1 to |
Part of #32651.
Outsource convex set methods of polyhedra, but not those that construct new polyhedra.
Depends on #32767
Depends on #32731
Depends on #32630
CC: @mkoeppe
Component: geometry
Author: Jonathan Kliem
Branch/Commit:
6c79ebe
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/32776
The text was updated successfully, but these errors were encountered: