Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring in Polyhedron method representative_point #32630

Closed
sagetrac-nailuj mannequin opened this issue Oct 5, 2021 · 11 comments
Closed

Fix docstring in Polyhedron method representative_point #32630

sagetrac-nailuj mannequin opened this issue Oct 5, 2021 · 11 comments

Comments

@sagetrac-nailuj
Copy link
Mannequin

sagetrac-nailuj mannequin commented Oct 5, 2021

The docstring of the representative_point method for a Polyhedron currently says:

The point is chosen to be interior as far as possible.

That statement might be misleading. The representative_point is an interior point if possible, but it is not as far in the interior as possible (in the sense of maximizing the distance to the boundary).

This ticket provides a less ambiguous description for the method.

Component: geometry

Keywords: Polyhedron

Author: Julian Ritter

Branch/Commit: 15f2086

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/32630

@sagetrac-nailuj sagetrac-nailuj mannequin added this to the sage-9.5 milestone Oct 5, 2021
@sagetrac-nailuj
Copy link
Mannequin Author

sagetrac-nailuj mannequin commented Oct 5, 2021

@sagetrac-nailuj
Copy link
Mannequin Author

sagetrac-nailuj mannequin commented Oct 5, 2021

Commit: c2e0df8

@sagetrac-nailuj
Copy link
Mannequin Author

sagetrac-nailuj mannequin commented Oct 5, 2021

New commits:

c2e0df8replaced "as far as" by "if"

@sagetrac-nailuj
Copy link
Mannequin Author

sagetrac-nailuj mannequin commented Oct 5, 2021

Author: Julian Ritter

@fchapoton
Copy link
Contributor

comment:4

would you take the opportunity to remove the unused import of deprecated_function_alias ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 5, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

15f2086Removed import of deprecated_function_alias (imported but unused according to pyflakes)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 5, 2021

Changed commit from c2e0df8 to 15f2086

@sagetrac-nailuj
Copy link
Mannequin Author

sagetrac-nailuj mannequin commented Oct 5, 2021

comment:6

Replying to @fchapoton:

would you take the opportunity to remove the unused import of deprecated_function_alias ?

Sure, here we go.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:7

ok, Thanks.

@vbraun
Copy link
Member

vbraun commented Oct 24, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants