Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing remaining uses of is_CallableSymbolicExpression #34215

Closed
mkoeppe opened this issue Jul 24, 2022 · 9 comments
Closed

Removing remaining uses of is_CallableSymbolicExpression #34215

mkoeppe opened this issue Jul 24, 2022 · 9 comments
Labels
c: symbolics p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 24, 2022

Follow-up from #32665.

Part of #32601

CC: @DaveWitteMorris

Component: symbolics

Author: Matthias Koeppe

Branch/Commit: dad5253

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34215
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 24, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 24, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 24, 2022

Branch: u/mkoeppe/removing_remaining_uses_of_is_callablesymbolicexpression

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 24, 2022

New commits:

dad5253src/sage/symbolic/callable.py: Deprecate is_CallableSymbolicExpression, remove remaining uses

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 24, 2022

Commit: dad5253

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 29, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 29, 2022

comment:5

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 29, 2022

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 4, 2022

Changed branch from u/mkoeppe/removing_remaining_uses_of_is_callablesymbolicexpression to dad5253

@vbraun vbraun closed this as completed in 6732163 Aug 4, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
@mkoeppe
Merge sagemath#34215
0835822
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 19, 2023
@mkoeppe
sage.symbolic.callable: Remove function deprecated in sagemath#34215 …
34d6446 
…(2022)
mkoeppe added a commit to mkoeppe/sage that referenced this issue Oct 11, 2023
@mkoeppe
sage.symbolic.callable: Remove function deprecated in sagemath#34215 …
ff06d30 
…(2022)
vbraun pushed a commit to vbraun/sage that referenced this issue Oct 17, 2023
sagemathgh-36304: sage.symbolics: Remove code deprecated in sagemat…
52011ee 
…h#18036, sagemath#29738, sagemath#32386, sagemath#32638, sagemath#32665, sagemath#34215

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36304
Reported by: Matthias Köppe
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this issue Oct 19, 2023
sagemathgh-36304: sage.symbolics: Remove code deprecated in sagemat…
e3e4288 
…h#18036, sagemath#29738, sagemath#32386, sagemath#32638, sagemath#32665, sagemath#34215

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36304
Reported by: Matthias Köppe
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @mkoeppe