[pull] master from elastic:master #924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Generate release notes for v8.3.0 (#87294) * Generate release notes for v8.3.0 * [DOCS] Add 8.3 migration file to index * Fixed version number * Fix formatting of deprecation in 85326 * Use asciidoc format for deprecations * Extract static content from migration/index * This was just an enhancement * Nope, it was an upgrade * Added migration/index.asciidoc generation support (#87318) Including extracting static content from migration/index, so the template would be as light as possible. The reason for this work is because the gradle task `generateReleaseNotes` was not correctly adding new links and imports to the migrations/index and that caused documentation to fail building for 8.3.0. * [DOCS] Add ml-cpp PRs to release notes * Added back incorrectly deleted changlog * Added missing highlight * Fixed spelling of StackOverflowError Co-authored-by: lcawl <[email protected]> * Brought back missing changelog for 87235 (#87370) * Brought back missing changelog for 87235 * Regenerate release notes * Regenerate release notes for BC3 (#87449) * Regenerate release notes for BC3 * Re-applied manual fixes that Lisa Cawley used * Fixed breaking changes generation To match the manual edits done by Lisa Cawley * Fixed failing test Since the manual edits by Lisa removed the `-SNAPSHOT` from the docs we remove it from the tests too. * Remove changelogs for intermediate lucene upgrades * Update release notes for BC4 (#87635) * Update release notes for BC4 * Adding missing changelog for geo_grid * Added missing highlight notes for 84250 * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: David Kilfoyle <[email protected]> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: David Kilfoyle <[email protected]> * Backported fixes to original yaml * Control sort order of release highlights So that small changes to an individual highlight don't completely shuffle the entire document. We also added links to the PRs from the highlight titles, for convenience. Otherwise readers need to search the release notes for the changelog entry and click there, which is a lot more work. * Fixed failing test after new ordered highlights Also made test verify re-ordering of highlights Co-authored-by: David Kilfoyle <[email protected]> * Update release notes for BC5 (#87808) * Update release notes for BC6 (#87912) * Update release notes for BC9 (#88011) * Regenerate release notes after version bump 8.4.0 And after forward porting 8.3.0 release notes changes. * Regenerate after some changelog entries removed * Re-prune the changelogs * Removed three changelog entries Co-authored-by: lcawl <[email protected]> Co-authored-by: David Kilfoyle <[email protected]>
…ult (#88148) This changes AbstractGradleFuncTest to run with configuration cache enabled by default. That gives us better test coverage on how our build logic works with configuration cache enabled and makes it explicit which parts are not yet working. We fixed some minor configuration cache related issues in our code.
S3 sometimes enters a state where blob downloads repeatedly fail but with nontrivial progress between failures. Often each attempt yields 10s or 100s of MBs of data. Today we abort a download after three (by default) such failures, but this may not be enough to completely retrieve a large blob during one of these flaky patches. With this commit we start to avoid counting download attempts that retrieved at least 1% of the configured `buffer_size` (typically 1MB) towards the maximum number of retries. Closes #87243
Block the cluster applier before disrupting the cluster so the victim node doesn't try and rejoin too soon. Closes #86974
Add a section on running failed tests as indicated by CI.
User profile is behind a feature flag in 8.3. When 8.3 is still a snapshot build, the feature flag is enabled automatically. But now 8.3 is released, the feature flag is by default off. This PR adjust the node selector to only select node version 8.4 or higher. Resolves: #88202
For fully-formed single-node clusters, emit a periodic warning if seed_hosts has been set to a non-empty list. Closes #85222
Co-authored-by: Elastic Machine <[email protected]>
When creating an index with a system index descriptor, ignore all templates. Update tests that check template behavior. Co-authored-by: Nikola Grcevski <[email protected]>
) We will use target reference to distinguish between different versions or branches of our elasticsearch project to be able to trace vulnerable dependencies down to the version. snyk lifecycle property allows filtering the project overview by `production` or `development`. When version is ending with SNAPSHOT we configure the lifecycle as development. Otherwise its production. Related to #87620
Optimize log cluster health performance by not building cluster health instances needlessly. relates #77466
… support (#88188) This introduces the ability to simply configure a java tool chain for elasticsearch java projects to be used. If an environment variable `JAVA_TOOLCHAIN_HOME `is declared, this JDK will be used as toolChain in elasticsearch.java projects. If JAVA_RUNTIME_HOME is configured, it takes precedence over JAVA_TOOLCHAIN_HOME for configuring test cluster runtimes. This should make testing our build with java `ea` versions easier and allows detangling the used compiler jdk from the gradle java runtime.
Implicitly skip backing indices with a time series range that doesn't match with a required filter on @timestamp field. Relates to #74660
The fix for the problems identified in #88090 is in elastic/ml-cpp#2337, so the test can be unmuted now. Closes #88090
Just two simple spots I found while researching something else.
Addressing #87913 by fixing LocalRepositoryFixture on windows
This reverts commit 793dcc7.
Use `indexMode` field instead of parsing IndexMode from settings in order to determine time series timestamp range. Parsing the index mode isn't necessary, because we read the index mode when IndexMetadata is constructed, and this just burns unnecessary CPU cycles.
… scenarios (#88623) With 8.4, trained model assignments now take CPU into consideration. This changes our calculation for scaling down until we fully support autoscaling according to CPU requirements. We shouldn't allow scaling down if there is ANY model assignment that isn't fully allocated (meaning, not enough CPUs) We don't allow scaling down unless model assignments require less than half of the current scale's CPU count. Point 2 is a place holder. Fix 1 will be a requirement even in the future with vCPU autoscaling.
) ensure transform has done something before stop gets called with wait_for_checkpoint=true fixes #79621
There is no need to use stopRandomNode/namePredicate combination to stop a node by its name.
Our docs currently recommend PBKDF2 as a cache hasher in FIPS mode. However, the performance overhead of PBKDF2 is prohibitive; ssha256 is a more appropriate choice for in-memory credential hashing. This PR updates the docs to reflect this. See #86740 for more context.
Making this a little smaller so it inlines more often and more importantly avoid getting the current field name redundantly before entering the loop which is not free when the parser is a `DotExpandingXContentParser`. This change gives a significant boost to `BeatsMapperBenchmark.benchmarkParseKeywordFields`. Results below are pretty stable, running with a large number of iterations. before: ``` Result "org.elasticsearch.benchmark.index.mapper.BeatsMapperBenchmark.benchmarkParseKeywordFields": 9039.270 ±(99.9%) 28.001 ns/op [Average] (min, avg, max) = (9008.778, 9039.270, 9062.246), stdev = 18.521 CI (99.9%): [9011.269, 9067.271] (assumes normal distribution) ``` after: ``` Result "org.elasticsearch.benchmark.index.mapper.BeatsMapperBenchmark.benchmarkParseKeywordFields": 8645.649 ±(99.9%) 53.677 ns/op [Average] (min, avg, max) = (8568.319, 8645.649, 8688.210), stdev = 35.504 CI (99.9%): [8591.972, 8699.327] (assumes normal distribution) ```
Improve RollupShardIndexer by reducing the calls to BytesRef.deepCopyOf(tsid)
Today each time there's shards to snapshot we enqueue a lambda which captures the current `SnapshotsInProgress$Entry`. This is a pretty heavyweight object, possibly several MB in size, most of which is not necessary to capture, and with concurrent snapshots across thousands of shards we may enqueue many hundreds of slightly different such objects. With this commit we compute a more efficient representation of the work to be done by each task in the queue instead. Relates #77466
Co-authored-by: Gordon Brown <[email protected]>
This PR adds a new `knn` option to the `_search` API to support ANN search. It's powered by the same Lucene ANN capabilities as the old `_knn_search` endpoint. The `knn` option can be combined with other search features like queries and aggregations. Addresses #87625
ClosePointInTimeRequest#validate should return a validation error for an invalid pit_id, but it throws an IAE instead. This mistake prevents close_point_in_time tasks of requests with empty pit_id from being removed.
If there is no shard failure we would like to use a generic Internal Server Error other than a Service Unavailable. Moreover, if the cause is known we use a status code that reflects the cause.
* Convert disk watermarks to RelativeByteSizeValues Similar to the existing watermark setting for the frozen tier. Pre-requisite for PR 88639 that plans to introduce max headroom settings for the disk watermarks, similar to the frozen tier max headroom setting. * Add changelog * Revert 20gb to 20GB * Make formatNoTrailingZerosPercent non static * ByteSizeValue.MINUS_ONE * Remove getMinimumTotalSizeForBelowWatermark * Remove comment * Fix minor stuff * Make parsing of RelativeByteSizeValue faster Mimicks older definitelyNotPercentage function * Remove Locale from Strings.format * More MINUS_ONE
The KnnSearchBuilder constructor validates that k is always less than num_cands. But the mutateInstance method could increase k past num_cands. Now we construct the instance with a larger num_cands to make sure this never happens. Closes #88734.
…found (#88023) Co-authored-by: Niels Dewulf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )