Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Hamster should emit more detailed runtime JDK build information #88180

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

ChrisHegarty
Copy link
Contributor

This change proposes to update the Build Hamster message so that it emits more detailed runtime JDK build information.

The additional build information about the runtime JDK is most useful when diagnosing test failures in jobs that execute JDK early access builds - trying to match the actual JDK in use when reading build scans. Currently we see 19-ea, which gives no indication of what actual 19-ea build is in use.

This change proposes to "stuff" the additional build information into the existing runtime JDK version message, but it could be easily put elsewhere or even into it's own Runtime JDK Build message if that would be more desirable.

Example:
BEFORE:

=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 12.4 (aarch64)
  Runtime JDK Version   : 19-ea (Oracle)
  Runtime java.home     : /Users/chegar/binaries/jdk-19-ea.jdk/Contents/Home
  Gradle JDK Version    : 18.0.1.1 (Oracle)
  Gradle java.home      : /Users/chegar/binaries/jdk-18.0.1.1.jdk/Contents/Home
  Random Testing Seed   : 40C0F7FC177EC27A
  In FIPS 140 mode      : false
=======================================

AFTER:

=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 12.4 (aarch64)
  Runtime JDK Version   : 19-ea (Oracle, 19-ea+26-2060)
  Runtime java.home     : /Users/chegar/binaries/jdk-19-ea.jdk/Contents/Home
  Gradle JDK Version    : 18.0.1.1 (Oracle)
  Gradle java.home      : /Users/chegar/binaries/jdk-18.0.1.1.jdk/Contents/Home
  Random Testing Seed   : 6A92036EEB4C7383
  In FIPS 140 mode      : false
=======================================

@ChrisHegarty ChrisHegarty added the Team:Delivery Meta label for Delivery team label Jun 29, 2022
@ChrisHegarty ChrisHegarty self-assigned this Jun 29, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@pugnascotia pugnascotia added the :Delivery/Build Build or test infrastructure label Jun 29, 2022
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good IMO.

@ChrisHegarty
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChrisHegarty
Copy link
Contributor Author

@elasticmachine update branch

@ChrisHegarty ChrisHegarty merged commit c2f4571 into elastic:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants