Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move geo_shape query builder tests to spatial module #88588

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jul 18, 2022

Currently we are testing geo_points an geo_shape fields for query builders in the same class in server. This PR extracts a TestCase for the query builder test (geo_bounding_box, geo_distance and geo_shape) and splits the testing between server (for geo_point) and spatial (for geo_shape).

@iverase iverase added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes :Search/Search Search-related issues that do not fall into other categories v8.4.0 labels Jul 18, 2022
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team labels Jul 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@not-napoleon not-napoleon self-requested a review July 20, 2022 15:37
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit bd5e16d into elastic:master Jul 22, 2022
@iverase iverase deleted the GeoQueryBuilderTests branch July 22, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes :Search/Search Search-related issues that do not fall into other categories Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants