Use origin for the client when running _features/_reset #88622
Conversation
grcevski
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @grcevski, I've created a changelog YAML for you. |
grcevski
assigned gwbrown and albertzaharovits and unassigned gwbrown and albertzaharovits
| StringBuilder exceptions = new StringBuilder("["); | ||
| exceptions.append(errors.stream().map(e -> e.getException().getMessage()).collect(Collectors.joining(", "))); | ||
| exceptions.append(']'); | ||
| listener.onResponse(ResetFeatureStateStatus.failure(name, new Exception(exceptions.toString()))); |
There was a problem hiding this comment.
Could you also add logging that captures the full stack traces? It's nitpicky but it's no fun when we hit a weird error and realize there's no way to get the actual stack trace.
| } | ||
|
|
||
| @Nullable | ||
| static SystemIndexDescriptor findMatchingDescriptor(SystemIndexDescriptor[] indexDescriptors, String name) { |
There was a problem hiding this comment.
I'm not objecting necessarily, but why break this out? I assumed it was for testing in my first pass given it's pkg-private, but there's no tests that use this version looks like.
There was a problem hiding this comment.
You are right, no need for that to be separate.
...ty/src/internalClusterTest/java/org/elasticsearch/integration/SecurityFeatureResetTests.java
Show resolved
Hide resolved
…csearch/integration/SecurityFeatureResetTests.java Co-authored-by: Gordon Brown <[email protected]>
I'm not sure if there's a plugin where there's not 1-1 mapping of feature to origin. I simply erred on the side of caution since the origin is on the descriptor, I decided to split everything. |
| @@ -73,15 +74,15 @@ public Collection<SystemIndexDescriptor> getSystemIndexDescriptors(Settings sett | |||
| .put(IndexMetadata.SETTING_AUTO_EXPAND_REPLICAS, "0-1") | |||
| .build() | |||
| ) | |||
| .setOrigin("net-new") | |||
There was a problem hiding this comment.
Fake origins don't work anymore, since we actually switch the security. I picked tasks since it's not in a module.
💔 Backport failed
You can use sqren/backport to manually backport by running |
The current implementation of
POST /_features/_resetdoesn't pass the index descriptor origin when callingDELETEon the system indices, therefore, we fail to reset the respective indices.Closes #88617