Use faster maths to project WGS84 to mercator #88231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>enhancement
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
craigtaverner
approved these changes
Jul 4, 2022
| @@ -143,6 +143,7 @@ tasks.named("yamlRestTestV7CompatTransform").configure { task -> | |||
| task.skipTest("indices.freeze/10_basic/Test index options", "#70192 -- the freeze index API is removed from 8.0") | |||
| task.skipTest("sql/sql/Paging through results", "scrolling through search hit queries no longer produces empty last page in 8.2") | |||
| task.skipTest("service_accounts/10_basic/Test get service accounts", "new service accounts are added") | |||
| task.skipTest("spatial/70_script_doc_values/diagonal length", "precision changed in 8.4.0") | |||
There was a problem hiding this comment.
Do we permanently skip this test? I see you changed the test result in the yaml file so do we need to skip this at all?
There was a problem hiding this comment.
We are skipping the V7 compatibility test (yamlRestTestV7CompatTransform) . It seems this mode is running the test on the v7 branch against this cluster. That currently fails because the change in precision which is fine.
| @@ -143,4 +143,4 @@ setup: | |||
| script: | |||
| source: "doc['geo_shape'].getMercatorHeight()" | |||
| - match: { hits.hits.0.fields.width.0: 389.62170283915475 } | |||
| - match: { hits.hits.0.fields.height.0: 333.37976840604097 } | |||
| - match: { hits.hits.0.fields.height.0: 333.37976841442287 } | |||
There was a problem hiding this comment.
Would be nice if we could assert on values with a precision.
There was a problem hiding this comment.
It does not help here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the from strict maths to sloppy maths when we compute the projection from WGS84 to spherical mercator. Precision is more than enough and test shows a meaningful speed up when doing it for big geometries. the test performed locally shows a ~15% improvement.