Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#88668 fix the error in the reindex task sentence #88669

Merged
merged 2 commits into from
Jul 22, 2022
Merged

#88668 fix the error in the reindex task sentence #88669

merged 2 commits into from
Jul 22, 2022

Conversation

amitmbm
Copy link
Contributor

@amitmbm amitmbm commented Jul 21, 2022

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added v8.4.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 21, 2022
@gmarouli gmarouli self-assigned this Jul 21, 2022
@gmarouli gmarouli added the >docs General docs changes label Jul 21, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jul 21, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jul 21, 2022
gmarouli
gmarouli requested changes Jul 21, 2022
View reviewed changes
docs/reference/cluster/tasks.asciidoc Outdated Show resolved Hide resolved
docs/reference/cluster/tasks.asciidoc Outdated Show resolved Hide resolved
@gmarouli
Copy link
Contributor

Hi @amitmbm thank you for reporting the issue and fixing it! I will backport it to the other versions when we merge this.

@gmarouli gmarouli added the auto-backport Automatically create backport pull requests when merged label Jul 21, 2022
@amitmbm
Copy link
Contributor Author

amitmbm commented Jul 22, 2022

@gmarouli I've addressed all the review suggestions, please take a look and approve so that I can merge it.

gmarouli
gmarouli approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And thank you for addressing all the comments

@amitmbm
Copy link
Contributor Author

amitmbm commented Jul 22, 2022

@gmarouli Please merge the changes as I can't merge it.

@gmarouli
Copy link
Contributor

@gmarouli Please merge the changes as I can't merge it.

Right away!

@gmarouli gmarouli merged commit e3dc098 into elastic:master Jul 22, 2022
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 88669

@amitmbm amitmbm deleted the fix-88668-fix-reindex-task branch July 22, 2022 11:00
gmarouli pushed a commit to gmarouli/elasticsearch that referenced this pull request Jul 22, 2022
@amitmbm @gmarouli
Tasks doc: fix a mistake about the reindex task description (elastic#…
a12356b 
…88669)
@gmarouli
Copy link
Contributor

Manual backport: #88720

gmarouli added a commit that referenced this pull request Jul 22, 2022
@gmarouli
Tasks doc: fix a mistake about the reindex task description (#88669) (#…
17fde1e 
…88720)

Authored-by: Elasticsearch addict <[email protected]>
@abdonpijpelink abdonpijpelink mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarouli gmarouli gmarouli approved these changes

Assignees

@gmarouli gmarouli

Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v7.17.6 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitmbm @elasticsearchmachine @gmarouli