Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable TestingConventionsPrecommitPluginFuncTest on windows #88240

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Reenable TestingConventionsPrecommitPluginFuncTest on windows #88240

merged 3 commits into from
Jul 4, 2022

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jul 4, 2022

Addressing #87913

@breskeby breskeby self-assigned this Jul 4, 2022
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team labels Jul 4, 2022
@breskeby breskeby added test-windows Trigger CI checks on Windows >test Issues or PRs that are addressing/adding tests and removed >enhancement labels Jul 4, 2022
@breskeby breskeby marked this pull request as ready for review July 4, 2022 10:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby
Copy link
Contributor Author

breskeby commented Jul 4, 2022

@elasticmachine update branch

@breskeby breskeby merged commit 4c7ed5f into elastic:master Jul 4, 2022
@breskeby breskeby deleted the fix-test-conv-integ-windows branch July 4, 2022 11:59
@breskeby
Copy link
Contributor Author

breskeby commented Jul 4, 2022

This also fixed #88246

This was referenced Jul 4, 2022
Closed
Closed
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jul 13, 2022
@breskeby
Reenable TestingConventionsPrecommitPluginFuncTest on windows (elasti…
b30a5af 
…c#88240)

Addressing elastic#87913 by fixing LocalRepositoryFixture on windows
# Conflicts:
#	build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/precommit/TestingConventionsPrecommitPluginFuncTest.groovy
@breskeby breskeby mentioned this pull request Jul 13, 2022
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jul 13, 2022
@breskeby
Reenable TestingConventionsPrecommitPluginFuncTest on windows (#88240) (
4132c47 
#88524)

Addressing #87913 by fixing LocalRepositoryFixture on windows
# Conflicts:
#	build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/precommit/TestingConventionsPrecommitPluginFuncTest.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@breskeby breskeby

Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows v7.17.6 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breskeby @elasticmachine @elasticsearchmachine