Reenable TestingConventionsPrecommitPluginFuncTest on windows (#88240)

Addressing #87913 by fixing LocalRepositoryFixture on windows
elastic · Jul 4, 2022 · 4c7ed5f · 4c7ed5f
1 parent 40de25b
commit 4c7ed5f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/...rnal/src/integTest/groovy/org/elasticsearch/gradle/fixtures/LocalRepositoryFixture.groovy b/...rnal/src/integTest/groovy/org/elasticsearch/gradle/fixtures/LocalRepositoryFixture.groovy
@@ -56,7 +56,7 @@ class LocalRepositoryFixture extends ExternalResource{
         repositories {
           maven {
             name = "local-test"
-            url = "${getRepoDir()}"
+            url = "${getRepoDir().toURI()}"
             metadataSources {
               artifact()
             }

diff --git a/.../elasticsearch/gradle/internal/precommit/TestingConventionsPrecommitPluginFuncTest.groovy b/.../elasticsearch/gradle/internal/precommit/TestingConventionsPrecommitPluginFuncTest.groovy
@@ -13,13 +13,9 @@ import org.elasticsearch.gradle.fixtures.LocalRepositoryFixture
 import org.elasticsearch.gradle.internal.conventions.precommit.PrecommitPlugin
 import org.gradle.testkit.runner.TaskOutcome
 import org.junit.ClassRule
-import org.junit.rules.TemporaryFolder
-import spock.lang.IgnoreIf
 import spock.lang.Shared
 import spock.lang.Unroll
 
-// see https://github.com/elastic/elasticsearch/issues/87913
-@IgnoreIf({ os.windows })
 class TestingConventionsPrecommitPluginFuncTest extends AbstractGradleInternalPluginFuncTest {
 
     Class<? extends PrecommitPlugin> pluginClassUnderTest = TestingConventionsPrecommitPlugin.class