[pull] main from ampproject:main #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…37475) * Added tasts * Undo * Adding share examples for analytics * Using share menu for analytics
Run the same React-specific transforms on Storybook files as we do on component bundles. In effect, this maps Preact-style prop names to React-style. This prevents issues like ``Invalid DOM property `class`. Did you mean `className`?`` Note that we still get an error for using `tabindex` instead of `tabIndex`. This is because our prop mapping is erroneously flipped. See #37459
* preact parseProps: only match elements * node->element:
#36234) * Allow `importance` attribute on SSR'ed `amp-img > img` * Add importance attribute to amp-img and constraint values
* Mention that amp-state can contain a constant Add an example showing that it can be initialized to a constant, not just an object. (This is something I was never sure about when I first started using AMP.) * Is prettify complaining because my line's >= 80 characters? * Trying still to make prettier happy. So embarrassing. * Remove spurious curly braces
* Implemented hasAudio from monti * Use promises for hasVideoWithAudio * Added tests * Use waitForPlaybackMediaLayout * Use waitForMediaLayout * Use load signal on visual test * Added return * Remove consolelog * Revert flaky tests * Strict equality check * Added console logs meanwhile * Wait on story for elements that resolve on runtime * Remove unused const * Revert logs * Move wait promise to audio.js * Streamline has videos with audio * Clean comments * Fixed merge errors * Added missing import * Linting * Linting added comma
* add myua to vendors list * fix year and cleaning * remove copyright notices * fix linter errors * replace demo param with env * replace validation demo param with env
eslint changed the node API so that `.start/end` is no longer available, instead providing `.range`. This is the same change as #37422, but for the rest of the rules.
* Added tasts * Undo * Prerender the animations so they don't delay LCP * Remove tests and beforeVisible * Install extension if creating page outlink * Import services * Get amp doc from doc * Fixed linting
…ode (#37442) * Create a new extension that would control paywall experience in amp-story. Boilerplate code only. * Update extensions/amp-story-subscription/OWNERS Co-authored-by: Caleb Cordry <[email protected]> * Add validator required changes to pass the presubmit. * Update validation result * Replace htmlFor with JSX. Add I2I issue to the comment. * Add amp-story-subscription.html to allowlist. Will remove it once the validator in npm contains the new validator rule files in this PR. * Fix lint errors * Add a todo to remove allowlist once the validator rules are in. * Rename amp-story-subscription to amp-story-subscriptions. Update owner file. * Fix validator .out file. * Remove 'latest' verson as it's been deprecated. Co-authored-by: Caleb Cordry <[email protected]>
* fix maps * keep old check
* reopen attachment. * whenUpgradedToCustomElement * remove return * Chain
…tag and eventType (#37488) * Added tasts * Undo * Adding share examples for analytics * Using share menu for analytics * Added test * Fixed linting * Fix linting again * Added comment to retrigger CLA
* amp-ad ads2bid implementation * amp-ad ads2bid implementation spaces
* remove kris from owners files * Update OWNERS Co-authored-by: Ryan Cebulko <[email protected]> Co-authored-by: Ryan Cebulko <[email protected]>
* SwG Release 0.1.22.203 * Updated unit test to ignore encodedParams * empty
* async-await-ify beforeEach * async-await-ify test fns * async-await-ify test beforeEach * Mirror `changeVisibility` helper * vertical whitespace * Empty commit
* cl/423157347 Fix a bug that usefulCdataSpec was not checked * cl/423391673 Fix a bug that descriptive name was not checked * cl/423430953 Remove allowlist of tags which have no descriptive name * cl/424432911 Test whether attribute rule makes sense Co-authored-by: antiphoton <[email protected]>
* Add C++ tests on whether validator rules make sense PiperOrigin-RevId: 423415201 * Remove allowlist of tags which have no descriptive name PiperOrigin-RevId: 423430953 * Fix a bug by no longer using string_view of block scope string PiperOrigin-RevId: 423900419 * Test whether attribute rule makes sense PiperOrigin-RevId: 424432911 * Test whether satisfies match up with requires and excludes PiperOrigin-RevId: 424454520 * Test whether error codes are unique PiperOrigin-RevId: 424454591 * Fix compile errors in github unit test PiperOrigin-RevId: 424701686 Co-authored-by: Boxiao Cao <[email protected]>
* plp * comment * Styling * Number formatting function. * White space * Rename enum * abstract load fonts into amp-story * Fix conflict * revert * format number * revert * Abstract shared functions from shopping tag * Revert "Abstract shared functions from shopping tag" This reverts commit 6851845. * tag * test commit * revert test commit * lint * Update dep check * Example update * Update variable names. * Set template function * Update visual tests. * unit test * lint * Update config test with new entries. * formatI18nNumber test * lint fix * Attachment content unit test. * Types, comments and structure * comment * indention in example template. * Template variables. * lint fix * update test * template names * Add depends on story service. * add dep * Update templates. * CTA label * CSS prefix. MutateElement. * Update type * Attachment state listener for populating PLP. * Test for invalid currency * Update template and images to royalty free. * background image on cards. * Update images and template * Prevent experience from building if no tags are on page. * Update template. * Update string * whitespace * Text adjustments * Revert "Text adjustments" This reverts commit 91180de. * text adjustments * rebase * comment. * try catch to gracefully fallback to a number. * space * Link directly to images. * call open on amp-story-page-attachment * spaces * lint * price fallback * update tests * Update price fallback * newline * clean up tests
* feature(bento-add-banner): initial template generation * feature(bento-add-banner): created simple storybook * feature(bento-add-banner): copied CSS from classic * feature(bento-add-banner): added many "stubs" for standalone services * feature(bento-add-banner): ported IOS and Android app logic * feature(bento-add-banner): added platform-aware logic, and dismiss button storage * feature(bento-add-banner): added UI unit tests * feature(bento-add-banner): added IOS tests * feature(bento-add-banner): moved sources into `component` folder * feature(bento-add-banner): added unit tests for Android * feature(bento-add-banner): mapped the `dismiss-button-aria-label` attribute * feature(bento-add-banner): added minor notes to the stories * feature(bento-add-banner): added unit tests for amp-app-banner * feature(bento-add-banner): updated validator * feature(bento-add-banner): extracted services to common location * feature(bento-add-banner): added README for services * feature(bento-add-banner): updated type defs * feature(bento-add-banner): updated formatting * feature(bento-add-banner): lint fix * feature(bento-add-banner): lint ignores * feature(bento-add-banner): lint fixes * feature(bento-add-banner): type fixes * feature(bento-add-banner): updated z-index file * feature(bento-add-banner): updated validator template * feature(bento-add-banner): simplified code with `Array.find` * feature(bento-add-banner): parse meta content using `Array.reduce` * feature(bento-add-banner): added more tests for android * feature(bento-add-banner): added more tests for ios * feature(bento-add-banner): improved tests for BentoAppBanner * feature(bento-add-banner): added tests for Dismiss logic * feature(bento-add-banner): added more iOS tests * feature(bento-add-banner): tiny lint fix * feature(bento-add-banner): improved tests for web-component mode, and fixed the button[open-button] check * feature(bento-add-banner): removed unnecessary `waitFor` * feature(bento-add-banner): lint fix * feature(bento-add-banner): added whitespace in tests * feature(bento-add-banner): ensure tests are not dependent on timers * feature(bento-add-banner): removed obsolete `latestVersion` * feature(bento-add-banner): use `Object.fromEntries` as suggested * feature(bento-add-banner): removed unused CSS * feature(bento-add-banner): use `WindowInterface.getTop` to improve unit tests * feature(bento-add-banner): extracted querySelectorInSlot to core * feature(bento-add-banner): removed useless services, use object-syntax instead of classes, fixed fetchJson * feature(bento-add-banner): renamed services to utils * feature(bento-add-banner): removed redundant win variable * feature(bento-add-banner): extracted parsing logic into separate function for readability * feature(bento-add-banner): renamed file to `docInfo` * feature(bento-add-banner): improved safety of accessing localStorage * feature(bento-add-banner): ensure proper default value is returned * feature(bento-add-banner): removed unnecessary async * feature(bento-add-banner): ensure localStorage still works if `key` changes * feature(bento-add-banner): flip ternary for readability * feature(bento-add-banner): added `self` for fetch * feature(bento-add-banner): updated generated z-index file * feature(bento-app-banner): ensure XHR rejects invalid status codes * feature(bento-app-banner): removed dependencies on `/src/url` * feature(bento-app-banner): lint sample code * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): minor code improvements * feature(bento-app-banner): allow localStorage from custom hook * feature(bento-app-banner): include optional `init` param for requests * feature(bento-app-banner): improved logging * feature(bento-app-banner): only expose `logger[info|warn|error]` * feature(bento-app-banner): warn when localStorage.setItem fails * feature(bento-app-banner): ensure logger can be stubbed and tested * feature(bento-app-banner): moved `INVALID_PROTOCOLS` to proper location * feature(bento-app-banner): ensure logger is globally disabled * feature(bento-app-banner): ensure component inherits from AmpPreactBaseElement * Update src/preact/utils/docInfo.js Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: scottrippey <[email protected]> Co-authored-by: Justin Ridgewell <[email protected]>
… get better analytics results (#37334) * Changes to the blueconic.json * Added properties to the defaultTrackingValues and trackingValuesWithoutGeo * Fixed the failing unit test
* change rcmwidget ads extension parameters * circle/ci prettify fix
Email format doesn't allow template for the submitting div. See https://github.com/ampproject/amphtml/blob/92155aab898ad949209dc4e0bc72bddfe02febba/validator/validator-main.protoascii#L2705-L2707.
Co-authored-by: rebeccanthomas <[email protected]>
* Remove knobs from selector and sidebar storybooks. * Remove knobs from amp sidebar storybook. * Knobs Migration: Respond to reviewer comments. * Add comment to add clarity to the options in `bento-sidebar`'s storybook. * Add comments for clarity in usage of `undefined`. * Convert knobs to controls in stories for lightbox, soundcloud, and timeago. * Reorder variable declarations to be before their first use. * Fix capitalization error and missing return statement. * Move controls with type boolean, string, or number from argTypes to args. * Move inferrable controls from argtypes to args Co-authored-by: rebeccanthomas <[email protected]>
* Migrate knobs to controls for stories 54..61. * Update storybooks to use `args` for selector types which can be inferred i.e. strings, numbers, and booleans. Co-authored-by: rebeccanthomas <[email protected]>
…radii (#37817) * updated animation logic to support different multi-line border radius * update unit test * removed multi-line border radius code * removed multi line border radius * removed unused var
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
* Add react remapping to import resolver plugin * Add comment * Simplify react/index exports * Add small change to trigger CI build * remap react to preact using babel when bundling for preact Co-authored-by: William H.G. Johnson <[email protected]>
* Generate initial amp-date-picker 1.0 * Add initial test * Set value from single input in state * Add date parsing and formatting * Add hidden input field for single date * Add hidden start and end date elements * Refactor to fix component length * Add additional range test * Add imports and copy/pasted CSS * Add DayPicker controller imports * Add date-fns and react-day-picker * Test overlay mode error cases * Add DayPicker component (this currently breaks the tests) * Temporarily stub react to fix external module test * Re-add react-dates and add change date tests * Fix createLTR error by importing react-dates/initialize * Add selected dates and initial month * Swap out react-dates for react-day-picker * Fix test babel config * Refactor single input to avoid saving input field in state * Refactor start and end dates * Update calendar state logic * Add basic aria label to date butons * Add basic blocked dates functionality * Add blocked date range rules * Add RRULE blocked date parsing * Add highlighted dates * Refactor date picker into single and range components * Extract test helpers to separate file * Replace children logic * Refactor conditional logic for top-level date picker * Fix rrule tests to include start date * Add min date * Add default min value and test stub * Add max date * Add month formatting and base date picker abstraction * Fix storybook build and test week day formatting * Add initial state hook and refactor single input state * Add basic opening logic * Move state machine to single date picker * Add basic click and focus behavior * Update build-system/compile/bundles.config.extensions.json Add npm flag Co-authored-by: William Johnson <[email protected]> * Change conditional date picker syntax * Remove onErrorRef * Add range input state machine * Extract date picker state hook * Refactor state hook arguments * Remove unused imports * Add imperative clear function * Add single date picker API and types * Update type definitions * Add API methods for date range picker * Add locale * Add locale to base date picker * Fix storybook * Add first disabled date based on maximumNights prop * Add minimum nights prop * Refactor to use DOM input for existing input field * Add event handler for input change * Replace date range children logic with DOM functions * Add provider for accessing selected dates * Add overlay closing logic * Add range event listeners * Refactor state machine to remove unnecessary values * Add controlled month for setting date from input * Add initial typescript configuration * Convert base component to typescript * Convert single date picker to typescript * Convert constants and helper files * Refactor to use shared input functions * Replace locale string prop with object * Update API args * Add generic attribute parser to parse-props.js * Add parsers and base element props * Add openAfterClear attribute (not implemented) * Update extensions config * Move components and helpers into /component directory * Add initial amp test setup * Add packages and config to render AMP storybook * Add numberOfMonths prop * Add initial date picker bento test fixture * Update src/preact exports to export preact types * Add initial e2e test (not working right now) * Impement openAfterClear prop * Remove unnecessary babel package * Remove duplicate extension config * Move component.type * Fix .tsx extension Co-authored-by: Justin Ridgewell <[email protected]> * Undo preact type exports * Fix date picker e2e test (still no calendar) * Add React import resolvers for all external imports * Revert "Add React import resolvers for all external imports" This reverts commit 0e826f0. * Add basic CSS styles to mimic original date picker * Add aliases to unminified babel config * Use local preact file as react alias * Add optional today prop for simulating today's date * Use today as default for initialVisibleMonth * Add shadow dom support to range date picker * Refactor date pickers and context * Add preact types * Move date parsers and formatters into context * Updates function descriptions * WIP Add e2e tests * Tempoariliy fix forwardRef is not defined error * Fix static date range logic * Add non-working overlay range picker test * Fix date picker in overlay mode * Fix single date picker click event * Fix typo * Fix select date range and storybook * Update comments and date picker component return type * Move helpers to reduce base date picker props * Add TODO * Re-add 0.1 component to bundles.config.extensions.json * Move CSS variables * Use optional chaining for invocation.args * Add parseNumber function with radix * Fix type definitions * Get rid of default props object and type complexity * Update base date picker props * Remove pointless input hidden check * Move default props to provider In an attempt to share defaults and make it less confusing which props are coming from the provider and which props are getting passed into the component, this moves all default props to the provider and creates more type safety for the date picker components that get data from this provider. A potential downside of this change is that it makes it more difficult to use the SingleDatePicker component and RangeDatePicker in isolation if that is something we want to do later. * Extract iterateDateRange to helpers * Rename change handlers * Inline initializeStateMachine function * Add JSS stylesheet to for calendar * Hide calendar using display:none instead of unmounting * Add basic overlay styles (no fixed height) * Downgrade chrome driver * Remove extraAliases from config and rename preact alias to react * Remove AMP test files * Fix z-index file * Fix test helper (to trigger CI) Co-authored-by: William Johnson <[email protected]> Co-authored-by: Justin Ridgewell <[email protected]>
* init 4w * init 4w * add ads 4wmarketplace * fix * fix style js and md * fix style js * fix js Co-authored-by: Peppe L <[email protected]>
…eriment (#37843) * Added tasts * Undo * Added logic and tests * Updated tests with correct version * Updated comment Co-authored-by: Gabriel Majoulet <[email protected]> * Catch error in JSON inlined * Removed empty lines * Changed attribute to amp-localization * Added json fetching for testing * Remove .only * Install localization strings if inside experiment * Added tests * Moved test to inside describes * Remove unused function * Remove unused import * Reverted index.js * Added dep check * Made tests more explicit * Catching unknown language * Fixed comments from gmajoulet * Remove unused fetchStub const, test with performance service Co-authored-by: Gabriel Majoulet <[email protected]>
* Added tasts * Undo * Revert lazy extension installation * Removed tests * Removed unused preact import in test
…37887) * Added tasts * Undo * Make observable work with removing items while firing * Using set for removing * Remove previous code * Added iterating depth * Added test to check iterations of handler removal * Simplified impl and cleaned unused tests * Added comment
…ake it optional (#37897) * change to vendor and make it optional * space
* Remove knobs and add args to amp-layout, context, wrappers.
Remove disabled stories, and all its uses and remove storybook
allowlist.
* Move all inferrable type controls from argTypes to args.
* Return accidentally removed 'withA11y' error.
* Re-order attributes to include {...args} first because subsequent values
may be a part of the args.
* Add default value for wrapperStyle.
Co-authored-by: rebeccanthomas <[email protected]>
…ion (#37928) * Added tasts * Undo * Removed FOUT on Open Sans * Revert weight to 700 * Fixed wrong weight * Set line-height to 1.5em
#37929) * Added tasts * Undo * Remove system layer CLS * Remove also desktop CLS * Revert moving creation of shadow root * Update extensions/amp-story/1.0/amp-story-system-layer.js Co-authored-by: Gabriel Majoulet <[email protected]> Co-authored-by: Gabriel Majoulet <[email protected]>
* Added tasts * Undo * Added logic and tests * Updated tests with correct version * Updated comment Co-authored-by: Gabriel Majoulet <[email protected]> * Catch error in JSON inlined * Removed empty lines * Changed attribute to amp-localization * Added json fetching for testing * Remove .only * Install localization strings if inside experiment * Added tests * Moved test to inside describes * Remove unused function * Remove unused import * Reverted index.js * Added dep check * Made tests more explicit * Catching unknown language * Localize system layer + localization service changes * Install all bundles at the same time * Fixed tests with installing all bundles * Fixed comments from gmajoulet * Remove unused fetchStub const, test with performance service * Revert observable change * Use object.keys instead of entries * Fixed iteration * Use localizeTemplate * Updated tests * Remove .only Co-authored-by: Gabriel Majoulet <[email protected]>
… they are located on the active story page (#37881) * Create example with which a successful repro is possible * Debugging: Update amp-audio.html example file with looping audio * Debugging: Update amp-audio.html * Remove debugging logs * Prevent a story page from being unmuted when it is not the active page * Prevent media elements from being played if they are located on an inactive page * Remove unintentional changes and debugging-related updates * Update failing tests in test-media-tasks.js and add new tests * Fix mistake in setup of 'should not call unmute() test' * Add a missing setup expectation to the 'should call play()' media task test * Revert media task solution changes * Add early returns throughout amp-story-page.resume() that prevent the method from continuing to execute when the page is no longer active
… amp-story (#37776) * Create a new extension that would control paywall experience in amp-story. Boilerplate code only. * Update extensions/amp-story-subscription/OWNERS Co-authored-by: Caleb Cordry <[email protected]> * Add validator required changes to pass the presubmit. * Update validation result * Replace htmlFor with JSX. Add I2I issue to the comment. * Add amp-story-subscription.html to allowlist. Will remove it once the validator in npm contains the new validator rule files in this PR. * Fix lint errors * Add a todo to remove allowlist once the validator rules are in. * Rename amp-story-subscription to amp-story-subscriptions. Update owner file. * Fix validator .out file. * Remove 'latest' verson as it's been deprecated. * Add new states for displaying subscription dialog. Also add required attributes to corresponding story pages. * Delete trailing spaces. * Add store service dependency. * Apply Z_INDEX.md change. * Marking attributes in new extension instead of in amp-story. Add function in AmpStoryPage to check if paywall protected. Also some fixes. * StoreService fixes. Also remove the AmpStoryPage attribute setting functions and do it in the new extension * Remove enums so that AmpStoryPage won't have dependency on new extension to prevent the double loading issue of the new extension. * Call query selector on the document instead of the custom element, otherwise it won't find anything. * Add unit test case for paywall triggering upon receiving state update. * Fix lint error * Protect paywall logic behind an experiment. Some other minor fixes * Optimize code * Unit test fix: wait for a tick to ensure the listeners registration happens before dispatching the event. * Trigger AMP story paywall dialog. Adding callbacks to SubscriptionService to disable paywall once the entitlement is granted. * Fix linter errors * Fix z-index * CSS fixes * Unit test fix. Remove unnecessary switchTo call. * Update z_index markup * Move dialog wrapper CSS style to amp-story-subscriptions * Fix CSS. Use JSX for UI. Use localized strings. Update comments. * Fix localized string bug * Move all paywall triggering logic from amp-story to amp-story-subscriptions. This would remove all SubscriptionService dependencies from amp-story and keep all paywall logic in the new extension * Use publisher-logo-url from amp-story instead. Also added a test to verify the url itself. * Remove all subscriptions-section attribute logic. This is not needed since the story blocking logic is completely controlled by amp-story instead of amp-subscriptions. Also add comments to clarify why we don't need to wait for the entitlement to be resolved manually. * Fix linter error * Update comment * Wait on entitlement response before showing paywall. Use an enum instead of boolean to represent subscription state. * Fix dependency test * Separate the logic of switching subscription states and dialog ui state. * Remove all changes and keep only the the amp-subscriptions ones to make this PR smaller * Add the test to verify the callback added by the new API would still persist after platform store gets reset. This is to ensure the callback added by amp-story would be executed properly. * Add the usage of story-specific dialog wrapper class. Add unit test for maybeSelectAndActivatePlatform. Update unit test for platform store * Update based on missed comments * update unit tests * Really remove expect import... * nit * Update unit test with exactly params * Fix import * nit * Paywall-related story navigation * Remove isPaywallProteced function. Move common logic in unit test to beforeEach. * Remove unnecessary intitialize_ call * Fix lint error * Paywall-related story navigation * Remove isPaywallProteced function. Move common logic in unit test to beforeEach. * Fix lint error * Update toggle action name to fix unit test * Add end-to-end verification for platform activation to the unit test * Fix unit test * Remove pending state check since switchTo already has some guard against the multiple switchTo calls to the same page. * If starting deep in story, initialize with paywall page and navigate back to original page after granted. Update unit tests. Co-authored-by: Caleb Cordry <[email protected]> * Fix unit test by making RAF a sync op earlier than all click event dispatches. * Flatten if else nested blocks. Also add a test case for any switch events to locked pages. * Resume to the correct page even after tap previous. Click-based paywall triggering should resume to the page after the paywall page instead. Update test cases. Pull out some logic as helper functions to improve readability. * lint * Update extensions/amp-story/1.0/amp-story.js Co-authored-by: Caleb Cordry <[email protected]> * Add a new navigation direction so that we don't need to maintain states manually with an extra private variable. * Simply handle pageAfterGranted_ differrently based on the target index. * Update comment. * Flatten paywall if else blocks. Also add a new sub state to facilitate that. * Flatten the structure a bit by separating the logic of showing ui and switching to the paywall page. * lint * Hide paywall dialog only for the paywall-enabled stories. * Fix race condition issues in other unit tests by stubbing some async operations with sync ones. * Refactor to simplify logic and the readability. Big refactoring on the unit test also. * Apply suggestions from code review Co-authored-by: Gabriel Majoulet <[email protected]> * last nits Co-authored-by: Caleb Cordry <[email protected]> Co-authored-by: Caleb Cordry <[email protected]> Co-authored-by: Gabriel Majoulet <[email protected]>
* Added tasts * Undo * Added logic and tests * Updated tests with correct version * Updated comment Co-authored-by: Gabriel Majoulet <[email protected]> * Catch error in JSON inlined * Removed empty lines * Changed attribute to amp-localization * Added json fetching for testing * Remove .only * Install localization strings if inside experiment * Added tests * Moved test to inside describes * Remove unused function * Remove unused import * Reverted index.js * Added dep check * Made tests more explicit * Catching unknown language * Localize system layer + localization service changes * Install all bundles at the same time * Fixed tests with installing all bundles * Fixed comments from gmajoulet * Remove unused fetchStub const, test with performance service * Revert observable change * Use object.keys instead of entries * Fixed iteration * Use localizeTemplate * Updated tests * Remove .only * Fix mutate not accepting return values Co-authored-by: Gabriel Majoulet <[email protected]>
* create separate init-tests script for bento tests * separates bento unit testing files from other unit files * adds bento-specific unit testing utilities * updates defineElement() fns to accept a window attribute (useful for testing)
* function and tests * null test * comment * better test * remove only * lint * update url to src * add srclang * set crossorigin * Update tests. * ACAO header test * update api and tests * update e2e test * Update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )