♻️ Async-ify and clean up test-visibility-states.js #37494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
force-pushed
the
sp-viz-states-tests
branch
from
3554da0
to
c274fb9
Compare
rileyajones
approved these changes
Jan 27, 2022
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Feb 2, 2022
* async-await-ify beforeEach * async-await-ify test fns * async-await-ify test beforeEach * Mirror `changeVisibility` helper * vertical whitespace * Empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #37129, I'm going to be adding tests to this file. It's bit-rotted a bit, with a few different conventions for doing the same thing. This migrates the file to use async-await in most places (instead of just a few) and generally standardizes the format/vertical spacing of the tests themselves.