Replacing validation param #37469
Merged
Replacing validation param #37469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AntonMsk please rebase against the latest main branch. It is causing circle failure. |
powerivq
approved these changes
Jan 25, 2022
|
The PR looks good. Once you can have it rebased and everything passes, I can merge. |
|
@powerivq, thanks for fast feedback! Now it should work |
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Jan 26, 2022
* add myua to vendors list * fix year and cleaning * remove copyright notices * fix linter errors * replace demo param with env * replace validation demo param with env
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Feb 2, 2022
* add myua to vendors list * fix year and cleaning * remove copyright notices * fix linter errors * replace demo param with env * replace validation demo param with env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we replaced validation param
demowithenv