Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing validation param #37469

Merged
merged 9 commits into from
Jan 26, 2022
Merged

Replacing validation param #37469

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
61d8221
add myua to vendors list
AntonMsk Sep 16, 2021
e614b8e
fix year and cleaning
AntonMsk Sep 17, 2021
76a6608
remove copyright notices
AntonMsk Sep 17, 2021
2f4e078
fix linter errors
AntonMsk Sep 22, 2021
795ee18
Merge branch 'ampproject:main' into add-myua-vendor
AntonMsk Sep 22, 2021
28a252f
replace demo param with env
AntonMsk Dec 28, 2021
bacf60b
Merge branch 'main' into add-myua-vendor
AntonMsk Dec 28, 2021
ceee556
replace validation demo param with env
AntonMsk Jan 25, 2022
1f612ce
Merge branch 'main' into add-myua-vendor
AntonMsk Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ads/vendors/myua.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {validateData} from '#3p/3p';
* @param {!Object} data
*/
export function myua(global, data) {
validateData(data, ['sid', 'iid'], ['demo', 'options']);
validateData(data, ['sid', 'iid'], ['env', 'options']);

const informerTag = global.document.createElement('div');
informerTag.setAttribute('data-top-iid', data.iid);
Expand Down