Add meta tag to variable list in story ads #37433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
force-pushed
the
meta-tag-story
branch
3 times, most recently
from
74ed230
to
8618f0d
Compare
powerivq
force-pushed
the
meta-tag-story
branch
from
8618f0d
to
628bf86
Compare
calebcordry
reviewed
Jan 24, 2022
powerivq
force-pushed
the
meta-tag-story
branch
2 times, most recently
from
6ae0d69
to
bc6961e
Compare
calebcordry
reviewed
Jan 28, 2022
| const result = map(); | ||
| iterateCursor(metaTags, (tag) => { | ||
| const {content, name} = tag; | ||
| // If the meta tag name is not alphanumberical, we would ignore it. |
calebcordry
approved these changes
Jan 28, 2022
powerivq
force-pushed
the
meta-tag-story
branch
from
bc6961e
to
c9608a2
Compare
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #37423
It pulls the meta tags from body once and filters them accordingly.