Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync for validator cpp engine and cpp htmlparser #37510

Merged
merged 7 commits into from
Jan 27, 2022
Merged

Sync for validator cpp engine and cpp htmlparser #37510

merged 7 commits into from
Jan 27, 2022

Conversation

twifkak
Copy link
Member

@twifkak twifkak commented Jan 27, 2022

This is an automatically generated pull request.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 27, 2022 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-caching! These files were changed:

validator/cpp/engine/BUILD
validator/cpp/engine/validator-internal.cc
validator/cpp/engine/validator.h
validator/cpp/engine/validator_test.cc

@twifkak twifkak mentioned this pull request Jan 27, 2022
Closed
@twifkak twifkak requested a review from banaag January 27, 2022 23:42
@twifkak twifkak enabled auto-merge (squash) January 27, 2022 23:45
@twifkak twifkak merged commit a602362 into main Jan 27, 2022
samouri pushed a commit to samouri/amphtml that referenced this pull request Feb 2, 2022
@twifkak @caoboxiao @samouri
Sync for validator cpp engine and cpp htmlparser (ampproject#37510)
1f0d2dd 
* Add C++ tests on whether validator rules make sense

PiperOrigin-RevId: 423415201

* Remove allowlist of tags which have no descriptive name

PiperOrigin-RevId: 423430953

* Fix a bug by no longer using string_view of block scope string

PiperOrigin-RevId: 423900419

* Test whether attribute rule makes sense

PiperOrigin-RevId: 424432911

* Test whether satisfies match up with requires and excludes

PiperOrigin-RevId: 424454520

* Test whether error codes are unique

PiperOrigin-RevId: 424454591

* Fix compile errors in github unit test

PiperOrigin-RevId: 424701686

Co-authored-by: Boxiao Cao <[email protected]>
@twifkak twifkak deleted the piper_twifkak_av_12 branch February 2, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banaag banaag banaag approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twifkak @banaag @ampprojectbot @caoboxiao