Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync for validator cpp engine and cpp htmlparser #37497

Closed
wants to merge 6 commits into from
Closed

Sync for validator cpp engine and cpp htmlparser #37497

wants to merge 6 commits into from

Conversation

twifkak
Copy link
Member

@twifkak twifkak commented Jan 27, 2022

This is an automatically generated pull request.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 27, 2022 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-caching! These files were changed:

validator/cpp/engine/BUILD
validator/cpp/engine/validator-internal.cc
validator/cpp/engine/validator.h
validator/cpp/engine/validator_test.cc

@twifkak
Copy link
Member Author

twifkak commented Jan 27, 2022

@antiphoton It seems that one of your commits is causing a failure in //cpp/engine:validator_test. Can you take a look?

@antiphoton antiphoton self-assigned this Jan 27, 2022
@antiphoton
Copy link
Member

Created cl/424665807 to fix this.

@twifkak
Copy link
Member Author

twifkak commented Jan 27, 2022

Closing in favor of #37510.

@twifkak twifkak closed this Jan 27, 2022
@twifkak twifkak deleted the piper_twifkak_av_11 branch February 2, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@antiphoton antiphoton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twifkak @antiphoton @caoboxiao