Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync for validator cpp engine and cpp htmlparser #37497

Closed
wants to merge 6 commits into from
Closed

Sync for validator cpp engine and cpp htmlparser #37497

wants to merge 6 commits into from

Commits on Jan 27, 2022

  1. Add C++ tests on whether validator rules make sense 

    PiperOrigin-RevId: 423415201
    @caoboxiao @twifkak
    caoboxiao authored and twifkak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    054c101 View commit details
    Browse the repository at this point in the history

  2. Remove allowlist of tags which have no descriptive name 

    PiperOrigin-RevId: 423430953
    @caoboxiao @twifkak
    caoboxiao authored and twifkak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    d11f9af View commit details
    Browse the repository at this point in the history

  3. Fix a bug by no longer using string_view of block scope string 

    PiperOrigin-RevId: 423900419
    @caoboxiao @twifkak
    caoboxiao authored and twifkak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    4b72a4b View commit details
    Browse the repository at this point in the history

  4. Test whether attribute rule makes sense 

    PiperOrigin-RevId: 424432911
    @caoboxiao @twifkak
    caoboxiao authored and twifkak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    df87eb0 View commit details
    Browse the repository at this point in the history

  5. Test whether satisfies match up with requires and excludes 

    PiperOrigin-RevId: 424454520
    @caoboxiao @twifkak
    caoboxiao authored and twifkak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    6f957be View commit details
    Browse the repository at this point in the history

  6. Test whether error codes are unique 

    PiperOrigin-RevId: 424454591
    @caoboxiao @twifkak
    caoboxiao authored and twifkak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    a46bbf8 View commit details
    Browse the repository at this point in the history