Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 amp-story-shopping removes support for different multi-line border radii #37817

Merged
merged 6 commits into from
Mar 15, 2022

Conversation

jshamble
Copy link
Contributor

@jshamble jshamble commented Mar 3, 2022

#closes #37808
Some animation CSS keyframes were not calculating the border-radius properly, this PR fixes them.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Mar 3, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-tag.css
extensions/amp-story-shopping/0.1/amp-story-shopping-tag.js

@jshamble jshamble changed the title 🐛 amp-story-shopping updated animation keyframes to support different multi-line border radius 🐛 amp-story-shopping updated animation keyframes to support different multi-line border radii Mar 4, 2022
@processprocess
Copy link
Contributor

I spoke with @hongcatlover and we decided to remove the different border radius on two line text.
#37808 is updated with details.

@processprocess
Copy link
Contributor

Nice. Please update the name of the PR to reflect the change. Once the linting check is resolved I think this will be good to go.

@jshamble jshamble changed the title 🐛 amp-story-shopping updated animation keyframes to support different multi-line border radii 🐛 amp-story-shopping updated animation keyframes to remove support for different multi-line border radii Mar 14, 2022
@jshamble jshamble changed the title 🐛 amp-story-shopping updated animation keyframes to remove support for different multi-line border radii 🐛 amp-story-shopping removes support for different multi-line border radii Mar 14, 2022
Copy link
Contributor

@processprocess processprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! (Also thank you for fixing my typo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[amp story shopping] Remove multi line border radius code
3 participants