📖 Mention that amp-state can contain a constant #37479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an example showing that it can be initialized to a constant, not just an object. (This is something I was never sure about when I first started using AMP.)
extensions/amp-bind/amp-bind.md
Outdated
| <amp-state id="singleton"> | ||
| <script type="application/json"> | ||
| { | ||
| 'I am a string' |
There was a problem hiding this comment.
This is not valid JSON, is that intended?
This would work afaik:
<script type="application/json">
'I am a string'
</script>
There was a problem hiding this comment.
Good catch. I tested out something that looks exactly like what you did. Then, when I edited the docs, I added the useless curly brackets.
sebastianbenz
approved these changes
Jan 26, 2022
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Jan 26, 2022
* Mention that amp-state can contain a constant Add an example showing that it can be initialized to a constant, not just an object. (This is something I was never sure about when I first started using AMP.) * Is prettify complaining because my line's >= 80 characters? * Trying still to make prettier happy. So embarrassing. * Remove spurious curly braces
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Feb 2, 2022
* Mention that amp-state can contain a constant Add an example showing that it can be initialized to a constant, not just an object. (This is something I was never sure about when I first started using AMP.) * Is prettify complaining because my line's >= 80 characters? * Trying still to make prettier happy. So embarrassing. * Remove spurious curly braces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example showing that it can be initialized to a constant, not just an object. (This is something I was never sure about when I first started using AMP.)
Note - I wasn't able to get the import to work on my local machine, so I tested this with an outdated version of the docs. It might be worth verifying this on a fully working build!