[FEA] Update Treelite to 2.0.0 to remove the dmlc-core dependency #4037
Labels
Build or Dep
Issues related to building the code or dependencies
feature request
New feature or request
Tech Debt
Issues related to debt
Comments
hcho3
added
feature request
|
@dantegd Can this be assigned to Issue-P1 of v21.08 Release? |
hcho3
added
Build or Dep
|
Update: I filed a draft PR dmlc/treelite#285 |
|
dmlc/treelite#285 is now ready for review. It's been tested against the existing suite of integration tests in Treelite. For ease of review, I've split the refactor PR into smaller pieces: dmlc/treelite#287, dmlc/treelite#288, dmlc/treelite#289, dmlc/treelite#290, dmlc/treelite#291, dmlc/treelite#292, dmlc/treelite#293. |
rapids-bot bot
pushed a commit
that referenced
this issue
Jul 21, 2021
Closes #4037. The 2.0.0 version of Treelite incorporates the following major improvements: * **Remove dmlc-core dependency** (dmlc/treelite#284). * Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295) * Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297) * Handle LightGBM models with '=' in feature names (dmlc/treelite#298) * Remove OpenMP dependency (dmlc/treelite#300) Depends on rapidsai/integration#315 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: #4072
rapids-bot bot
pushed a commit
that referenced
this issue
Nov 13, 2021
…ects (#4317) closes #4037 Adds index field to cumlarray to be able to use it to construct the output with the correct index from inputs. Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) URL: #4317
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this issue
Oct 9, 2023
Closes rapidsai#4037. The 2.0.0 version of Treelite incorporates the following major improvements: * **Remove dmlc-core dependency** (dmlc/treelite#284). * Rename CHECK and LOG macros to avoid name collisions (dmlc/treelite#295) * Suppress warning about build time when parallel_comp is specified (dmlc/treelite#297) * Handle LightGBM models with '=' in feature names (dmlc/treelite#298) * Remove OpenMP dependency (dmlc/treelite#300) Depends on rapidsai/integration#315 Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#4072
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this issue
Oct 9, 2023
…ects (rapidsai#4317) closes rapidsai#4037 Adds index field to cumlarray to be able to use it to construct the output with the correct index from inputs. Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) URL: rapidsai#4317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, cuML depends on Treelite, which in turn depends on
dmlc-core. The implicit dependency ondmlc-corehave caused issues in the past, when cuML is tested with other packages that usedmlc-core, e.g. XGBoost. See https://github.com/rapidsai/ops/issues/1343 for an example.I am now working on the 2.0.0 release of Treelite that removes the
dmlc-coredependency. Tracking issue: dmlc/treelite#284The text was updated successfully, but these errors were encountered: