Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve indexing in methods when applied to DataFrame and Series objects #4317

Merged
merged 13 commits into from
Nov 13, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Oct 29, 2021

closes #4037

Adds index field to cumlarray to be able to use it to construct the output with the correct index from inputs.

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Oct 29, 2021
@dantegd dantegd requested a review from a team as a code owner October 29, 2021 21:42
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 29, 2021
@dantegd dantegd added the 2 - In Progress Currenty a work in progress label Oct 29, 2021
@dantegd dantegd changed the title Preserve indexing in methods when applied to DataFrame and Series objects Preserve indexing in methods when applied to DataFrame and Series objects [skip-ci] Nov 1, 2021
@dantegd dantegd changed the title Preserve indexing in methods when applied to DataFrame and Series objects [skip-ci] Preserve indexing in methods when applied to DataFrame and Series objects Nov 1, 2021
@dantegd
Copy link
Member Author

dantegd commented Nov 2, 2021

rerun tests

@dantegd dantegd added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Nov 11, 2021
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one suggestion, but otherwise I love it.

python/cuml/common/input_utils.py Outdated Show resolved Hide resolved
@dantegd dantegd changed the title Preserve indexing in methods when applied to DataFrame and Series objects Preserve indexing in methods when applied to DataFrame and Series objects [skip-ci] Nov 12, 2021
@dantegd dantegd changed the title Preserve indexing in methods when applied to DataFrame and Series objects [skip-ci] Preserve indexing in methods when applied to DataFrame and Series objects Nov 12, 2021
@dantegd
Copy link
Member Author

dantegd commented Nov 12, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@34f7929). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4317   +/-   ##
===============================================
  Coverage                ?   86.03%           
===============================================
  Files                   ?      231           
  Lines                   ?    18751           
  Branches                ?        0           
===============================================
  Hits                    ?    16132           
  Misses                  ?     2619           
  Partials                ?        0           
Flag Coverage Δ
dask 47.02% <0.00%> (?)
non-dask 78.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f7929...bf3a48e. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Nov 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4d3410a into rapidsai:branch-21.12 Nov 13, 2021
rapids-bot bot pushed a commit that referenced this pull request Nov 15, 2021
…es (#4300)

This PR makes it possible to train single GPU cuML models using Dask DataFrames and Series by converting the Dask data-structures to their cudf counterparts before training. This will allow using Dask-SQL with cuML models.

Tests added for logistic regression, currently working on adding more

Depends on #4317

Authors:
  - https://github.com/ChrisJar
  - Sarah Yurick (https://github.com/sarahyurick)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4300
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…ects (rapidsai#4317)

closes rapidsai#4037 

Adds index field to cumlarray to be able to use it to construct the output with the correct index from inputs.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4317
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…es (rapidsai#4300)

This PR makes it possible to train single GPU cuML models using Dask DataFrames and Series by converting the Dask data-structures to their cudf counterparts before training. This will allow using Dask-SQL with cuML models.

Tests added for logistic regression, currently working on adding more

Depends on rapidsai#4317

Authors:
  - https://github.com/ChrisJar
  - Sarah Yurick (https://github.com/sarahyurick)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Update Treelite to 2.0.0 to remove the dmlc-core dependency
3 participants