-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve indexing in methods when applied to DataFrame and Series objects #4317
Conversation
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one suggestion, but otherwise I love it.
Co-authored-by: William Hicks <[email protected]>
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #4317 +/- ##
===============================================
Coverage ? 86.03%
===============================================
Files ? 231
Lines ? 18751
Branches ? 0
===============================================
Hits ? 16132
Misses ? 2619
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@gpucibot merge |
…es (#4300) This PR makes it possible to train single GPU cuML models using Dask DataFrames and Series by converting the Dask data-structures to their cudf counterparts before training. This will allow using Dask-SQL with cuML models. Tests added for logistic regression, currently working on adding more Depends on #4317 Authors: - https://github.com/ChrisJar - Sarah Yurick (https://github.com/sarahyurick) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #4300
…ects (rapidsai#4317) closes rapidsai#4037 Adds index field to cumlarray to be able to use it to construct the output with the correct index from inputs. Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) URL: rapidsai#4317
…es (rapidsai#4300) This PR makes it possible to train single GPU cuML models using Dask DataFrames and Series by converting the Dask data-structures to their cudf counterparts before training. This will allow using Dask-SQL with cuML models. Tests added for logistic regression, currently working on adding more Depends on rapidsai#4317 Authors: - https://github.com/ChrisJar - Sarah Yurick (https://github.com/sarahyurick) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4300
closes #4037
Adds index field to cumlarray to be able to use it to construct the output with the correct index from inputs.