Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dmlc::Timer and dmlc::optional #292

Merged
merged 3 commits into from
Jul 11, 2021

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jul 9, 2021

Extracted from #285.

  • Do not use dmlc/optional.h and dmlc/timer.h.
  • Re-implement GetTime() and optional<>.

Comment on lines +20 to +24
#if defined(__APPLE__) && defined(__MACH__)
#include <mach/mach.h>
#include <mach/mach_init.h>
#include <mach/thread_policy.h>
#endif
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to avoid build failure on MacOS.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #292 (45b6826) into mainline (262f782) will increase coverage by 0.01%.
The diff coverage is 89.65%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #292      +/-   ##
==============================================
+ Coverage       84.99%   85.01%   +0.01%     
  Complexity         46       46              
==============================================
  Files             103      104       +1     
  Lines            7959     7979      +20     
  Branches           50       50              
==============================================
+ Hits             6765     6783      +18     
- Misses           1169     1171       +2     
  Partials           25       25              
Impacted Files Coverage Δ
src/compiler/ast/ast.h 38.82% <0.00%> (ø)
src/predictor/thread_pool/thread_pool.h 96.22% <ø> (ø)
include/treelite/optional.h 88.23% <88.23%> (ø)
src/compiler/ast/fold_code.cc 86.79% <100.00%> (ø)
src/compiler/ast_native.cc 96.13% <100.00%> (ø)
src/predictor/predictor.cc 90.97% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262f782...45b6826. Read the comment docs.

@hcho3 hcho3 merged commit 1729810 into dmlc:mainline Jul 11, 2021
@hcho3 hcho3 deleted the remove_dmlc_optional branch July 11, 2021 11:42
@hcho3 hcho3 mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants