-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the use of dmlc::JSONWriter, dmlc::Stream, and dmlc serializer #289
Conversation
a733551
to
37d5b13
Compare
Codecov Report
@@ Coverage Diff @@
## mainline #289 +/- ##
==============================================
- Coverage 84.77% 83.92% -0.85%
Complexity 46 46
==============================================
Files 102 102
Lines 7821 7889 +68
Branches 50 50
==============================================
- Hits 6630 6621 -9
- Misses 1166 1243 +77
Partials 25 25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked briefly. Not a complete review.
Extracted from #285.
dmlc/json.h
,dmlc/io.h
, anddmlc/serializer.h
.dmlc::Stream
withstd::fstream
andstd::stringstream
.dmlc::JSONWriter
withrapidjson::Writer
.uint64_t
for storing instance counts in JSON.TaskParameter
toTaskParam
, to be consistent withModelParam
.ReferenceSerialize
withSerializeToJSON
. Previously,ReferenceSerialize
was a reference implementation of serializer for tree models.ReferenceSerialize
was useful for verifying the correctness of other serializer methods of the tree objects. The reference serializer had to go, unfortunately, because it used dmlc serializer functions. As a replacement, I implemented a JSON serializerSerializeToJSON
. While not very efficient compared to binary serializers, the JSON serializer will be useful for debugging and testing.LoadText
withstd::istream
andstd::getline
.