Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of dmlc::thread_local #291

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jul 9, 2021

Extracted from #285.

  • Do not use dmlc/thread_local.h.
  • Replace dmlc::ThreadLocalStore with treelite::ThreadLocalStore, which is a light wrapper around thread_local storage.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #291 (19671e9) into mainline (5d7d968) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             mainline     #291   +/-   ##
===========================================
  Coverage       84.78%   84.78%           
  Complexity         46       46           
===========================================
  Files             101      102    +1     
  Lines            7899     7902    +3     
  Branches           50       50           
===========================================
+ Hits             6697     6700    +3     
  Misses           1177     1177           
  Partials           25       25           
Impacted Files Coverage Δ
include/treelite/logging.h 100.00% <ø> (ø)
src/c_api/c_api.cc 96.65% <ø> (ø)
src/c_api/c_api_common.cc 100.00% <ø> (ø)
src/c_api/c_api_error.cc 100.00% <ø> (ø)
src/c_api/c_api_runtime.cc 86.07% <ø> (ø)
include/treelite/thread_local.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7d968...19671e9. Read the comment docs.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcho3 hcho3 merged commit 5329e85 into dmlc:mainline Jul 10, 2021
@hcho3 hcho3 deleted the remove_dmlc_thread_local branch July 10, 2021 07:13
@hcho3 hcho3 mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants