-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dmlc logger #287
Remove dmlc logger #287
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #287 +/- ##
==============================================
+ Coverage 85.03% 85.10% +0.06%
Complexity 46 46
==============================================
Files 106 106
Lines 7978 8014 +36
Branches 50 50
==============================================
+ Hits 6784 6820 +36
Misses 1169 1169
Partials 25 25
Continue to review full report at Codecov.
|
cd38b74
to
d0b3482
Compare
d0b3482
to
cec5737
Compare
@trivialfis Thank you so much for reviewing the 7 pull requests! I was worried about the size of the changes required to remove |
Extracted from #285. Re-implement logging functionalities such as
CHECK
andLOG
, so that we no longer depend on the headerdmlc/logging.h
.