Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dmlc logger #287

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Remove dmlc logger #287

merged 3 commits into from
Jul 12, 2021

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jul 9, 2021

Extracted from #285. Re-implement logging functionalities such as CHECK and LOG, so that we no longer depend on the header dmlc/logging.h.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #287 (7bf2625) into mainline (e99ca01) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #287      +/-   ##
==============================================
+ Coverage       85.03%   85.10%   +0.06%     
  Complexity         46       46              
==============================================
  Files             106      106              
  Lines            7978     8014      +36     
  Branches           50       50              
==============================================
+ Hits             6784     6820      +36     
  Misses           1169     1169              
  Partials           25       25              
Impacted Files Coverage Δ
include/treelite/c_api_error.h 100.00% <ø> (ø)
include/treelite/frontend.h 90.00% <ø> (ø)
include/treelite/predictor.h 92.30% <ø> (ø)
src/annotator.cc 91.47% <ø> (ø)
src/c_api/c_api.cc 97.09% <ø> (ø)
src/compiler/ast/dump.cc 0.00% <ø> (ø)
src/compiler/ast/fold_code.cc 86.79% <ø> (ø)
src/compiler/ast/quantize.cc 98.11% <ø> (ø)
src/compiler/ast/split.cc 97.72% <ø> (ø)
src/compiler/common/code_folding_util.h 96.80% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99ca01...7bf2625. Read the comment docs.

include/treelite/logging.h Show resolved Hide resolved
include/treelite/logging.h Show resolved Hide resolved
include/treelite/logging.h Outdated Show resolved Hide resolved
include/treelite/logging.h Outdated Show resolved Hide resolved
include/treelite/logging.h Outdated Show resolved Hide resolved
include/treelite/logging.h Outdated Show resolved Hide resolved
include/treelite/logging.h Outdated Show resolved Hide resolved
@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 12, 2021

@trivialfis Thank you so much for reviewing the 7 pull requests! I was worried about the size of the changes required to remove dmlc, but thanks to your review, I can merge it with a peace of mind.

@hcho3 hcho3 merged commit 4dd95c4 into dmlc:mainline Jul 12, 2021
@hcho3 hcho3 deleted the remove_dmlc_logger branch July 12, 2021 01:20
@hcho3 hcho3 mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants